From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A2DC433F5 for ; Wed, 6 Apr 2022 23:50:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F6916B0071; Wed, 6 Apr 2022 19:49:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A6B26B0073; Wed, 6 Apr 2022 19:49:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 149B46B0074; Wed, 6 Apr 2022 19:49:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 024386B0071 for ; Wed, 6 Apr 2022 19:49:56 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AEDB6183E6C98 for ; Wed, 6 Apr 2022 23:49:46 +0000 (UTC) X-FDA: 79328099172.29.0622154 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf07.hostedemail.com (Postfix) with ESMTP id 3134340003 for ; Wed, 6 Apr 2022 23:49:46 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id bg10so7481651ejb.4 for ; Wed, 06 Apr 2022 16:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=L6vd3iqAulHbVbdUqojR4iZAkOip1DXsGelVL9h9BHY=; b=i6R06Ky/Hgn4obS/N2VWnaQGpHML5fC34PIlWhW6fGFoEMXwxJ0pE+TnLWsw3pQLVp rBAGI3Cd+Ozx8CI4bzbTeA1ShNwOH5dvkvTfOe/KqJ1hXbWY/4VGri9igFbgVll/v1fS 0drSnUzqsJQmhx6fDOhFs+N7pXjAas2N6bES0pgF6OS3jhalaJP0yltn/SvifS92RAei JXMTThfKTTY3cTYwRkVLc74K4us7DVoCf3PZjJKNnDSxfEiVmWhULj9Idq6F/bOF6FOx DHG+NsH1+yEVR4vW8ItyANrX2g3VSDGJP2oAxsn1/Dr50TFJEGLJObHueARLt6XLXnkm IyTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=L6vd3iqAulHbVbdUqojR4iZAkOip1DXsGelVL9h9BHY=; b=oDB3LFiFIWxvhHvxPaJzlGHJGtcAcSL52L2nSHIJ772M8SjLT38jYwrF0Dmc5nQPI1 Lzopu/aHKO/gxN9WosP5OwjA5KN0640IyIilELcOvkqveSfLNU7+WIMyymIGnoEPMtEx cdm64htCyL6+NAZB6+jJtQgHGmPnUhvD3E1WypS8eRiNFfwhr89T8FmFoOLY2yb1atDW lm9Z5mz3gw6O/0b7oCT1I9z7PqczvKTmF4X76UcTL+K9Qt3akKtYnpt9vJaRgsOiWHyR iRmUFUgJ8rwRM0BgnR8Q9XaA9WYKPihJk+W/z4k9EKuF42xfyvaelF08TGsqHKB8UJZ5 BX5w== X-Gm-Message-State: AOAM531qkMjlQijwruScZL538Th4a1YpLglOeZ0WfDBK8wV6mGQ5Tgn/ xizRpZGW8seILLViUWH9+jY= X-Google-Smtp-Source: ABdhPJwDSE+9EWn6hlzgdoBcszSoAnklTmJl8D+TB4xGGnblzI80I5TL7ZJpYbvlj8qKbL2H/VlutQ== X-Received: by 2002:a17:907:86a3:b0:6da:870c:af44 with SMTP id qa35-20020a17090786a300b006da870caf44mr10399816ejc.445.1649288984935; Wed, 06 Apr 2022 16:49:44 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id g10-20020a056402090a00b004196250baeasm8504008edz.95.2022.04.06.16.49.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Apr 2022 16:49:44 -0700 (PDT) Date: Wed, 6 Apr 2022 23:49:44 +0000 From: Wei Yang To: Matthew Wilcox Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, Johannes Weiner , Mel Gorman Subject: Re: [PATCH] mm/vmscan: reorder scan_balance definition to simplify the scan type check Message-ID: <20220406234944.uyd3yc7i7sf7lcmq@master> Reply-To: Wei Yang References: <20220405082357.22606-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3134340003 X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="i6R06Ky/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-Stat-Signature: omarhswre5p1c159mskw7t8hmkhjcrqu X-HE-Tag: 1649288986-853091 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000332, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 05, 2022 at 01:30:26PM +0100, Matthew Wilcox wrote: >On Tue, Apr 05, 2022 at 08:23:57AM +0000, Wei Yang wrote: >> Even is_file_lru() return bool type, we leverage it as an index for anon >> or file. >> >> With this in hand, after reorder scan_balance definition, we can compare >> directly between scan_balance and file to get the exclusive scan type. >> >> After this, the code looks more readable and save some instructions. > >This scares me. I would not apply this patch. Because? -- Wei Yang Help you, Help me