From: Wei Yang <richard.weiyang@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm/vmscan: reorder scan_balance definition to simplify the scan type check
Date: Wed, 6 Apr 2022 23:49:44 +0000 [thread overview]
Message-ID: <20220406234944.uyd3yc7i7sf7lcmq@master> (raw)
In-Reply-To: <Ykw2Yqm8wGwRhVpi@casper.infradead.org>
On Tue, Apr 05, 2022 at 01:30:26PM +0100, Matthew Wilcox wrote:
>On Tue, Apr 05, 2022 at 08:23:57AM +0000, Wei Yang wrote:
>> Even is_file_lru() return bool type, we leverage it as an index for anon
>> or file.
>>
>> With this in hand, after reorder scan_balance definition, we can compare
>> directly between scan_balance and file to get the exclusive scan type.
>>
>> After this, the code looks more readable and save some instructions.
>
>This scares me. I would not apply this patch.
Because?
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2022-04-06 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 8:23 Wei Yang
2022-04-05 12:30 ` Matthew Wilcox
2022-04-06 23:49 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406234944.uyd3yc7i7sf7lcmq@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox