From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1DBDC433F5 for ; Wed, 6 Apr 2022 23:48:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C10A6B0071; Wed, 6 Apr 2022 19:48:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1705A6B0073; Wed, 6 Apr 2022 19:48:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00F6E6B0074; Wed, 6 Apr 2022 19:48:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id E369C6B0071 for ; Wed, 6 Apr 2022 19:48:07 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 992CAAAAEC for ; Wed, 6 Apr 2022 23:47:57 +0000 (UTC) X-FDA: 79328094594.23.8A4C0A9 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf09.hostedemail.com (Postfix) with ESMTP id 1F995140004 for ; Wed, 6 Apr 2022 23:47:56 +0000 (UTC) Received: by mail-ed1-f49.google.com with SMTP id k2so4471326edj.9 for ; Wed, 06 Apr 2022 16:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=02d0w8PmklTy+xy8dNE5jEsKmZD5PVzo6uj8ETuD9Nw=; b=q5IxDBxPTJcEcQP9qhwWClBC1OhCH0NQTxB5GqC5eH+IfAnpIXJzIBePtweUQ8ewXI J2M18uI4A8XKNzkwdKK/1TLJS+fHhklEGiACO+gWZPmeQcWGqsySBZ8ktt7ABE9FTRgc 4hkcs0+4ipQEhip4GJvfyPpRPYBkPSRq/ezs6wpNAhL0jlc3tVE/kp4iW4hnQRlWf6YF 6o0MRfRv8jfqcgaIm296k4SjrXRnYTpG3D/x1/AawuX9riD31U66i/fEO0mYRrDu3apa sYygC7Y9VAJgSuu36KlMrJoidWnSr6KJcN9ulNyHAk3EhPgpK9WxeX/ehdPn6yHLzE9E uD0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=02d0w8PmklTy+xy8dNE5jEsKmZD5PVzo6uj8ETuD9Nw=; b=fydVsQfVXbrilU/kXgC3M4X4iMQWn663N9Ff7zmk9q+JdMq7uh64GuVZ79rpct2Hby etK2fbYJpLnyzHnMiI2tiweS3/5wqg+2KFO/zSZcgo3f36XM/vP1LTT63V/WeK2OVjwx XkYmjC5h5z0UYqmmOrIBtDBk7AcXytUjao0jFXesrBvHi3AX1pDiqUoKevS1scaC6SIy P/R0BDUfmp4Qq0TKZoMZyvVbHEoBSgYmWjXvLorQmNv82dviT3QoG/vk87WzWQKTvcRG d1nQ4wKNbQRwjzANxW/Po4E6z7XePElV/LtRb+cmLACGheasKlRHXTa3wq2WgLaJmuXQ w1Iw== X-Gm-Message-State: AOAM530ur81RL7oYmKTiy6oo/rAWJJHW8vTHFCKmz2BhWCCEy9tiM4G0 NQTITn7y3AWgJMiysAqyXtE= X-Google-Smtp-Source: ABdhPJw2gOjynHQhfdqwHhOMPRayY6XDf5k93guIbpcmixLfmjXG92xiyf+CiYQHMxBtckrb3vJikw== X-Received: by 2002:a05:6402:34c9:b0:419:53d2:83d0 with SMTP id w9-20020a05640234c900b0041953d283d0mr11090803edc.308.1649288875713; Wed, 06 Apr 2022 16:47:55 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id b20-20020a1709063f9400b006e12836e07fsm7062902ejj.154.2022.04.06.16.47.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Apr 2022 16:47:55 -0700 (PDT) Date: Wed, 6 Apr 2022 23:47:54 +0000 From: Wei Yang To: Vlastimil Babka Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/page_alloc: add same penalty is enough to get round-robin order Message-ID: <20220406234754.4vpi5sjztcsusqiq@master> Reply-To: Wei Yang References: <20220123013537.20491-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: fenhfa4gdncbr3maqtkpra8fwxae3p1m Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=q5IxDBxP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1F995140004 X-HE-Tag: 1649288876-921193 X-Bogosity: Ham, tests=bogofilter, spamicity=0.048731, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 05, 2022 at 07:11:12PM +0200, Vlastimil Babka wrote: >On 1/23/22 02:35, Wei Yang wrote: >> To make node order in round-robin in the same distance group, we add a >> penalty to the first node we got in each round. >> >> To get a round-robin order in the same distance group, we don't need to >> decrease the penalty since: >> >> * find_next_best_node() always iterates node in the same order >> * distance matters more then penalty in find_next_best_node() >> * in nodes with the same distance, the first one would be picked up >> >> So it is fine to increase same penalty when we get the first node in the >> same distance group. > >With that logic I'm not even sure if we need nr_online_nodes as penalty or >it could be just 1. Would you know? Yes, it has the same effect. [ 0.031849] Fallback order for Node 0: 0 1 2 3 4 5 6 7 [ 0.031854] Fallback order for Node 1: 1 2 3 0 5 6 7 4 [ 0.031857] Fallback order for Node 2: 2 3 0 1 6 7 4 5 [ 0.031860] Fallback order for Node 3: 3 0 1 2 7 4 5 6 [ 0.031864] Fallback order for Node 4: 4 5 6 7 0 1 2 3 [ 0.031867] Fallback order for Node 5: 5 6 7 4 1 2 3 0 [ 0.031870] Fallback order for Node 6: 6 7 4 5 2 3 0 1 [ 0.031873] Fallback order for Node 7: 7 4 5 6 3 0 1 2 Do you prefer to set it to 1? -- Wei Yang Help you, Help me