From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4EEEC433EF for ; Tue, 5 Apr 2022 18:14:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B2B96B0072; Tue, 5 Apr 2022 14:14:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 039C76B0073; Tue, 5 Apr 2022 14:14:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF64F6B0074; Tue, 5 Apr 2022 14:14:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id CAA826B0072 for ; Tue, 5 Apr 2022 14:14:00 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 76F9BACF7F for ; Tue, 5 Apr 2022 18:13:50 +0000 (UTC) X-FDA: 79323623820.31.03A295A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf18.hostedemail.com (Postfix) with ESMTP id C4EB81C0022 for ; Tue, 5 Apr 2022 18:13:49 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 35811210DD; Tue, 5 Apr 2022 18:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649182428; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EfLZS1Fjnkm0H+g213hibaWDOALEX+x0bMu4UJYXHy8=; b=gtFsupNU2XJjbDI26P/V+DBfJqIla6WaLeyX1MdUUJBoKpY8XCW6Ox/hJ6k5vrrETkfsaf /BRlKNgcc6S+z8xFNLb9NFxp0w6L8J6cU0K3k0d64L+c1tZ1ZXqd/6ZyoH8FOf80KPE0Az ONFj2wafYWrDy5N8a86cyb+fobKy2qw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649182428; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EfLZS1Fjnkm0H+g213hibaWDOALEX+x0bMu4UJYXHy8=; b=/T8jyprkGKvGaS53PoKSliU9C96JGKuZTkM2HxRfQ6VhtEthDMD9257BP9SJhEKhdRx61i VvWkTphPVQhHNpBg== Received: from ds.suse.cz (ds.suse.cz [10.100.12.205]) by relay2.suse.de (Postfix) with ESMTP id 2859EA3B83; Tue, 5 Apr 2022 18:13:48 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id B2213DA80E; Tue, 5 Apr 2022 20:09:46 +0200 (CEST) Date: Tue, 5 Apr 2022 20:09:46 +0200 From: David Sterba To: Matthew Wilcox Cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [GIT PULL] Folio fixes for 5.18 Message-ID: <20220405180946.GA15609@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Matthew Wilcox , Linus Torvalds , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20220405120848.GV15609@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gtFsupNU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/T8jyprk"; spf=pass (imf18.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=dsterba@suse.cz; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C4EB81C0022 X-Stat-Signature: hs91bmx3m591zo3xhyy8swwe9z3gckxr X-HE-Tag: 1649182429-244590 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 05, 2022 at 03:22:09PM +0100, Matthew Wilcox wrote: > On Tue, Apr 05, 2022 at 02:08:48PM +0200, David Sterba wrote: > > Matthew, can you please always CC linux-btrfs@vger.kernel.org for any > > patches that touch code under fs/btrfs? I've only noticed your folio > > updates in this pull request. Some of the changes are plain API switch, > > that's fine but I want to know about that, some changes seem to slightly > > modify logic that I'd really like to review and there are several missed > > opportunities to fix coding style. Thanks. > > I'm sorry, that's an unreasonable request. There's ~50 filesystems > that use address_space_operations and cc'ing individual filesystems > on VFS-wide changes isn't feaasible. How many filesystems have you touched in the recent changes? I've counted about 7 subsystems in commit 704528d895dd ("fs: Remove ->readpages address space operation"), the rest are VFS/MM changes or individual filesystems in separate patches. Examples of btrfs-only changes, there are more like that in the pull as you probably know: 8e1dec8eb8b0 ("btrfs: Use folio_invalidate()"). 895586eb6898 ("btrfs: Convert from invalidatepage to invalidate_folio") ... You know you can slap a CC: linux-btrfs@vger.kernel.org to the patch tag and forget about it, is that unreasonable? No. If you're updating the same filesystems repeatedly you can copy the CC list for all of them.