From: David Sterba <dsterba@suse.cz>
To: Matthew Wilcox <willy@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [GIT PULL] Folio fixes for 5.18
Date: Tue, 5 Apr 2022 20:09:46 +0200 [thread overview]
Message-ID: <20220405180946.GA15609@suse.cz> (raw)
In-Reply-To: <YkxQkZ24Zz9KCxK1@casper.infradead.org>
On Tue, Apr 05, 2022 at 03:22:09PM +0100, Matthew Wilcox wrote:
> On Tue, Apr 05, 2022 at 02:08:48PM +0200, David Sterba wrote:
> > Matthew, can you please always CC linux-btrfs@vger.kernel.org for any
> > patches that touch code under fs/btrfs? I've only noticed your folio
> > updates in this pull request. Some of the changes are plain API switch,
> > that's fine but I want to know about that, some changes seem to slightly
> > modify logic that I'd really like to review and there are several missed
> > opportunities to fix coding style. Thanks.
>
> I'm sorry, that's an unreasonable request. There's ~50 filesystems
> that use address_space_operations and cc'ing individual filesystems
> on VFS-wide changes isn't feaasible.
How many filesystems have you touched in the recent changes? I've
counted about 7 subsystems in commit 704528d895dd ("fs: Remove
->readpages address space operation"), the rest are VFS/MM changes or
individual filesystems in separate patches.
Examples of btrfs-only changes, there are more like that in the pull as
you probably know:
8e1dec8eb8b0 ("btrfs: Use folio_invalidate()").
895586eb6898 ("btrfs: Convert from invalidatepage to invalidate_folio")
...
You know you can slap a CC: linux-btrfs@vger.kernel.org to the patch
tag and forget about it, is that unreasonable? No. If you're updating
the same filesystems repeatedly you can copy the CC list for all of
them.
next prev parent reply other threads:[~2022-04-05 18:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 18:54 Matthew Wilcox
2022-04-01 21:45 ` pr-tracker-bot
2022-04-05 12:08 ` David Sterba
2022-04-05 14:22 ` Matthew Wilcox
2022-04-05 18:09 ` David Sterba [this message]
2022-04-06 5:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405180946.GA15609@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox