From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9731BC433F5 for ; Tue, 5 Apr 2022 02:22:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BD686B0071; Mon, 4 Apr 2022 22:22:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06CA56B0073; Mon, 4 Apr 2022 22:22:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4FB26B0074; Mon, 4 Apr 2022 22:22:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id D5D996B0071 for ; Mon, 4 Apr 2022 22:22:31 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9DE7CA799B for ; Tue, 5 Apr 2022 02:22:21 +0000 (UTC) X-FDA: 79321226082.29.EDA4DFC Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf04.hostedemail.com (Postfix) with ESMTP id 3884540043 for ; Tue, 5 Apr 2022 02:22:21 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id q26so5618329edc.7 for ; Mon, 04 Apr 2022 19:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PGMcc6BBrVtiS+i2Ug0VtK3wbbeBQEHvMN1RCK8rtJM=; b=T7b/kFnop+W+o3vMn+4faNMaH/6FVivfWcDvLooM6SXo3IuYPc5Pc/iLnyOFOYM4Lx +PEnWnwS+79f6ahrGXwHJKWetACHMgs7G8t1cyqZ/8gcnVcaAmosyjvJMWlkARoO3RmJ AZzav9BHLYzjA2Y//zznKm9QPwReL4zr+QJcHW1TNKytJQfT/NVLXQ2Tcmumf69mJ0vk MssrfEYgxZ2RJN81lAy3kL3NgqjHh9yzfbCWWLeIznHl8O3kh/X4EH2kRL6VK4TcYF9r CUsz2CB0x9Zg/1pD4IlLrggiu8K3gzEViK9SKYb1Z86W1Gqv7qXkzGy1TvdQIrf8gxkB ULcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=PGMcc6BBrVtiS+i2Ug0VtK3wbbeBQEHvMN1RCK8rtJM=; b=SqZQn+xpEBYA+TZ5VddGd/Ps5rafiQ0RsplKjPKmngNhdjB2i0zf7gRCJZKffUrOJY v7e97a2I6VBcck7TOYhTtD/MGijpXbpsOZXdG7r3iONhid3seWqnyLaKeNDhobRY+pO0 BKdF5IG6o4E5RbYvMnS/dFMgwSVu6xjHjPTQWMxvYtN8aaHXw5MWBrR2yJm7PeH1OfQS S7s3mVj6Rx/rZuz2jeRLBP2yrflS/hTCrvZ3StnB+shm8IBpZKy/ow3dxkHM+zhb82gt hXpLa5j4SE+wJSzxGmweSXiufTM9r3NTfeNrcFnyoTxPDZdcDVK36FxHAflczkfmKhsf zxhQ== X-Gm-Message-State: AOAM533YRaUNfILhslvtUzTAu+mQcT/kK5kv+1ZEn8ARh5GS+RTdvcMm g2+j/Nv2XxFFhnB9PhtEWgA= X-Google-Smtp-Source: ABdhPJyo/xdpPRsyGVYrEqRBQBwfDNp5B9V9lJiT+LnoQtMPKnQy/GcJWhyFgpqLAXDHzuyD/XR6/Q== X-Received: by 2002:a05:6402:22d8:b0:41c:c3cd:478e with SMTP id dm24-20020a05640222d800b0041cc3cd478emr1228107edb.34.1649125339797; Mon, 04 Apr 2022 19:22:19 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id c1-20020a50cf01000000b0041cb7e02a5csm4085867edk.87.2022.04.04.19.22.19 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Apr 2022 19:22:19 -0700 (PDT) Date: Tue, 5 Apr 2022 02:22:18 +0000 From: Wei Yang To: Michal Hocko Cc: Wei Yang , akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Roman Gushchin , Johannes Weiner Subject: Re: [PATCH] mm/memcg: non-hierarchical mode is deprecated Message-ID: <20220405022218.53idmvm2ha2tzmy2@master> Reply-To: Wei Yang References: <20220403020833.26164-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: 7y3gio7hk7oc45y889imqwogsbi39iiz Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="T7b/kFno"; spf=pass (imf04.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3884540043 X-HE-Tag: 1649125341-858066 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 04, 2022 at 11:27:53AM +0200, Michal Hocko wrote: >On Sun 03-04-22 02:08:33, Wei Yang wrote: >> After commit bef8620cd8e0 ("mm: memcg: deprecate the non-hierarchical >> mode"), we won't have a NULL parent except root_mem_cgroup. And this >> case is handled when (memcg == root). >> >> Signed-off-by: Wei Yang >> CC: Roman Gushchin >> CC: Johannes Weiner > >Acked-by: Michal Hocko >Thanks! > Thanks for the ack. When reading the code, I found one redundant check in shrink_node_memcgs(). shrink_node_memcgs mem_cgroup_below_min mem_cgroup_supports_protection mem_cgroup_below_low mem_cgroup_supports_protection I am not sure it worthwhile to take it out. shrink_node_memcgs mem_cgroup_supports_protection mem_cgroup_below_min mem_cgroup_below_low Look forward your opinion. -- Wei Yang Help you, Help me