linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Miaohe Lin <linmiaohe@huawei.com>, Yang Shi <shy828301@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] mm/hwpoison: fix race between hugetlb free/demotion and memory_failure_hugetlb()
Date: Tue, 5 Apr 2022 01:45:45 +0000	[thread overview]
Message-ID: <20220405014544.GA2583652@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <20220404115333.8cf80b9d3a7a55993ed60c57@linux-foundation.org>

On Mon, Apr 04, 2022 at 11:53:33AM -0700, Andrew Morton wrote:
> On Mon,  4 Apr 2022 18:21:31 +0900 Naoya Horiguchi <naoya.horiguchi@linux.dev> wrote:
> 
> > There is a race condition between memory_failure_hugetlb() and hugetlb
> > free/demotion, which causes setting PageHWPoison flag on the wrong page.
> > The one simple result is that wrong processes can be killed, but another
> > (more serious) one is that the actual error is left unhandled, so no one
> > prevents later access to it, and that might lead to more serious results
> > like consuming corrupted data.
> 
> Should this fix be backported into stable kernels?

This is a bug fix, so eligible to send to stable. But I thought that this
patch is larger than 100 lines (and hard to separeter to finer patches),
which seems to violate the rule stated in
Documentation/process/stable-kernel-rules.rst.

But actually this rule might not be strictly applied (some patches in
v5.16.y do have more than 100 lines diff...). So if we can ignore this rule
exceptionally, that's OK and I'll add CC to stable again.

The target commit of Fixed: tag is 761ad8d7c7b5 ("mm: hwpoison: introduce
memory_failure_hugetlb()") which was introduced in 4.13, so most of active
stable trees are affected.

Thanks,
Naoya Horiguchi

  reply	other threads:[~2022-04-05  1:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04  9:21 Naoya Horiguchi
2022-04-04 18:53 ` Andrew Morton
2022-04-05  1:45   ` HORIGUCHI NAOYA(堀口 直也) [this message]
2022-04-05  1:51     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220405014544.GA2583652@hori.linux.bs1.fc.nec.co.jp \
    --to=naoya.horiguchi@nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=naoya.horiguchi@linux.dev \
    --cc=shy828301@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox