From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6199BC433EF for ; Mon, 4 Apr 2022 18:53:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B24D96B0071; Mon, 4 Apr 2022 14:53:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAE0C6B0073; Mon, 4 Apr 2022 14:53:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 924F86B0074; Mon, 4 Apr 2022 14:53:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 7C8C36B0071 for ; Mon, 4 Apr 2022 14:53:48 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 30005183BFA96 for ; Mon, 4 Apr 2022 18:53:38 +0000 (UTC) X-FDA: 79320095316.30.E31AA29 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf19.hostedemail.com (Postfix) with ESMTP id 68C6C1A0005 for ; Mon, 4 Apr 2022 18:53:37 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7F19CB81916; Mon, 4 Apr 2022 18:53:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F245FC340F3; Mon, 4 Apr 2022 18:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649098414; bh=bYc4+MnhRyUZvvG3xV2Z/0MMfIXFk8Y9boux0z/HsrQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZIuIXzk8J8KGwxOyL9hJ1cNBUn/IZ+LRc/Rs24gYR0RFSoypqfqgAAEmPu449Je5/ WOzKsmRcBu76tozGhdbBzA4TiwWDT+XzuXNjNWxA8E2d2flj88tdbaEU+EcB0lElrJ xOOhH3eUgb2DxsqofuPMvzPKtFJn4ERUnNS+Wmdo= Date: Mon, 4 Apr 2022 11:53:33 -0700 From: Andrew Morton To: Naoya Horiguchi Cc: linux-mm@kvack.org, Mike Kravetz , Miaohe Lin , Yang Shi , Naoya Horiguchi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6] mm/hwpoison: fix race between hugetlb free/demotion and memory_failure_hugetlb() Message-Id: <20220404115333.8cf80b9d3a7a55993ed60c57@linux-foundation.org> In-Reply-To: <20220404092131.751733-1-naoya.horiguchi@linux.dev> References: <20220404092131.751733-1-naoya.horiguchi@linux.dev> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZIuIXzk8; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: eeqn5djqdtfm5uzzznhm7y3gzgs6zqbc X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 68C6C1A0005 X-HE-Tag: 1649098417-358739 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 4 Apr 2022 18:21:31 +0900 Naoya Horiguchi wrote: > There is a race condition between memory_failure_hugetlb() and hugetlb > free/demotion, which causes setting PageHWPoison flag on the wrong page. > The one simple result is that wrong processes can be killed, but another > (more serious) one is that the actual error is left unhandled, so no one > prevents later access to it, and that might lead to more serious results > like consuming corrupted data. Should this fix be backported into stable kernels?