linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <willy@infradead.org>, <dhowells@redhat.com>,
	<william.kucharski@oracle.com>, <vbabka@suse.cz>,
	<kirill.shutemov@linux.intel.com>, <hannes@cmpxchg.org>,
	<agruenba@redhat.com>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>, <linmiaohe@huawei.com>
Subject: [PATCH] filemap: remove obsolete comment in lock_page
Date: Sat, 2 Apr 2022 14:22:18 +0800	[thread overview]
Message-ID: <20220402062218.30709-1-linmiaohe@huawei.com> (raw)

lock_page needs the caller to have a reference on the page->mapping inode
due to sync_page. Also lock_page_nosync is introduced which does not do a
sync_page via commit db37648cd6ce ("[PATCH] mm: non syncing lock_page()").
But commit 7eaceaccab5f ("block: remove per-queue plugging") kills off the
old plugging along with aops->sync_page() and lock_page_nosync. So there
is no need to have a reference on the page->mapping inode when calling
lock_page anymore. Remove this obsolete and confusing comment.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 include/linux/pagemap.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index 993994cd943a..8dfe8e49c427 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -908,9 +908,6 @@ static inline void folio_lock(struct folio *folio)
 		__folio_lock(folio);
 }
 
-/*
- * lock_page may only be called if we have the page's inode pinned.
- */
 static inline void lock_page(struct page *page)
 {
 	struct folio *folio;
-- 
2.23.0



             reply	other threads:[~2022-04-02  6:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-02  6:22 Miaohe Lin [this message]
2022-04-04 15:32 ` Matthew Wilcox
2022-04-06  2:39   ` Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220402062218.30709-1-linmiaohe@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=agruenba@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vbabka@suse.cz \
    --cc=william.kucharski@oracle.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox