From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D228EC433F5 for ; Fri, 1 Apr 2022 01:07:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3E416B0071; Thu, 31 Mar 2022 21:07:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC7666B0072; Thu, 31 Mar 2022 21:07:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D670E6B0073; Thu, 31 Mar 2022 21:07:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id C39DD6B0071 for ; Thu, 31 Mar 2022 21:07:03 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7A63A97DBE for ; Fri, 1 Apr 2022 01:06:53 +0000 (UTC) X-FDA: 79306520706.20.AC15ECF Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf23.hostedemail.com (Postfix) with ESMTP id E4A39140007 for ; Fri, 1 Apr 2022 01:06:52 +0000 (UTC) Received: by mail-ej1-f41.google.com with SMTP id o10so2791568ejd.1 for ; Thu, 31 Mar 2022 18:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=c4Oi4+nEs2DuySa9fWn+II5/KnAf5RCOAxddnuEBjOo=; b=lfJTMOnXLxxBegeJG4M42CyKemTU/7xuAJV2g/QkGorJ5kHTAh/M5uKr6kG4xoBNfR L1xhi5B2ZyPy/f0mZ5YRo3ikrGrYDzZRu3RAdN18kTWK+UujBZoPAObDDm+F9YRAGl+l FOw9eob8rUJZ/k8ShN5GTEUW0dc6D+LeL5F/EO/BDprdVBrO5HTrWdE9CSvV6SdLG+X/ Gpy6uKexODNQePKE2QVgrMi3JfsQhqsK4g6innaeK6jizr/lMKYbhtOZS4+ONqPy8B3m wZWZqn/cMxIqqWyzj7B2Nyk02w5F6p87DndFTpuoA+usFGlgs94EnlTR30hzdxOktTrD hiaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=c4Oi4+nEs2DuySa9fWn+II5/KnAf5RCOAxddnuEBjOo=; b=kesvilLkmj51A3QigXb7K5YK5zK/gdg1xKL7PV3EBsRbLc4A7i2YhhjY8+1Vzagmc9 iL/NDkS5EPakfZlxeCD6lMyIWKZ8kXJHNdyHlNNefP079GIwFGMOArTlujbVEHjnV2ap cbcY5VCc4vjMeC4UXNHwu57qwo8J9bOwh2Ee7I/eboHlEzJTCx5aMH8CChbg2IlXw8Ks eXPJSVfyiyMMDl8MqDLSazUSndgWaIArm1hWlKF2PoOH7nPx6eGlPRV20qgbVjORrXgw 0pzwhgylV9jiQ8QHL1Ra5PkznfR5j1M/bya42yPR4feWn8KhPHgjYIU5nh8ypTVY4OiK RWCg== X-Gm-Message-State: AOAM53192KDlMioK3AwBpybX+IZF1ckImQq7YGZnynioPHDJ0FXBQip5 R6h1t2hFraCIAF9xn/NUK4k= X-Google-Smtp-Source: ABdhPJxWYORqg1aGyeVipbJ7gxove0y9p8dziuySXgQOXHQJbl0nqN7QD9cS5vTk0DVTJr35j8dDpw== X-Received: by 2002:a17:906:3ad3:b0:6cd:382b:86e5 with SMTP id z19-20020a1709063ad300b006cd382b86e5mr6832212ejd.145.1648775211380; Thu, 31 Mar 2022 18:06:51 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id v20-20020a056402349400b00419651e513asm468720edc.45.2022.03.31.18.06.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Mar 2022 18:06:50 -0700 (PDT) Date: Fri, 1 Apr 2022 01:06:50 +0000 From: Wei Yang To: Miaohe Lin Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memcg: remove unneeded nr_scanned Message-ID: <20220401010650.reelvkf2pbxkf4gl@master> Reply-To: Wei Yang References: <20220328114144.53389-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220328114144.53389-1-linmiaohe@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lfJTMOnX; spf=pass (imf23.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 8qu5gs7dd9tzmft47y13ye4e45bg1hfc X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E4A39140007 X-HE-Tag: 1648775212-80435 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 28, 2022 at 07:41:44PM +0800, Miaohe Lin wrote: >The local variable nr_scanned is unneeded as mem_cgroup_soft_reclaim always >does *total_scanned += nr_scanned. So we can pass total_scanned directly to >the mem_cgroup_soft_reclaim to simplify the code and save some cpu cycles >of adding nr_scanned to total_scanned. > >Signed-off-by: Miaohe Lin >--- Reviewed-by: Wei Yang Thanks -- Wei Yang Help you, Help me