From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 619B2C433F5 for ; Fri, 1 Apr 2022 02:33:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9AC56B0071; Thu, 31 Mar 2022 22:33:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C48986B0072; Thu, 31 Mar 2022 22:33:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B106C6B0073; Thu, 31 Mar 2022 22:33:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id A33606B0071 for ; Thu, 31 Mar 2022 22:33:12 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 74FF424B6E for ; Fri, 1 Apr 2022 02:33:02 +0000 (UTC) X-FDA: 79306737804.02.416F722 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf04.hostedemail.com (Postfix) with ESMTP id D9D0E40042 for ; Fri, 1 Apr 2022 02:33:01 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 158C4B82201; Fri, 1 Apr 2022 02:33:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4E2EC340ED; Fri, 1 Apr 2022 02:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1648780378; bh=n0qM4nf5Ta5C6oUtQqbjtn+9oGwp1yQktL1/ylHeBYY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YJk+lJV8JQGFKgNBkVIy4o07iMRsdKIy9ttLfY+D6ICy/YEw48tMZ7C7Z0pQV/C/0 8nqNRv+nbehyb7BwUK2QGdvMBJyOESDwL53sOQcu9U53TMd5rwiuRq8x/foOHH4DTB Q852v2UhQHMlUfeGBunJmzRccXQMm6EWEBefi6ls= Date: Thu, 31 Mar 2022 19:32:57 -0700 From: Andrew Morton To: Rolf Eike Beer Cc: Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: mm: use mmap_assert_write_locked() instead of open coding it Message-Id: <20220331193257.c6e52c65346cbc21ba5a7bf5@linux-foundation.org> In-Reply-To: <10178697.CBVEcFiDRS@mobilepool36.emlix.com> References: <5827758.TJ1SttVevJ@mobilepool36.emlix.com> <10178697.CBVEcFiDRS@mobilepool36.emlix.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YJk+lJV8; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D9D0E40042 X-Stat-Signature: brwzti4gdheqs697fqn9gzw9y3jkwxqz X-HE-Tag: 1648780381-355131 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 29 Mar 2022 08:45:37 +0200 Rolf Eike Beer wrote: > You are right, it was in tools/include/linux/kernel.h and I didn't spot the > prefix. Andrew, maybe you could just delete the sentence when you add the > Reviewed-by? Did that. I used simply "In case the lock is actually not held at this point."