From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE6CC433EF for ; Thu, 31 Mar 2022 23:11:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A97306B0071; Thu, 31 Mar 2022 19:10:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A45206B0072; Thu, 31 Mar 2022 19:10:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 933996B0073; Thu, 31 Mar 2022 19:10:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) by kanga.kvack.org (Postfix) with ESMTP id 84B9F6B0071 for ; Thu, 31 Mar 2022 19:10:52 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 410A11832EFD8 for ; Thu, 31 Mar 2022 23:10:42 +0000 (UTC) X-FDA: 79306227924.19.EE1B545 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 8E6AA1A0016 for ; Thu, 31 Mar 2022 23:10:41 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B77AD611B9; Thu, 31 Mar 2022 23:10:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A808C340F0; Thu, 31 Mar 2022 23:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1648768240; bh=NFb+yNIhAxcRdBorraIvjMJj3Pb3rD3DRavPneZciXo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lpAoQc5tibdSPze61eO+ml/nhHrCu7L/Zg0WX7RePjr1D8i8XGzYKWY3sY8MCmZYA Bc5TpEcH2UU/sLbnu0eU9AdfAXm5vNwuEkeVcuxfNkRV8j4P+pb7XPdaYqJZQMrDgj db/uCXp9mbc4kijnsqmFfPgJKeyCF1AO9s6YqVLQ= Date: Thu, 31 Mar 2022 16:10:39 -0700 From: Andrew Morton To: kernel test robot Cc: Andrey Konovalov , llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Johannes Weiner , Linux Memory Management List Subject: Re: [hnaz-mm:master 29/122] arch/arm64/kernel/stacktrace.c:289:13: error: implicit declaration of function 'task_scs' is invalid in C99 Message-Id: <20220331161039.7ea889841228fa36e8387b93@linux-foundation.org> In-Reply-To: <202203312049.zLjHyetm-lkp@intel.com> References: <202203312049.zLjHyetm-lkp@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: fo75usfihhju857q4b1r17ibucn4suii Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lpAoQc5t; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8E6AA1A0016 X-HE-Tag: 1648768241-595347 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 31 Mar 2022 20:59:49 +0800 kernel test robot wrote: > >> arch/arm64/kernel/stacktrace.c:289:13: error: implicit declaration of function 'task_scs' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > scs_base = task_scs(current); > ^ Thanks. Presumably this: --- a/arch/arm64/kernel/stacktrace.c~arm64-implement-stack_trace_save_shadow-fix +++ a/arch/arm64/kernel/stacktrace.c @@ -213,6 +213,7 @@ noinline notrace void arch_stack_walk(st walk_stackframe(task, &frame, consume_entry, cookie); } +#ifdef CONFIG_SHADOW_CALL_STACK static const struct { unsigned long ** __percpu saved; unsigned long ** __percpu base; @@ -293,3 +294,4 @@ out: preempt_enable(); return len; } +#endif /* CONFIG_SHADOW_CALL_STACK */ _