From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0BB7C433F5 for ; Thu, 31 Mar 2022 08:57:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F6B96B0073; Thu, 31 Mar 2022 04:57:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A46B6B0074; Thu, 31 Mar 2022 04:57:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 094046B0075; Thu, 31 Mar 2022 04:57:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id F144A6B0073 for ; Thu, 31 Mar 2022 04:57:57 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CE22361EB2 for ; Thu, 31 Mar 2022 08:57:57 +0000 (UTC) X-FDA: 79304078994.05.02FB8F6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf16.hostedemail.com (Postfix) with ESMTP id 4141118000C for ; Thu, 31 Mar 2022 08:57:57 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id D00D868B05; Thu, 31 Mar 2022 10:57:53 +0200 (CEST) Date: Thu, 31 Mar 2022 10:57:53 +0200 From: Christoph Hellwig To: David Hildenbrand Cc: Christoph Hellwig , Alex Sierra , jgg@nvidia.com, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org, akpm@linux-foundation.org Subject: Re: [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only Message-ID: <20220331085753.GA22487@lst.de> References: <20220330212537.12186-1-alex.sierra@amd.com> <20220330212537.12186-2-alex.sierra@amd.com> <20220331085341.GA22102@lst.de> <709b459a-3c71-49b1-7ac1-3144ae0fa89a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <709b459a-3c71-49b1-7ac1-3144ae0fa89a@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: bfbch7eeibuanhogc3ca8ogcwkmjoaus Authentication-Results: imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 4141118000C X-HE-Tag: 1648717077-587151 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 31, 2022 at 10:55:13AM +0200, David Hildenbrand wrote: > > Why can't this deal with ZONE_DEVICE pages? It certainly has > > nothing do with a LRU I think. In fact being able to have > > stats that count say the number of device pages here would > > probably be useful at some point. > > > > In general I find the vm_normal_lru_page vs vm_normal_page > > API highly confusing. An explicit check for zone device pages > > in the dozen or so spots that care has a much better documentation > > value, especially if accompanied by comments where it isn't entirely > > obvious. > > What's your thought on FOLL_LRU? Also a bit confusing, but inbetween all these FOLL_ flags it doesn't really matter any more.