linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: akpm@linux-foundation.org
Cc: andreyknvl@google.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, SeongJae Park <sj@kernel.org>
Subject: [PATCH for-mm 2/3] arch/arm64/kernel/irq: Include missed header file
Date: Thu, 31 Mar 2022 08:49:38 +0000	[thread overview]
Message-ID: <20220331084939.26749-3-sj@kernel.org> (raw)
In-Reply-To: <20220331084939.26749-1-sj@kernel.org>

Commit da4561bd9c6b ("arm64, scs: save scs_sp values per-cpu when
switching stacks") of -mm is moving declaration of
irq_shadow_call_stack_ptr to scs.h of arm64 for !SHADOW_CALL_STACK, but
didn't include it in irq.c of arm64.  As a result, we show below build
error when SHADOW_CALL_STACK is unset.

    linux/arch/arm64/kernel/irq.c: In function 'init_irq_scs':
    linux/arch/arm64/kernel/irq.c:44:11: error: 'irq_shadow_call_stack_ptr' undeclared (first use in this function)
       44 |   per_cpu(irq_shadow_call_stack_ptr, cpu) =
          |           ^~~~~~~~~~~~~~~~~~~~~~~~~

This commit fixes the build error by including the header file.

[1] https://lore.kernel.org/all/f75c58b17bfaa419f84286cd174e3a08f971b779.1648049113.git.andreyknvl@google.com/

Fixes: da4561bd9c6b ("arm64, scs: save scs_sp values per-cpu when switching stacks") of -mm
Signed-off-by: SeongJae Park <sj@kernel.org>
---
 arch/arm64/kernel/irq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/kernel/irq.c b/arch/arm64/kernel/irq.c
index 4199f900714a..9f7de9d5ee9b 100644
--- a/arch/arm64/kernel/irq.c
+++ b/arch/arm64/kernel/irq.c
@@ -20,6 +20,7 @@
 #include <linux/scs.h>
 #include <linux/seq_file.h>
 #include <linux/vmalloc.h>
+#include <asm/scs.h>
 #include <asm/daifflags.h>
 #include <asm/vmap_stack.h>
 
-- 
2.17.1



  parent reply	other threads:[~2022-03-31  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  8:49 [PATCH for-mm 0/3] Trivial fixes for build failures SeongJae Park
2022-03-31  8:49 ` [PATCH for-mm 1/3] arch/arm64/Kconfig: Fix a typo SeongJae Park
2022-03-31  8:49 ` SeongJae Park [this message]
2022-03-31  8:49 ` [PATCH for-mm 3/3] arch/arm64: Set HAVE_SHADOW_STACKTRACE depends on SHADOW_CALL_STACK SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220331084939.26749-3-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox