From: Wei Yang <richard.weiyang@gmail.com>
To: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com,
akpm@linux-foundation.org
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
Wei Yang <richard.weiyang@gmail.com>
Subject: [Patch v2 1/3] mm/memcg: set memcg after css verified and got reference
Date: Wed, 30 Mar 2022 23:47:17 +0000 [thread overview]
Message-ID: <20220330234719.18340-2-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20220330234719.18340-1-richard.weiyang@gmail.com>
Instead of reset memcg when css is either not verified or not got
reference, we can set it after these process.
No functional change, just simplified the code a little.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
---
mm/memcontrol.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index dc193e83794d..eed9916cdce5 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1057,15 +1057,10 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root,
* is provided by the caller, so we know it's alive
* and kicking, and don't take an extra reference.
*/
- memcg = mem_cgroup_from_css(css);
-
- if (css == &root->css)
- break;
-
- if (css_tryget(css))
+ if (css == &root->css || css_tryget(css)) {
+ memcg = mem_cgroup_from_css(css);
break;
-
- memcg = NULL;
+ }
}
if (reclaim) {
--
2.33.1
next prev parent reply other threads:[~2022-03-30 23:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 23:47 [Patch v2 0/3] mm/memcg: some cleanup for mem_cgroup_iter() Wei Yang
2022-03-30 23:47 ` Wei Yang [this message]
2022-03-31 0:20 ` [Patch v2 1/3] mm/memcg: set memcg after css verified and got reference Roman Gushchin
2022-03-30 23:47 ` [Patch v2 2/3] mm/memcg: set pos explicitly for reclaim and !reclaim Wei Yang
2022-03-31 0:21 ` Roman Gushchin
2022-03-31 15:03 ` Johannes Weiner
2022-03-30 23:47 ` [Patch v2 3/3] mm/memcg: move generation assignment and comparison together Wei Yang
2022-03-31 0:28 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330234719.18340-2-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox