From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB7BCC433EF for ; Thu, 31 Mar 2022 01:54:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 338578D0001; Wed, 30 Mar 2022 21:54:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E6146B0075; Wed, 30 Mar 2022 21:54:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 187A88D0001; Wed, 30 Mar 2022 21:54:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 04C526B0074 for ; Wed, 30 Mar 2022 21:54:58 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9C42D8249980 for ; Thu, 31 Mar 2022 01:54:57 +0000 (UTC) X-FDA: 79303013034.21.6081D00 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id E4079A0007 for ; Thu, 31 Mar 2022 01:54:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0C88BB81E23; Thu, 31 Mar 2022 01:54:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69061C340EC; Thu, 31 Mar 2022 01:54:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1648691693; bh=EP4YVz+eCDf1UV7+6jf9BNNSvDRpssv+/m6/4AB53MQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=a65NfolNsP2fTeM0VZLl4vGDuceNlt5t4+sytWAtGJpU7uo8AV5ReTs/4eDuckfCA nBm9b1hOo5WsrKNFAlVLwkApI2jUqEizWyVDZe0Y9AOTSReuwzf9E4VKLvWFnHCOu9 heaj387zzrWLyB23AfPFb8zfxGInG/wBOqG9s9AI= Date: Wed, 30 Mar 2022 18:54:52 -0700 From: Andrew Morton To: Sidhartha Kumar Cc: shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] selftest/vm: clarify error statement in gup_test Message-Id: <20220330185452.fe989c38280521356e55d944@linux-foundation.org> In-Reply-To: <20220330215257.112029-1-sidhartha.kumar@oracle.com> References: <20220330215257.112029-1-sidhartha.kumar@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=a65NfolN; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: nz8rrmaw6ecksakog8xijdwfne1xkryy X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E4079A0007 X-HE-Tag: 1648691696-495903 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 30 Mar 2022 21:52:57 +0000 Sidhartha Kumar wrote: > Print two possible reasons /sys/kernel/debug/gup_test > cannot be opened to help users of this test diagnose > failures. > > Signed-off-by: Sidhartha Kumar > Cc: stable@vger.kernel.org # 5.15+ > > ... > > --- a/tools/testing/selftests/vm/gup_test.c > +++ b/tools/testing/selftests/vm/gup_test.c > @@ -205,7 +205,9 @@ int main(int argc, char **argv) > > gup_fd = open("/sys/kernel/debug/gup_test", O_RDWR); > if (gup_fd == -1) { > - perror("open"); > + perror("failed to open /sys/kernel/debug/gup_test"); > + printf("check if CONFIG_GUP_TEST is enabled in kernel config\n"); > + printf("check if debugfs is mounted at /sys/kernel/debug\n"); > exit(1); > } Thanks. I don't think this is -stable material...