From: Andrew Morton <akpm@linux-foundation.org>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: shuah@kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] selftest/vm: clarify error statement in gup_test
Date: Wed, 30 Mar 2022 18:54:52 -0700 [thread overview]
Message-ID: <20220330185452.fe989c38280521356e55d944@linux-foundation.org> (raw)
In-Reply-To: <20220330215257.112029-1-sidhartha.kumar@oracle.com>
On Wed, 30 Mar 2022 21:52:57 +0000 Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote:
> Print two possible reasons /sys/kernel/debug/gup_test
> cannot be opened to help users of this test diagnose
> failures.
>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> Cc: stable@vger.kernel.org # 5.15+
>
> ...
>
> --- a/tools/testing/selftests/vm/gup_test.c
> +++ b/tools/testing/selftests/vm/gup_test.c
> @@ -205,7 +205,9 @@ int main(int argc, char **argv)
>
> gup_fd = open("/sys/kernel/debug/gup_test", O_RDWR);
> if (gup_fd == -1) {
> - perror("open");
> + perror("failed to open /sys/kernel/debug/gup_test");
> + printf("check if CONFIG_GUP_TEST is enabled in kernel config\n");
> + printf("check if debugfs is mounted at /sys/kernel/debug\n");
> exit(1);
> }
Thanks. I don't think this is -stable material...
next prev parent reply other threads:[~2022-03-31 1:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 21:52 Sidhartha Kumar
2022-03-31 1:54 ` Andrew Morton [this message]
2022-03-31 19:28 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330185452.fe989c38280521356e55d944@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=sidhartha.kumar@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox