From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E42CC433EF for ; Wed, 30 Mar 2022 14:35:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 042258D0002; Wed, 30 Mar 2022 10:35:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F33038D0001; Wed, 30 Mar 2022 10:35:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFAA98D0002; Wed, 30 Mar 2022 10:35:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id D05938D0001 for ; Wed, 30 Mar 2022 10:35:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 91187240CD for ; Wed, 30 Mar 2022 14:35:02 +0000 (UTC) X-FDA: 79301299644.12.9E7FAD8 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf07.hostedemail.com (Postfix) with ESMTP id F3FDB4000E for ; Wed, 30 Mar 2022 14:35:01 +0000 (UTC) Received: by mail-qv1-f42.google.com with SMTP id gh15so16953411qvb.8 for ; Wed, 30 Mar 2022 07:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=8YEpYyj+slhz80KqGdO/dNLOYREGdFcjwe/TeO35Nn0=; b=hpNWqSzx8+OpQBKf3RHE2+m1O7JjkvzX+EWb/RiGRE+hEvh4mIlq0KfcrdX2Gw51+d uMStHTaBWipJXrOBSFCn6/H3IUKXYDYcpJo1tCKDWwMBKxgfYqqV+NKfRoyBzizSapqv cSqFIds+6Dt10gSEDXb9yrDz70oaxFDzqhIODOvObNv25g1FKZ2jOVNyrhy/xIZ28Yvu iR9qWmVYZBdGqVY7jjPA8/1emWMHz2JTcaU0Sljide6CQq2k0lSVGsRMjzdWjsAZ/EEi cD9yhyWQpVmHMJbH1pQdazWodWyyzJx8lBDXOeQB4UYRr443YdyE0VsZCJYlnJGJZM9t nO+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8YEpYyj+slhz80KqGdO/dNLOYREGdFcjwe/TeO35Nn0=; b=5mha3Zeqc4fVoI4V2aCU1lPxfia5/n130vZ7pI7MF0wY8BE/0gDDvsiiz0Bd0IseQe UfKMx/i/poccMTc0StzgBtFtbOwvwApeb2WKPSq27CCbQCWMLLBmBcFo16RRwqx7Jwu1 J3Ml6dTOqN+ODKnPQADuEefvOzYV3jPM93C7r/un6lHMzG2O7T0DjijIIOOiqXvhnNjz GWx8jUOx1GnE1ZrlagIdajoCctGKpilrexoGprpHRE+mEeOdC1PR8br+cJimbzBFGXhO 47CW7ddto3qQa/Dmt/ki0KAGWubzqn4/cLElWxq1fhtv7ucoB7UJvzGjr8c3UrWFBrxm UZlQ== X-Gm-Message-State: AOAM531csFBDI0Mgpf01D02YJn6+c8dsRvHMfc5kAvAQAwJSyKKsEW/b IYyDM6CzaD7puVWaRXrOb/WRbQ== X-Google-Smtp-Source: ABdhPJzwQW9JTfeuyhyO4h6CRamftv/UtuecNNRSZTQxoT1PjH95vAAtCdHqu4vgaSQjn3F9T0Vp0g== X-Received: by 2002:a05:6214:29ee:b0:441:230a:e424 with SMTP id jv14-20020a05621429ee00b00441230ae424mr30942158qvb.2.1648650901167; Wed, 30 Mar 2022 07:35:01 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id b82-20020ae9eb55000000b0067b314c0fedsm11582372qkg.42.2022.03.30.07.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 07:34:59 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nZZPW-008rin-K4; Wed, 30 Mar 2022 11:34:58 -0300 Date: Wed, 30 Mar 2022 11:34:58 -0300 From: Jason Gunthorpe To: mpenttil@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, apopple@nvidia.com, jhubbard@nvidia.com, rcampbell@nvidia.com, vbabka@suse.cz Subject: Re: [PATCH v6] mm/hmm/test: use char dev with struct device to get device node Message-ID: <20220330143458.GM64706@ziepe.ca> References: <20220330004725.13428-1-mpenttil@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220330004725.13428-1-mpenttil@redhat.com> X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 8f3qr7i11uuqoif6hquwmeep9rz8tt9j Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=hpNWqSzx; dmarc=none; spf=pass (imf07.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.42 as permitted sender) smtp.mailfrom=jgg@ziepe.ca X-Rspamd-Queue-Id: F3FDB4000E X-HE-Tag: 1648650901-809275 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 30, 2022 at 03:47:25AM +0300, mpenttil@redhat.com wrote: > From: Mika Penttilä > > HMM selftests use an in-kernel pseudo device to emulate device private > memory. The pseudo device registers a major device range for two pseudo > device instances. User space has a script that reads /proc/devices in > order to find the assigned major number, and sends that to mknod(1), > once for each node. > > Change this to properly use cdev and struct device APIs. > > Delete the /proc/devices parsing from the user-space test script, now > that it is unnecessary. > > Also, deleted an unused field in struct dmirror_device: devmem. > > Signed-off-by: Mika Penttilä > Reviewed-by: John Hubbard > Cc: Alistair Popple > Cc: Ralph Campbell > Cc: Jason Gunthorpe > Cc: Vlastimil Babka > --- > v6: > - remove device names array > - check return value of dev_set_name() > v5: > - fix whitespace > . delete unused structure field > v4: > - fix commit log > v3: > - use cdev_device_add() instead of miscdevice > v2: > - Cleanups per review comments from John Hubbard > - Added Tested-by and Ccs > > > lib/test_hmm.c | 13 ++++++++++--- > tools/testing/selftests/vm/test_hmm.sh | 6 ------ > 2 files changed, 10 insertions(+), 9 deletions(-) Reviewed-by: Jason Gunthorpe Jason