From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E26C433F5 for ; Tue, 29 Mar 2022 23:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B9EC8D0002; Tue, 29 Mar 2022 19:59:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06AAA8D0001; Tue, 29 Mar 2022 19:59:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4C5C8D0002; Tue, 29 Mar 2022 19:59:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id D75448D0001 for ; Tue, 29 Mar 2022 19:59:03 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A19A922DB7 for ; Tue, 29 Mar 2022 23:59:03 +0000 (UTC) X-FDA: 79299092166.02.9129595 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf16.hostedemail.com (Postfix) with ESMTP id 2787B180009 for ; Tue, 29 Mar 2022 23:59:03 +0000 (UTC) Received: by mail-ej1-f47.google.com with SMTP id qa43so38214055ejc.12 for ; Tue, 29 Mar 2022 16:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mbCzJfln3VqMM3D8LXGLhg65sP9l5FOJf1oTlsWIEkc=; b=UxK9BwFdx+NtfkRowsHUY2uy2BdczHjejvZGksCdFIqMauZ6RAecwBRXXfSqYbinuH uhmw/4W4mpStLdpF2rw8s9GhpFzipietHCq7CJ1a3b2CXLD4AFjSV6z7VYnKVb1SqiVC BZo7ZffpZG5A6WKqwBfDFYeJmMA/t9IwFulJ2mLen7c+ihvtxChCFusK0u6GZaaGW/b/ Qecrq9pMx46kvD+Xw3zdV9QcCWFCOv1ZgVqyRj+qgC1Odwgw6ydIjaWggOSjgNHqbgKw 0HEMGyfpnWOhBiT/BGCntZgxlH6Tob+k1gi3FM+vzS8r/0PPOxhF4tbQoGRFscHOWjs+ DTBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=mbCzJfln3VqMM3D8LXGLhg65sP9l5FOJf1oTlsWIEkc=; b=3yJS2KLyBnRIrYeNDJh82iv8f3g2f5ukFqjjaxSiZUizlxL+zj8xZ62+TIpJaqjwOI 58AGcJQD7sGFVlsqhwaeYXeh8q7DSIdmYCQIXTaTBJOpO+rwvS6tO75bqeRv2hyz9N9I ah7olfVz7/fuJsquDvOpEKJ+iRiAoLmBBoamJHM00WKt9RaZ5/lI4jw3v5bL6Zu+trUo wEe/2F3Ik71Lcgz8nmPJ4dgqk6CIZp4QO6d6iidHql2IiWY9k+kNK7LPUZK/K+UysHTG XEygIQGTudIOWbOkF5h6ZCEtmqtZ0O3X9WFnaY6wLLGy8w1tLxNaGSxwxfxXLe05MwT1 XvXQ== X-Gm-Message-State: AOAM5301FMhQXValsepUByabbG1/lAMS+gQfymLCrTnD02w/1+PO7S3D CiOgxt3y0m01GiIdECThyUA= X-Google-Smtp-Source: ABdhPJwPUU34aRSvV0n1CShYWuJFkXrvLHDh1Zd8NAWwoi08dOwN46Km3ovGkTkOhQZf9qG+uiwztA== X-Received: by 2002:a17:907:c06:b0:6e0:9149:8047 with SMTP id ga6-20020a1709070c0600b006e091498047mr6064002ejc.765.1648598341805; Tue, 29 Mar 2022 16:59:01 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id r29-20020a50c01d000000b00415fb0dc793sm9206295edb.47.2022.03.29.16.59.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Mar 2022 16:59:01 -0700 (PDT) Date: Tue, 29 Mar 2022 23:59:00 +0000 From: Wei Yang To: Matthew Wilcox Cc: Wei Yang , "Huang, Ying" , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mgorman@techsingularity.net Subject: Re: [PATCH 2/2] mm/vmscan: make sure wakeup_kswapd with managed zone Message-ID: <20220329235900.3slpqbgjqgjv4y2e@master> Reply-To: Wei Yang References: <20220327024101.10378-1-richard.weiyang@gmail.com> <20220327024101.10378-2-richard.weiyang@gmail.com> <8735j2opd9.fsf@yhuang6-desk2.ccr.corp.intel.com> <20220329004146.2xdswvrm2qu7f47x@master> <875ynxh9lg.fsf@yhuang6-desk2.ccr.corp.intel.com> <20220329015230.hneciyfxoxtvfytl@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: coc6niqr4c4izgg444ky45kd8ef4a4kg Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=UxK9BwFd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-Rspamd-Queue-Id: 2787B180009 X-HE-Tag: 1648598343-373532 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000031, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 29, 2022 at 03:22:51AM +0100, Matthew Wilcox wrote: >On Tue, Mar 29, 2022 at 01:52:30AM +0000, Wei Yang wrote: >> @@ -1985,14 +1985,13 @@ static bool migrate_balanced_pgdat(struct pglist_data *pgdat, >> continue; >> >> /* Avoid waking kswapd by allocating pages_to_migrate pages. */ >> - if (!zone_watermark_ok(zone, 0, >> + if (zone_watermark_ok(zone, 0, >> high_wmark_pages(zone) + >> nr_migrate_pages, >> ZONE_MOVABLE, 0)) > >Someone's done the silly thing of lining up all of these with spaces, >so either all these lines also need to be shrunk by one space, or you >need to break that convention and just go to a reasonable number of >tabs. I'd do it like this: > > if (zone_watermark_ok(zone, 0, > high_wmark_pages(zone) + nr_migrate_pages, > ZONE_MOVABLE, 0)) > >but not everybody would. > >> @@ -2040,16 +2040,11 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) >> return 0; >> >> /* Avoid migrating to a node that is nearly full */ >> - if (!migrate_balanced_pgdat(pgdat, nr_pages)) { >> - int z; >> - >> + if ((zone = migrate_balanced_pgdat(pgdat, nr_pages))) { > >Linus had a rant about this style recently. He much prefers: > > zone = migrate_balanced_pgdat(pgdat, nr_pages); > if (zone) { > >(the exception is for while loops: > > while ((zone = migrate_balanced_pgdat(pgdat, nr_pages)) != NULL) > >where he wants to see the comparison against NULL instead of the awkard >double-bracket) Matthew, Thanks for your suggestion, I would change this later. -- Wei Yang Help you, Help me