From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B5D7C433F5 for ; Tue, 29 Mar 2022 13:25:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF5448D0001; Tue, 29 Mar 2022 09:25:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE8638D0007; Tue, 29 Mar 2022 09:25:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB4F88D0002; Tue, 29 Mar 2022 09:25:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 82B568D0002 for ; Tue, 29 Mar 2022 09:25:49 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 41E648249980 for ; Tue, 29 Mar 2022 13:25:49 +0000 (UTC) X-FDA: 79297496418.16.776FF43 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf08.hostedemail.com (Postfix) with ESMTP id 4600D160006 for ; Tue, 29 Mar 2022 13:25:48 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4KSVgF1Nsvz1GCxj; Tue, 29 Mar 2022 21:25:29 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 29 Mar 2022 21:25:45 +0800 From: Miaohe Lin To: CC: , , Subject: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list() Date: Tue, 29 Mar 2022 21:26:14 +0800 Message-ID: <20220329132619.18689-4-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220329132619.18689-1-linmiaohe@huawei.com> References: <20220329132619.18689-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Stat-Signature: br4ea7py4eutguh1z1p8mazxkm1ydh1i X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4600D160006 X-HE-Tag: 1648560348-881549 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Introduce helper function reclaim_page_list() to eliminate the duplicated code of doing shrink_page_list() and putback_lru_page. Also We can separa= te node reclaim from node page list operation this way. No functional change intended. Signed-off-by: Miaohe Lin --- mm/vmscan.c | 47 +++++++++++++++++++++++------------------------ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 09b452c4d256..a6e60c78d058 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2513,14 +2513,11 @@ static void shrink_active_list(unsigned long nr_t= o_scan, nr_deactivate, nr_rotated, sc->priority, file); } =20 -unsigned long reclaim_pages(struct list_head *page_list) +static inline unsigned int reclaim_page_list(struct list_head *page_list= , struct pglist_data *pgdat) { - int nid =3D NUMA_NO_NODE; - unsigned int nr_reclaimed =3D 0; - LIST_HEAD(node_page_list); struct reclaim_stat dummy_stat; + unsigned int nr_reclaimed; struct page *page; - unsigned int noreclaim_flag; struct scan_control sc =3D { .gfp_mask =3D GFP_KERNEL, .may_writepage =3D 1, @@ -2529,6 +2526,24 @@ unsigned long reclaim_pages(struct list_head *page= _list) .no_demotion =3D 1, }; =20 + nr_reclaimed =3D shrink_page_list(page_list, pgdat, &sc, &dummy_stat, f= alse); + while (!list_empty(page_list)) { + page =3D lru_to_page(page_list); + list_del(&page->lru); + putback_lru_page(page); + } + + return nr_reclaimed; +} + +unsigned long reclaim_pages(struct list_head *page_list) +{ + int nid =3D NUMA_NO_NODE; + unsigned int nr_reclaimed =3D 0; + LIST_HEAD(node_page_list); + struct page *page; + unsigned int noreclaim_flag; + noreclaim_flag =3D memalloc_noreclaim_save(); =20 while (!list_empty(page_list)) { @@ -2544,28 +2559,12 @@ unsigned long reclaim_pages(struct list_head *pag= e_list) continue; } =20 - nr_reclaimed +=3D shrink_page_list(&node_page_list, - NODE_DATA(nid), - &sc, &dummy_stat, false); - while (!list_empty(&node_page_list)) { - page =3D lru_to_page(&node_page_list); - list_del(&page->lru); - putback_lru_page(page); - } - + nr_reclaimed +=3D reclaim_page_list(&node_page_list, NODE_DATA(nid)); nid =3D NUMA_NO_NODE; } =20 - if (!list_empty(&node_page_list)) { - nr_reclaimed +=3D shrink_page_list(&node_page_list, - NODE_DATA(nid), - &sc, &dummy_stat, false); - while (!list_empty(&node_page_list)) { - page =3D lru_to_page(&node_page_list); - list_del(&page->lru); - putback_lru_page(page); - } - } + if (!list_empty(&node_page_list)) + nr_reclaimed +=3D reclaim_page_list(&node_page_list, NODE_DATA(nid)); =20 memalloc_noreclaim_restore(noreclaim_flag); =20 --=20 2.23.0