From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3A0EC433EF for ; Tue, 29 Mar 2022 00:48:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 493C28D0002; Mon, 28 Mar 2022 20:48:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4423F8D0001; Mon, 28 Mar 2022 20:48:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BD848D0002; Mon, 28 Mar 2022 20:48:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 1E15F8D0001 for ; Mon, 28 Mar 2022 20:48:56 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E575D60973 for ; Tue, 29 Mar 2022 00:48:55 +0000 (UTC) X-FDA: 79295589030.07.BFCDC53 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf17.hostedemail.com (Postfix) with ESMTP id 853574000E for ; Tue, 29 Mar 2022 00:48:55 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id pv16so32033475ejb.0 for ; Mon, 28 Mar 2022 17:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2KkRgW8qJAAnPMyCiJ8EOME7H/pHXL44sx8xKCxSZzg=; b=HFfcTsqmkj3HWmiGc/GrOX/rtjkgqqs5u0see8c078pjGfdUP+zhJZ2Yq0hFvakGCB kgUcuuVAjTWp3aTF0rxXxYRq4iJ3wnWlh2KMUyI7lo3ctLjG99DbG9KfeRNklKY3AMKH P1Q6dlRf1CiUaCbKwgiLaunWKNL29LeKmb8FIRB0WMu+Wl2xzGSIyIhWgl5ssqsYLIWw mZTuqRMfxI9BX0RTpPqpefp+nyFR0ddmDFXS/d4Eq6p0Kn0Oeaop6e6a7D6RzkOug4MF kKKFBTH+Czj8FmVsWlOPGk1GJlJ6cyzKS3TW1/A+QvYd5UzwtpJXGN8scLCQQNVGW7Gv 9KMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=2KkRgW8qJAAnPMyCiJ8EOME7H/pHXL44sx8xKCxSZzg=; b=bz/1EpAP6xMY+xjnoTs9UqrJcFsHCXGviX0S8IfFDzmJKKQu/tGBp1ziGONg7F38gu Lu83nD2fdky1DnjQvprd0i5wlObhw5jwLHUMngLdo7XJn8xt7ZKrgQ9bdRZeClHY0DS6 +H8l+b967lt1MEkv4SDg77zTbs6sLkyJG/lXPI4tZat86eUUNtsO9kkvlvq5hrvml+T/ Zaoc++ZQaPsE21Id3zbnRGk+JJI4Kmy6LIHYhPitaLm22eaGCvcBvZKo7k/oj4y7J4aj vV9tCtUQOvKXneZahWUmHKK9e7f+7qUQxqVC9PIdYjUTv65O0PZgEzcMO5zvB+nv5221 kdlA== X-Gm-Message-State: AOAM530Q0alJesOpzKWjgnNgeTgnzX3UG9mxVCSKWwuCxfmZq4wNR1q/ XHLw8kMhoq0XdhYI0NYDxNQ= X-Google-Smtp-Source: ABdhPJzhV3vijKYLVVmrkTn1ZQyQKdbkOWIE1WsmL7ZQ9kIXD14Jul8fRKpuakZs2pFfoBiqAGyzbg== X-Received: by 2002:a17:906:7746:b0:6ce:a12e:489f with SMTP id o6-20020a170906774600b006cea12e489fmr30670831ejn.551.1648514934446; Mon, 28 Mar 2022 17:48:54 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id qk30-20020a1709077f9e00b006dfae33d969sm6468308ejc.216.2022.03.28.17.48.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Mar 2022 17:48:54 -0700 (PDT) Date: Tue, 29 Mar 2022 00:48:53 +0000 From: Wei Yang To: Oscar Salvador Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ying.huang@intel.com, mgorman@techsingularity.net Subject: Re: [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones Message-ID: <20220329004853.svpeohdxyav4joi2@master> Reply-To: Wei Yang References: <20220327024101.10378-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HFfcTsqm; spf=pass (imf17.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: tdajzsfnyxpwgomk918eezois7fncd9n X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 853574000E X-HE-Tag: 1648514935-413009 X-Bogosity: Ham, tests=bogofilter, spamicity=0.019666, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 28, 2022 at 10:14:10AM +0200, Oscar Salvador wrote: >On Sun, Mar 27, 2022 at 02:41:00AM +0000, Wei Yang wrote: >> As mentioned in commit 6aa303defb74 ("mm, vmscan: only allocate and >> reclaim from zones with pages managed by the buddy allocator") , reclaim >> only affects managed_zones. >> >> Let's adjust the code and comment accordingly. >> >> Signed-off-by: Wei Yang > >LGTM, > >Reviewed-by: Oscar Salvador > >We still have some other places scattered all over where we use >populated_zone(). >I think it should be great to check whether all those usages are >right. > Thanks. This time I have checked vmscan related places, it looks all related part are fixed. For others, I didn't get a chance to catch them. > >-- >Oscar Salvador >SUSE Labs -- Wei Yang Help you, Help me