From: Wei Yang <richard.weiyang@gmail.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, ying.huang@intel.com,
mgorman@techsingularity.net
Subject: Re: [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones
Date: Tue, 29 Mar 2022 00:48:53 +0000 [thread overview]
Message-ID: <20220329004853.svpeohdxyav4joi2@master> (raw)
In-Reply-To: <YkFuUsWe2LAuQa3n@localhost.localdomain>
On Mon, Mar 28, 2022 at 10:14:10AM +0200, Oscar Salvador wrote:
>On Sun, Mar 27, 2022 at 02:41:00AM +0000, Wei Yang wrote:
>> As mentioned in commit 6aa303defb74 ("mm, vmscan: only allocate and
>> reclaim from zones with pages managed by the buddy allocator") , reclaim
>> only affects managed_zones.
>>
>> Let's adjust the code and comment accordingly.
>>
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>
>LGTM,
>
>Reviewed-by: Oscar Salvador <osalvador@suse.de>
>
>We still have some other places scattered all over where we use
>populated_zone().
>I think it should be great to check whether all those usages are
>right.
>
Thanks.
This time I have checked vmscan related places, it looks all related part are
fixed. For others, I didn't get a chance to catch them.
>
>--
>Oscar Salvador
>SUSE Labs
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2022-03-29 0:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 2:41 Wei Yang
2022-03-27 2:41 ` [PATCH 2/2] mm/vmscan: make sure wakeup_kswapd with managed zone Wei Yang
2022-03-28 1:08 ` Huang, Ying
2022-03-28 7:23 ` Miaohe Lin
2022-03-29 0:45 ` Wei Yang
2022-03-29 1:55 ` Miaohe Lin
2022-03-29 0:41 ` Wei Yang
2022-03-29 0:43 ` Huang, Ying
2022-03-29 1:52 ` Wei Yang
2022-03-29 2:05 ` Huang, Ying
2022-03-30 0:14 ` Wei Yang
2022-03-29 2:22 ` Matthew Wilcox
2022-03-29 23:59 ` Wei Yang
2022-03-28 7:11 ` [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones Miaohe Lin
2022-03-28 7:33 ` David Hildenbrand
2022-03-28 8:14 ` Oscar Salvador
2022-03-29 0:48 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329004853.svpeohdxyav4joi2@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=osalvador@suse.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox