From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE93C433F5 for ; Mon, 28 Mar 2022 11:53:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AA538D0002; Mon, 28 Mar 2022 07:53:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 058F88D0001; Mon, 28 Mar 2022 07:53:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E62EE8D0002; Mon, 28 Mar 2022 07:53:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id D76A08D0001 for ; Mon, 28 Mar 2022 07:53:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8CC5118288A39 for ; Mon, 28 Mar 2022 11:53:02 +0000 (UTC) X-FDA: 79293633804.23.695C859 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf09.hostedemail.com (Postfix) with ESMTP id 10AE514002F for ; Mon, 28 Mar 2022 11:53:01 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id i11so3283822plg.12 for ; Mon, 28 Mar 2022 04:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=Q9Y80Me/FKZXwIk/FXh37Xcqjr72zJSb5A51MgW/+68=; b=MfgAoZoDmpoKcdQ2l7qme85CsjdL/bh1edE+LxzIkbbY8G2h1Q505y1rUrVO62nTmx yibtwAaEYeJPyhAcNpMLBcVTMyyEKU9Nc/F/WXovNFws4C7NSX8AdMih0+gGvwpeN00H 4/Kxg34Uy0DZYeo6ifni3NZzJil86bDG34WE75hLa6ksBq5WzMq7+n0naJnsmjvC1jgO XVy7VEIbrKMoh/vMvvt161PxkoVdhDHR29oNNKZlbcNmOllJgnIb4CrYYLauoGeeJOxX 9AMW1hoDEoEv1LyXrfPtvsb0s26rifav2OuRpc7RjAN/uTBfTtNJ7FiDRWRKhdhbyCBa 19Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Q9Y80Me/FKZXwIk/FXh37Xcqjr72zJSb5A51MgW/+68=; b=MM6StSNxZ8T8UgmvXYxj55eDEbVvmmZp1mRZviUibxnNoINeW/We9H+XkYwALalOA2 DLJ7vjSGnSp1qPrAXAatEBslrQWnH1ZzyHPaGC7RbYauW5JkL89VqmOSCjUXpIJ108DN kJxwNrTDQRTo6uQJ/QaBaSJ3lxnl3fQWh+xq0Np+DQyVQ/DT1JZGc3KpFrLoPZ/viQan QHDEzIr7ly42156X8BPRpGm7Kwdefxu3UPGphevMLJwTEmTR1yrUlJFpsjO9WHXLTAOT RpWMKL8d77GwuMMcC/kV5tQxih5NofzgTTcR68+wEX6/smnMeZRDJ/NpQ30uPa2nPtOS dd4g== X-Gm-Message-State: AOAM530XklU6X3QGpSizi9m042u61CTB3VdojQLhsrt58wSPoyTG/Tqj AU9qDTd85IBy2/EG6edgszVHQqX7o47/dw== X-Google-Smtp-Source: ABdhPJxuR5zWnAdKnW87IOOgssws/XB1hUqtT+pD/XtpR+VleB/5GgF6oIjju4J6k7TlvID8p4oxUw== X-Received: by 2002:a17:90b:2242:b0:1c6:80e3:71b6 with SMTP id hk2-20020a17090b224200b001c680e371b6mr40375303pjb.152.1648468381131; Mon, 28 Mar 2022 04:53:01 -0700 (PDT) Received: from ubuntu.huawei.com ([119.3.119.18]) by smtp.googlemail.com with ESMTPSA id y12-20020a17090a784c00b001c6bdafc995sm17644787pjl.3.2022.03.28.04.52.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 04:53:00 -0700 (PDT) From: Xiaomeng Tong To: sj@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaomeng Tong Subject: [PATCH] damon: vaddr-test: tweak code to make the logic clearer Date: Mon, 28 Mar 2022 19:52:52 +0800 Message-Id: <20220328115252.31675-1-xiam0nd.tong@gmail.com> X-Mailer: git-send-email 2.17.1 X-Stat-Signature: p7z4kpwxge3b9uaghkwqr5b3w7ww9z9b Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MfgAoZoD; spf=pass (imf09.hostedemail.com: domain of xiam0nd.tong@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=xiam0nd.tong@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 10AE514002F X-HE-Tag: 1648468381-870098 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000649, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Move these two lines into the damon_for_each_region loop, it is always for testing the last region. And also avoid to use a list iterator 'r' outside the loop which is considered harmful[1]. [1]: https://lkml.org/lkml/2022/2/17/1032 Reviewed-by: SeongJae Park Signed-off-by: Xiaomeng Tong --- mm/damon/vaddr-test.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mm/damon/vaddr-test.h b/mm/damon/vaddr-test.h index 6a1b9272ea12..98b7a9f54b35 100644 --- a/mm/damon/vaddr-test.h +++ b/mm/damon/vaddr-test.h @@ -281,14 +281,16 @@ static void damon_test_split_evenly_succ(struct kunit *test, KUNIT_EXPECT_EQ(test, damon_nr_regions(t), nr_pieces); damon_for_each_region(r, t) { - if (i == nr_pieces - 1) + if (i == nr_pieces - 1) { + KUNIT_EXPECT_EQ(test, + r->ar.start, start + i * expected_width); + KUNIT_EXPECT_EQ(test, r->ar.end, end); break; + } KUNIT_EXPECT_EQ(test, r->ar.start, start + i++ * expected_width); KUNIT_EXPECT_EQ(test, r->ar.end, start + i * expected_width); } - KUNIT_EXPECT_EQ(test, r->ar.start, start + i * expected_width); - KUNIT_EXPECT_EQ(test, r->ar.end, end); damon_free_target(t); } -- 2.17.1