From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E559AC433F5 for ; Mon, 28 Mar 2022 11:36:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 528CF8D0002; Mon, 28 Mar 2022 07:36:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D8498D0001; Mon, 28 Mar 2022 07:36:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A0A18D0002; Mon, 28 Mar 2022 07:36:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 2B5DC8D0001 for ; Mon, 28 Mar 2022 07:36:13 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CC706182888AB for ; Mon, 28 Mar 2022 11:36:12 +0000 (UTC) X-FDA: 79293591384.30.E4B9FD3 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf30.hostedemail.com (Postfix) with ESMTP id 428D980031 for ; Mon, 28 Mar 2022 11:36:12 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id x31so5764564pfh.9 for ; Mon, 28 Mar 2022 04:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lFPVATAPP8SMQnO5b+dcn4/0YVMSr84BOSW0pJSfP8E=; b=irGRDrAjp4zX6St2s5LcSWL8OmrwDBpc7vD4dqEDZ8J+XVvrel1X5rmUE0vWO3CgEF 0ReKZpfJEF/YIZ78vx1yb87ss3EX6UCjnhHHMVRVkNioNZB6o4nnCvL6OE15DbXsTYEq e9PDXV0wk0zWeNcEmiXE54xDbNW9cSFLfU92XVJxB8VpwHWtdwwzTxuRG9OTub6daSQi i/9hvxED6silsojaj8EO9OQJBOusbPWphxRHwmRg3xY9+QhgFBQN12aMemQiefnY5nBh 5UbSpdfVb1wY3oRDnpP5gP/YT5PVDXwPM/Ns9SeVH3B1ntuGqCEBm90jQtlTQg86+ys1 X69A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lFPVATAPP8SMQnO5b+dcn4/0YVMSr84BOSW0pJSfP8E=; b=Vna7/0/3VzqOVQD6plXZ6doUrquXU33itxm4IEARLxFj9PHfOV76MFC0aQfsnWfjh0 UOtJ8td1GXEGV93+ZZIiKLLL//IxCl25Y9dEocc6J4JJ6qut7YJWI+HHsp2D4UcCvSWb BC/9G8faBHxVqZLQRAzSnbSWs3rB3xu/b6wZ12axNQ3+hhczxvfUVsi1+HzRjZggRNyH frPHG4OgbQgaUr/Y09P+OAkFDOqpKtbK/9Ahc9yodl6NYzzj+0RK1C2J920ksbA6mqUj Yhc9GMSgaQ/Vjew8EsruURIfl8mrxGhjhb6Vm2uph0qiTI6j0vYOD5AJAe9iKS+lyYQk GwgA== X-Gm-Message-State: AOAM532QcYU5sEWUHzAT3vejsiUYkxzfdSxpEApIMDoZS2VVX45PoPZW GcmOuomh75opY5upV/+XTtU= X-Google-Smtp-Source: ABdhPJw64G8PpX8+aM3/JsmFXrPMZQqjdTv75fuE2nnC185upZaEgw9PH9QeCF4aog4SrbFcNHlqfw== X-Received: by 2002:a65:6a08:0:b0:382:1af5:a4cb with SMTP id m8-20020a656a08000000b003821af5a4cbmr9823627pgu.398.1648467371142; Mon, 28 Mar 2022 04:36:11 -0700 (PDT) Received: from ubuntu.huawei.com ([119.3.119.18]) by smtp.googlemail.com with ESMTPSA id nl17-20020a17090b385100b001c70883f6ccsm23359509pjb.36.2022.03.28.04.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 04:36:10 -0700 (PDT) From: Xiaomeng Tong To: sj@kernel.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, xiam0nd.tong@gmail.com Subject: Re: [PATCH] damon: vaddr-test: fix a missing check on list iterator Date: Mon, 28 Mar 2022 19:36:04 +0800 Message-Id: <20220328113604.31373-1-xiam0nd.tong@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220328075104.31125-1-sj@kernel.org> References: <20220328075104.31125-1-sj@kernel.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 428D980031 X-Stat-Signature: dfsw69zx9odbjn1juk6eozz3o6bkbbf4 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=irGRDrAj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of xiam0nd.tong@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=xiam0nd.tong@gmail.com X-Rspam-User: X-HE-Tag: 1648467372-426825 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000138, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 28 Mar 2022 07:51:04 +0000, SJ wrote: > On Sun, 27 Mar 2022 16:03:45 +0800 Xiaomeng Tong wrote: > > > The bug is here: > > KUNIT_EXPECT_EQ(test, r->ar.start, start + i * expected_width); > > KUNIT_EXPECT_EQ(test, r->ar.end, end); > > > > For the damon_for_each_region(), just like list_for_each_entry(), > > the list iterator 'drm_crtc' will point to a bogus position > > containing HEAD if the list is empty or no element is found. > > This case must be checked before any use of the iterator, > > otherwise it will lead to a invalid memory access. > > We ensure 'damon_va_evenly_split_region()' successes before executing the loop, > so the issue cannot occur. That said, I think this patch makes code better to > read. Could you please resend this patch after fixing the commit message? Yes, you should be right. I have resend this patch with the commit message changed. Please check it, thank you. -- Xiaomeng Tong