From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4526C433EF for ; Sun, 27 Mar 2022 08:03:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CA666B0071; Sun, 27 Mar 2022 04:03:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07AD86B0073; Sun, 27 Mar 2022 04:03:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E84C06B0074; Sun, 27 Mar 2022 04:03:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id D9A456B0071 for ; Sun, 27 Mar 2022 04:03:55 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 79F18A3EE7 for ; Sun, 27 Mar 2022 08:03:55 +0000 (UTC) X-FDA: 79289427630.19.80308B2 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf23.hostedemail.com (Postfix) with ESMTP id 164F114002C for ; Sun, 27 Mar 2022 08:03:54 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id m22so11304105pja.0 for ; Sun, 27 Mar 2022 01:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=5XpCe/dhohQRtgxYw4qrnTYj4xTRi/aun8FZYK8rzRI=; b=Ln3wl1pOFR/gFdMI12yBjzwshEtLTaAljOpd3k6OOAdMrx0wY9qzv5IXx4hZr22oCv WMq5usgkP125k4vId0VqPdYNmxXgIVWWH2/9T+t3dU5+ARm2ZSepljayGjIUMSQudW4Y WGTzmKWOQoRvQTY88VCMY6R6TEx9JlsRTgowEjKz8lAZ2XCzpfy41+uY4kD3Qn++XxvJ Uw2vq+hkL0C2IiPeajev9mhqA2WhRc1qSbN2ZJEfBedsQWHlId/y3hUPyBIeODsgLsqy OaU2Ra/wnUDh84gWhon4s00tnYbj0gJWEKNyI8pfOcmWb6ZNLtZGVtYJ+pa9M8iS5PQ+ w+Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5XpCe/dhohQRtgxYw4qrnTYj4xTRi/aun8FZYK8rzRI=; b=VIBOufLQSgSEKR74Rv8MTOfDgM5ZIoMFlwdM06hKIG4phEWqvAgjafMKw4dGjIdBm/ ObZ24PoqYejhYcml3Cll/4y8LtN7b9MGpmaPmDDPPFwZnq+YslawRYYsDB3k0e13OqfH 1aKL0LgCKbmCIY5wT0yLGqMXJB4Jk9sWaqy3iMCjgv6zJMgg8YEEvFdmiWBI1Gs56HVr oa2ZZX5zjoXx8Hz+9u/vP9Lq9wEEEpKhqIYi4HZ+5yN1UgGHNI9WnNoACsjZfMiI5Gwh O6cJL6aDW5zn1zERj9TRfWAe8Oaj+k1ixA2u3vj/Z4cqASDydIaURwo4MC+iS7JZ1Ngt n7wg== X-Gm-Message-State: AOAM5323wBougfKPlWsDl/bW4tNBg/45Y9KT4bWLYCTTHhRcehe4hUiD ChOo4YGp38tThCHoUjth1w8= X-Google-Smtp-Source: ABdhPJwau6MqIHbu+LZ/UCfLHdpIQifopUQhgTPr01bqpIiL25L4v0r2Bjv7OX5yEq8LLa/I1w/3Yw== X-Received: by 2002:a17:90b:38cf:b0:1bf:42ee:6fa with SMTP id nn15-20020a17090b38cf00b001bf42ee06famr34435669pjb.9.1648368234032; Sun, 27 Mar 2022 01:03:54 -0700 (PDT) Received: from localhost ([115.220.243.108]) by smtp.gmail.com with ESMTPSA id k137-20020a633d8f000000b0039800918b00sm5989617pga.77.2022.03.27.01.03.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Mar 2022 01:03:53 -0700 (PDT) From: Xiaomeng Tong To: sj@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaomeng Tong , stable@vger.kernel.org Subject: [PATCH] damon: vaddr-test: fix a missing check on list iterator Date: Sun, 27 Mar 2022 16:03:45 +0800 Message-Id: <20220327080345.12295-1-xiam0nd.tong@gmail.com> X-Mailer: git-send-email 2.17.1 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 9w6erfreh3pmdw4ncwei6shwahw7c4qj Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ln3wl1pO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of xiam0nd.tong@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=xiam0nd.tong@gmail.com X-Rspamd-Queue-Id: 164F114002C X-HE-Tag: 1648368234-119600 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000361, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The bug is here: KUNIT_EXPECT_EQ(test, r->ar.start, start + i * expected_width); KUNIT_EXPECT_EQ(test, r->ar.end, end); For the damon_for_each_region(), just like list_for_each_entry(), the list iterator 'drm_crtc' will point to a bogus position containing HEAD if the list is empty or no element is found. This case must be checked before any use of the iterator, otherwise it will lead to a invalid memory access. To fix this bug, just mov two KUNIT_EXPECT_EQ() into the loop when found. Cc: stable@vger.kernel.org Fixes: 044cd9750fe01 ("mm/damon/vaddr-test: split a test function having >1024 bytes frame size") Signed-off-by: Xiaomeng Tong --- mm/damon/vaddr-test.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mm/damon/vaddr-test.h b/mm/damon/vaddr-test.h index 6a1b9272ea12..98b7a9f54b35 100644 --- a/mm/damon/vaddr-test.h +++ b/mm/damon/vaddr-test.h @@ -281,14 +281,16 @@ static void damon_test_split_evenly_succ(struct kunit *test, KUNIT_EXPECT_EQ(test, damon_nr_regions(t), nr_pieces); damon_for_each_region(r, t) { - if (i == nr_pieces - 1) + if (i == nr_pieces - 1) { + KUNIT_EXPECT_EQ(test, + r->ar.start, start + i * expected_width); + KUNIT_EXPECT_EQ(test, r->ar.end, end); break; + } KUNIT_EXPECT_EQ(test, r->ar.start, start + i++ * expected_width); KUNIT_EXPECT_EQ(test, r->ar.end, start + i * expected_width); } - KUNIT_EXPECT_EQ(test, r->ar.start, start + i * expected_width); - KUNIT_EXPECT_EQ(test, r->ar.end, end); damon_free_target(t); } -- 2.17.1