From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E54C433F5 for ; Sat, 26 Mar 2022 09:43:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50A986B0071; Sat, 26 Mar 2022 05:43:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4929C6B0073; Sat, 26 Mar 2022 05:43:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35A446B0074; Sat, 26 Mar 2022 05:43:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 23A626B0071 for ; Sat, 26 Mar 2022 05:43:31 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D0944212F9 for ; Sat, 26 Mar 2022 09:43:30 +0000 (UTC) X-FDA: 79286049780.09.757D30A Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf10.hostedemail.com (Postfix) with ESMTP id 552A3C0041 for ; Sat, 26 Mar 2022 09:43:30 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id bg10so19615308ejb.4 for ; Sat, 26 Mar 2022 02:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Yfxgj/Ew8GtsKZPCVL1uR3/Y8py+M2d0hw2Q0ogbCkI=; b=gBouKIs8Cm2K91cJDxQvJqFumF11BVgxktUUcRlEDjkG3oM2XZ7TlqtxXZ2C8VFc/y kqWbx9oGwyr5gGQeJ7D/uWMwIru03efmlgaYKysu9FC0iWokBYPo50gWhMJ7iImBAruS GWkzT3va1fxi+LbTB6l+UKWEzEOc4b/WZScwTenQFCa2maAp6R1tMcM1ybWUzQEequwH v1odE+x4MZJFnHfseevplpTk0n3HdQx64de2jCihjZZ9XSrYB+5XdMgkDDc0l5zZzT2y Bic5c6weSYRh5SIhCZfZGBD5XpuDnXiv3lrSxxDPD8QrbcOr54uHURhT+7UcQL1h1COX 0i/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Yfxgj/Ew8GtsKZPCVL1uR3/Y8py+M2d0hw2Q0ogbCkI=; b=3KZwBkOpj3yj306WSfTA7ZDyILSm2N97/sOfAy0ZCU00ksrAzHSAvnUJ6RIlkDuEMs QsmjWBp4sCGyyAG/2z3Lz+7oxsI3boxBfkfExP6yrz5k6b3NPfkIVE8KOwZq+bSFsTDK 3luAPnpkIVrcK/XsrhURAn1g7HJcJm4i+7GpabQ6gWcWjNnBwPLW3zXeUxZhdVllaKpc LUH3LKf0adTxDtAWGUZTUbXwvvCvbLJKBTSVdpwYIWGgXeRecE5XlTEPGPw8j7xtdniJ M8GrUUu5zWWfMZmiMupYroehNW6LO8MBtqrDFdnApa/2CvG+iVqXFzN4Wi2YA1GtAI1r 71QA== X-Gm-Message-State: AOAM530GCY7pO9RNQQ6sz3aAuQ5dDUXAUTMiWPO7mTGDDr43FOva52Or DZWACDMGXmoiLLy4z3ASq0k= X-Google-Smtp-Source: ABdhPJwhYZcJ/HIuTsMeyvFWiwSv8qlUjBWvjL7XMyKXmWQ27W5gDtxRSRtaE7WfQtgi7WNA6Bxn8g== X-Received: by 2002:a17:907:8a1c:b0:6df:ecd6:b6ea with SMTP id sc28-20020a1709078a1c00b006dfecd6b6eamr16335029ejc.530.1648287808769; Sat, 26 Mar 2022 02:43:28 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id u4-20020aa7db84000000b004136c2c357csm3935992edt.70.2022.03.26.02.43.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 26 Mar 2022 02:43:28 -0700 (PDT) Date: Sat, 26 Mar 2022 09:43:27 +0000 From: Wei Yang To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: compaction: use helper isolation_suitable Message-ID: <20220326094327.hofczncyzqyrxdxw@master> Reply-To: Wei Yang References: <20220322110750.60311-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220322110750.60311-1-linmiaohe@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: zs8j3piyqf1d6qsu638u58pdqjnzoywj Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gBouKIs8; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 552A3C0041 X-HE-Tag: 1648287810-467260 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 22, 2022 at 07:07:50PM +0800, Miaohe Lin wrote: >Use helper isolation_suitable to check whether page is suitable to isolate >to simplify the code. Minor readability improvement. > >Signed-off-by: Miaohe Lin Reviewed-by: Wei Yang >--- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/mm/compaction.c b/mm/compaction.c >index c3e37aa9ff9e..86f34053c39d 100644 >--- a/mm/compaction.c >+++ b/mm/compaction.c >@@ -899,7 +899,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > * not falsely conclude that the block should be skipped. > */ > if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages)) { >- if (!cc->ignore_skip_hint && get_pageblock_skip(page)) { >+ if (!isolation_suitable(cc, page)) { > low_pfn = end_pfn; > page = NULL; > goto isolate_abort; >-- >2.23.0 -- Wei Yang Help you, Help me