From: Wei Yang <richard.weiyang@gmail.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: compaction: use helper isolation_suitable
Date: Sat, 26 Mar 2022 09:43:27 +0000 [thread overview]
Message-ID: <20220326094327.hofczncyzqyrxdxw@master> (raw)
In-Reply-To: <20220322110750.60311-1-linmiaohe@huawei.com>
On Tue, Mar 22, 2022 at 07:07:50PM +0800, Miaohe Lin wrote:
>Use helper isolation_suitable to check whether page is suitable to isolate
>to simplify the code. Minor readability improvement.
>
>Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
>---
> mm/compaction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/compaction.c b/mm/compaction.c
>index c3e37aa9ff9e..86f34053c39d 100644
>--- a/mm/compaction.c
>+++ b/mm/compaction.c
>@@ -899,7 +899,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
> * not falsely conclude that the block should be skipped.
> */
> if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages)) {
>- if (!cc->ignore_skip_hint && get_pageblock_skip(page)) {
>+ if (!isolation_suitable(cc, page)) {
> low_pfn = end_pfn;
> page = NULL;
> goto isolate_abort;
>--
>2.23.0
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2022-03-26 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 11:07 Miaohe Lin
2022-03-26 9:43 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220326094327.hofczncyzqyrxdxw@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox