From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E0D9C433F5 for ; Fri, 25 Mar 2022 18:17:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93F8C6B0071; Fri, 25 Mar 2022 14:17:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C75A6B0073; Fri, 25 Mar 2022 14:17:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 741CF6B0074; Fri, 25 Mar 2022 14:17:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 5E8676B0071 for ; Fri, 25 Mar 2022 14:17:43 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1D5226108A for ; Fri, 25 Mar 2022 18:17:43 +0000 (UTC) X-FDA: 79283716806.09.7D5C881 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf23.hostedemail.com (Postfix) with ESMTP id 9C47914002E for ; Fri, 25 Mar 2022 18:17:42 +0000 (UTC) Received: by mail-qt1-f173.google.com with SMTP id d15so7209567qty.8 for ; Fri, 25 Mar 2022 11:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=a4k5sbPFB7Mgl39AqQajFxJ0WncwlBA+vY/pc2FuGuQ=; b=NaH2YRifYfDOG4sLSe0nOlUcBAytVbGgd1dX2oDX9irhwrBzW3zXOEyrge/eyRxfRS +ytcCYlHxdMLqvznjTf/DU2HIvH7li4oTgm6km69bBf5tvMweS8XAmKeDSPbBC74dvHF GMeFD+uwwaczOaa/lJn2DLIme+h1M/05vUfEiy4aTJkg9PUMnuXxOHO0DuNGTQ+1aWya pmlNSAdaBg1oV7pOQWVta4FYSKNUlsSAc8jUx8Roix8YcMUOk7bi2KZ2+WX2UNcjuO9w NPBqYKRO0R5oGK94F7/gbS710rqdeBXy0SP1Rf3CkwIk3kgNWF4i/wKEGP7I5Uj8mfwB 0VMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=a4k5sbPFB7Mgl39AqQajFxJ0WncwlBA+vY/pc2FuGuQ=; b=EOYrH60LpzsHZdjU1u0ur2pCUZwIb8iaiZFcXRPaYB1B5b+WnvEQ1lgX5kRqtgeaR6 PphikDfvIszU4JIfgiV7hlgXKp3NVjN6jxyWf2xNYWjaowy0g3rYg2WFTQce96JBSlRe 14Itmt940sz2Bp28/j9B15dvRdgy5vIrDIQWEZPL85vwvkWmZr6moLkdUNUDh2YH0HCa Gt0aSLBHS1cMD9PoXArUn20mt/CA/EeSDr3RYwvUNIuQM824hhuOlj14RaCT1cew2SsK jbIM84pt6nxX2s182HctFOgJRvyZcAQaPcV4C12+md6qEaCpcWyAt0OYQjNCApO+piKd /u2g== X-Gm-Message-State: AOAM533WJuny6R7HmwVe7OankZsFvliMLR3ZGnS07TC/Mob/eg+7oBWb ktkycR6f6K8DrLvNxRd08GrzBg== X-Google-Smtp-Source: ABdhPJzNAr7bQJxiSmbWztajQP3dB8GgZrrjaaoBs3KvGJKV1qPJ15NyR+3vAKW+TAjxFr9sWXz30w== X-Received: by 2002:ac8:58c4:0:b0:2e1:cdbb:50da with SMTP id u4-20020ac858c4000000b002e1cdbb50damr10793954qta.334.1648232261827; Fri, 25 Mar 2022 11:17:41 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id t13-20020a05622a148d00b002e22f105099sm5932262qtx.21.2022.03.25.11.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 11:17:41 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nXoVH-0065Gp-Ql; Fri, 25 Mar 2022 15:17:39 -0300 Date: Fri, 25 Mar 2022 15:17:39 -0300 From: Jason Gunthorpe To: mpenttil@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, apopple@nvidia.com, jhubbard@nvidia.com, rcampbell@nvidia.com, vbabka@suse.cz Subject: Re: [PATCH v5] mm/hmm/test: use char dev with struct device to get device node Message-ID: <20220325181739.GL64706@ziepe.ca> References: <20220322043543.18424-1-mpenttil@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220322043543.18424-1-mpenttil@redhat.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9C47914002E X-Stat-Signature: bgsubkqeypq5saighwyuxgw3fpy1pksx X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=NaH2YRif; dmarc=none; spf=pass (imf23.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.173 as permitted sender) smtp.mailfrom=jgg@ziepe.ca X-HE-Tag: 1648232262-41916 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 22, 2022 at 06:35:43AM +0200, mpenttil@redhat.com wrote: > From: Mika Penttilä > > HMM selftests use an in-kernel pseudo device to emulate device private > memory. The pseudo device registers a major device range for two pseudo > device instances. User space has a script that reads /proc/devices in > order to find the assigned major number, and sends that to mknod(1), > once for each node. > > Change this to properly use cdev and struct device APIs. > > Delete the /proc/devices parsing from the user-space test script, now > that it is unnecessary. > > Also, deleted an unused field in struct dmirror_device: devmem. > > Signed-off-by: Mika Penttilä > Reviewed-by: John Hubbard > Cc: Alistair Popple > Cc: Ralph Campbell > Cc: Jason Gunthorpe > Cc: Vlastimil Babka > v5: > - fix whitespace > . delete unused structure field > v4: > - fix commit log > v3: > - use cdev_device_add() instead of miscdevice > v2: > - Cleanups per review comments from John Hubbard > - Added Tested-by and Ccs > > lib/test_hmm.c | 18 ++++++++++++++---- > tools/testing/selftests/vm/test_hmm.sh | 6 ------ > 2 files changed, 14 insertions(+), 10 deletions(-) > > diff --git a/lib/test_hmm.c b/lib/test_hmm.c > index 767538089a62..3c7f2a92b09e 100644 > +++ b/lib/test_hmm.c > @@ -29,11 +29,17 @@ > > #include "test_hmm_uapi.h" > > -#define DMIRROR_NDEVICES 2 > #define DMIRROR_RANGE_FAULT_TIMEOUT 1000 > #define DEVMEM_CHUNK_SIZE (256 * 1024 * 1024U) > #define DEVMEM_CHUNKS_RESERVE 16 > > +static const char *dmirror_device_names[] = { > + "hmm_dmirror0", > + "hmm_dmirror1" > +}; > + > +#define DMIRROR_NDEVICES ARRAY_SIZE(dmirror_device_names) > + > static const struct dev_pagemap_ops dmirror_devmem_ops; > static const struct mmu_interval_notifier_ops dmirror_min_ops; > static dev_t dmirror_dev; > @@ -83,7 +89,7 @@ struct dmirror_chunk { > */ > struct dmirror_device { > struct cdev cdevice; > - struct hmm_devmem *devmem; > + struct device device; > > unsigned int devmem_capacity; > unsigned int devmem_count; > @@ -1225,7 +1231,11 @@ static int dmirror_device_init(struct dmirror_device *mdevice, int id) > > cdev_init(&mdevice->cdevice, &dmirror_fops); > mdevice->cdevice.owner = THIS_MODULE; > - ret = cdev_add(&mdevice->cdevice, dev, 1); > + device_initialize(&mdevice->device); > + dev_set_name(&mdevice->device, "%s", dmirror_device_names[id]); Just dev_set_name(&mdevice->device, "hmm_dmirror%u", id); No need for an array Also check for error Jason