From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D949FC433F5 for ; Fri, 25 Mar 2022 21:47:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51E216B0071; Fri, 25 Mar 2022 17:47:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CF0F6B0073; Fri, 25 Mar 2022 17:47:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 395286B0074; Fri, 25 Mar 2022 17:47:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id 25F586B0071 for ; Fri, 25 Mar 2022 17:47:59 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CEA8E38866 for ; Fri, 25 Mar 2022 21:47:58 +0000 (UTC) X-FDA: 79284246636.31.361D328 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 8BD31100032 for ; Fri, 25 Mar 2022 21:47:58 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D21261036; Fri, 25 Mar 2022 21:47:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97DDEC2BBE4; Fri, 25 Mar 2022 21:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1648244876; bh=h69lJXxPvdDbpf3yxkrVDt5yfQsu4aPDbdi8wU3rEIU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lOelYMROko3tudh2p6g2zXIfc3GhY2JxOsoAHFD8KYilnjCUi5JZ5NuUVN6j6VbIJ 3BlqYOxuKldnpTzj0zjZd7uzoloHcI9DmdiMmXU/u8CaCP7W3O38Jl88v7bEonpFjY N+XJo9SLXcdlTQnpi4s2Irp/kkdbr7PTJ6+014BE= Date: Fri, 25 Mar 2022 14:47:55 -0700 From: Andrew Morton To: xkernel.wang@foxmail.com Cc: glider@google.com, andreyknvl@gmail.com, elver@google.com, dvyukov@google.com, ryabinin.a.a@gmail.com, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/test_meminit: optimize do_kmem_cache_rcu_persistent() test Message-Id: <20220325144755.c0a92c6fd934b4cb98c41c16@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: giwtrf8h49czng5sd541gebi6qieh1yp Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lOelYMRO; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8BD31100032 X-HE-Tag: 1648244878-72717 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 23 Mar 2022 11:48:24 +0800 xkernel.wang@foxmail.com wrote: > From: Xiaoke Wang > > To make the test more robust, there are the following changes: > 1. add a check for the return value of kmem_cache_alloc(). > 2. properly release the object `buf` on several error paths. > 3. release the objects of `used_objects` if we never hit `saved_ptr`. > 4. destroy the created cache by default. > > ... > > --- a/lib/test_meminit.c > +++ b/lib/test_meminit.c > @@ -300,13 +300,18 @@ static int __init do_kmem_cache_rcu_persistent(int size, int *total_failures) > c = kmem_cache_create("test_cache", size, size, SLAB_TYPESAFE_BY_RCU, > NULL); > buf = kmem_cache_alloc(c, GFP_KERNEL); > + if (!buf) > + goto out; OK, Normally we don't bother checking allocation success in __init code, but this test can run via modprobe, so I guess checking is the right thing to do.