From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B62B2C433F5 for ; Thu, 24 Mar 2022 15:59:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2017C6B0071; Thu, 24 Mar 2022 11:59:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18A566B0073; Thu, 24 Mar 2022 11:59:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0512D6B0074; Thu, 24 Mar 2022 11:58:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id E660A6B0071 for ; Thu, 24 Mar 2022 11:58:59 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D13C5622AB for ; Thu, 24 Mar 2022 15:58:59 +0000 (UTC) X-FDA: 79279738398.03.1403390 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id EC17C1A0033 for ; Thu, 24 Mar 2022 15:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7SFQ8U1ZC8TVvOCO/SfAVL36IPZGMASLAhZqDZ7WTSg=; b=RaKoITrcL2edYxtzVkUOqwc7TM sOgKQzPEsjkgwIw1WT2Cc1gzGdOl89orO1vOSAEMmQ5alm3Prdxo/AMkcXRdzs8kmz/5hhn38ANZK QPzF+yyznPllb+geWP30sLSn/rhkswsgLzBMWzdd/U0eeW0MTxPkmIbFyo/KJoT3yxgz3yGbHJLvf 1PrIaoS+dGLWGW8d/QWoKafIB3n3KiiHi4cj2Q1ZICz0hMvq1SOmvrcNLkI6jYgzjjmlgiCaLEzze s9i7IlqalvQ6pcjh7A86XIcKPl2uyLwB8KlaaKpv22Elfc0mOPxXOepKQ7GRlyxEkog+flgkkpj0f ayW4NBkA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXPrR-00DYvB-DP; Thu, 24 Mar 2022 15:58:53 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 0495C986205; Thu, 24 Mar 2022 16:58:53 +0100 (CET) Date: Thu, 24 Mar 2022 16:58:52 +0100 From: Peter Zijlstra To: Steve Capper Cc: linux-mm@kvack.org, David Hildenbrand , Anshuman Khandual , Catalin Marinas , Will Deacon , nd@arm.com Subject: Re: [PATCH] tlb: hugetlb: Add arm64 contiguous hint awareness Message-ID: <20220324155852.GI8939@worktop.programming.kicks-ass.net> References: <20220323165218.35499-1-steve.capper@arm.com> <20220324143331.GF8939@worktop.programming.kicks-ass.net> <2dbb5cf0-ce41-da93-9a3d-5666601f71c5@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2dbb5cf0-ce41-da93-9a3d-5666601f71c5@arm.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EC17C1A0033 X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RaKoITrc; dmarc=none; spf=none (imf19.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org X-Stat-Signature: eyjg98zo614fotaqmy1ofwsua5xu7nd6 X-HE-Tag: 1648137538-312 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 24, 2022 at 02:35:44PM +0000, Steve Capper wrote: > > It occurs to me that perhaps this can be written like: > > > > unsigned long _sz = huge_page_size(h); > > if (_sz >= P4D_SIZE) > > tlb_flush_p4d_range(tlb, address, _sz); > > else if (_sz >= PUD_SIZE) > > tlb_flush_pud_range(tlb, address, _sz); > > else if (_sz >= PMD_SIZE) > > tlb_flush_pmd_range(tlb, address, _sz); > > else > > tlb_flush_pte_range(tlb, address, _sz); > > __tlb_remove_tlb_entry(tlb, ptep, address); > > > > And then it can still be generic.. > > Thanks Peter, > My concern with that would be the CONT_PMD_SIZE case would result in a call > to tlb_flush_pte_range rather than tlb_flush_pmd_range causing some of the > level parameters to be different. arch/arm64/include/asm/pgtable-hwdef.h:#define CONT_PMD_SIZE (CONT_PMDS * PMD_SIZE) Seems to imply CONT_PMD_SIZE >= PMD_SIZE, and would thus tickle: > > else if (_sz >= PMD_SIZE) > > tlb_flush_pmd_range(tlb, address, _sz); Or am I confused?