From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBE5C433EF for ; Thu, 24 Mar 2022 14:33:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FA6D6B0071; Thu, 24 Mar 2022 10:33:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AA236B0073; Thu, 24 Mar 2022 10:33:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 370F76B0074; Thu, 24 Mar 2022 10:33:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 25FE66B0071 for ; Thu, 24 Mar 2022 10:33:39 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DE33221F8F for ; Thu, 24 Mar 2022 14:33:38 +0000 (UTC) X-FDA: 79279523316.03.BAB0C15 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id CBCA41C0044 for ; Thu, 24 Mar 2022 14:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9Tu6zQJlmM7wla5Eom+EHYLHHjgHp/Al7tGjOWXhW7s=; b=d9HXMDWQmxtsUBu6B1d+Y1INTD wFD1LyWl7+OWNnFN6B9JOfnKP9AMjZ9Wupi7YazYM1BmdyaiPot5q0yv8OPMH7w7lFSgPvuzoZw2Z 66cUJ+qB79s6sV6JAmYWIbjMknxHKgpN6LDXSsEU6ZsdsecBgoepQnfbPVJMfC0q5Qw1bgLC2aP4G jqzZJd9J5F9dc4+doXDDGo4ZrvauQAJV3rnSjnxBI0fJHoLw2uQ1c2vD8r7aN8UmbYnSKHVhFPxgO NvAaxdFvEhb1z9bFkspcaOBw5DIuLWFj9Meo8zz3ROQAVEoGO2xt3l6MQ7QS/XmY/WEPaL3JW+Odu wOSrL2zA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXOWs-00DVpJ-7L; Thu, 24 Mar 2022 14:33:34 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id A2FDC986205; Thu, 24 Mar 2022 15:33:31 +0100 (CET) Date: Thu, 24 Mar 2022 15:33:31 +0100 From: Peter Zijlstra To: Steve Capper Cc: linux-mm@kvack.org, David Hildenbrand , Anshuman Khandual , Catalin Marinas , Will Deacon Subject: Re: [PATCH] tlb: hugetlb: Add arm64 contiguous hint awareness Message-ID: <20220324143331.GF8939@worktop.programming.kicks-ass.net> References: <20220323165218.35499-1-steve.capper@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220323165218.35499-1-steve.capper@arm.com> X-Stat-Signature: 5hz4bskcggzy1jdpkx1iwwsfck6cptag Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=d9HXMDWQ; spf=none (imf20.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CBCA41C0044 X-HE-Tag: 1648132417-902123 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 23, 2022 at 04:52:18PM +0000, Steve Capper wrote: > +#define tlb_remove_huge_tlb_entry(h, tlb, ptep, address) \ > + do { \ > + unsigned long _sz = huge_page_size(h); \ > + if (_sz == CONT_PTE_SIZE) \ > + tlb_flush_pte_range(tlb, address, _sz); \ > + else if (_sz == PMD_SIZE) \ > + tlb_flush_pmd_range(tlb, address, _sz); \ > + else if (_sz == CONT_PMD_SIZE) \ > + tlb_flush_pmd_range(tlb, address, _sz); \ > + else if (_sz == PUD_SIZE) \ > + tlb_flush_pud_range(tlb, address, _sz); \ > + __tlb_remove_tlb_entry(tlb, ptep, address); \ > + } while (0) It occurs to me that perhaps this can be written like: unsigned long _sz = huge_page_size(h); if (_sz >= P4D_SIZE) tlb_flush_p4d_range(tlb, address, _sz); else if (_sz >= PUD_SIZE) tlb_flush_pud_range(tlb, address, _sz); else if (_sz >= PMD_SIZE) tlb_flush_pmd_range(tlb, address, _sz); else tlb_flush_pte_range(tlb, address, _sz); __tlb_remove_tlb_entry(tlb, ptep, address); And then it can still be generic..