From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2570C433F5 for ; Tue, 22 Mar 2022 21:46:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BACB6B0166; Tue, 22 Mar 2022 17:46:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81CF06B0167; Tue, 22 Mar 2022 17:46:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61F846B0168; Tue, 22 Mar 2022 17:46:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 484CB6B0166 for ; Tue, 22 Mar 2022 17:46:44 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1FACE21D78 for ; Tue, 22 Mar 2022 21:46:44 +0000 (UTC) X-FDA: 79273357128.11.37E377B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 9C379140034 for ; Tue, 22 Mar 2022 21:46:43 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D4F761658; Tue, 22 Mar 2022 21:46:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F6CEC340EC; Tue, 22 Mar 2022 21:46:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1647985602; bh=DZeMtvAKaJMEfII0unlLLrvet4WaXJzruMCAT5PWPkw=; h=Date:To:From:In-Reply-To:Subject:From; b=tjqcLOtVdZVoMjm+7UHwoRg9Ri4zf4P8deO2fQLao9R8VKTfapaDMX/8kM9uaztc9 BRDePb/9rL5RFEM99/sFFnD15N6BRl1L2isT8uR3zbDVlzSRyrMPN1KzQBXDdxykdA HCKTupwgDqfDAuiPSMvqQV5LHneKiMgSIu94po6o= Date: Tue, 22 Mar 2022 14:46:41 -0700 To: david@redhat.com,linmiaohe@huawei.com,akpm@linux-foundation.org,patches@lists.linux.dev,linux-mm@kvack.org,mm-commits@vger.kernel.org,torvalds@linux-foundation.org,akpm@linux-foundation.org From: Andrew Morton In-Reply-To: <20220322143803.04a5e59a07e48284f196a2f9@linux-foundation.org> Subject: [patch 161/227] mm/madvise: use vma_lookup() instead of find_vma() Message-Id: <20220322214642.7F6CEC340EC@smtp.kernel.org> X-Rspam-User: X-Stat-Signature: dqkbcrei7mw6j7xpki6ya43prptqbf3u Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tjqcLOtV; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9C379140034 X-HE-Tag: 1647985603-603920 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Miaohe Lin Subject: mm/madvise: use vma_lookup() instead of find_vma() Using vma_lookup() verifies the start address is contained in the found vma. This results in easier to read the code. Link: https://lkml.kernel.org/r/20220311082731.63513-1-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Reviewed-by: David Hildenbrand Signed-off-by: Andrew Morton --- mm/madvise.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/mm/madvise.c~mm-madvise-use-vma_lookup-instead-of-find_vma +++ a/mm/madvise.c @@ -849,8 +849,8 @@ static long madvise_populate(struct vm_a * our VMA might have been split. */ if (!vma || start >= vma->vm_end) { - vma = find_vma(mm, start); - if (!vma || start < vma->vm_start) + vma = vma_lookup(mm, start); + if (!vma) return -ENOMEM; } _