From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 557A7C433F5 for ; Tue, 22 Mar 2022 14:10:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B04566B0071; Tue, 22 Mar 2022 10:10:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB3426B0072; Tue, 22 Mar 2022 10:10:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 905076B0074; Tue, 22 Mar 2022 10:10:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id 80AD96B0071 for ; Tue, 22 Mar 2022 10:10:00 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4263DA22E7 for ; Tue, 22 Mar 2022 14:10:00 +0000 (UTC) X-FDA: 79272206160.31.EBBF075 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf16.hostedemail.com (Postfix) with ESMTP id 88FB018001F for ; Tue, 22 Mar 2022 14:09:59 +0000 (UTC) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22MDI9U7026099; Tue, 22 Mar 2022 14:09:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=4WyFaoegTd+2mEc1VXcIcJIwtOTAxemCIB0WOdGwNNA=; b=HhVlGY0bmoIbFpCsPyIVXUeaKMwTHPMZOExH3eC+FrR0AYDZYkwfVynHMjrI2ezALtaU pZAl9t/nKPEx2QnPqWoSjsW+e2mxYylxGhr3NeS1wZ6RxdNRp0IsYfIovQKa3nkWdxI1 LPi53nrTFt6APL5metWRmyydyeVVlaP0U1kWfTM84ydZsB6gGw78YgUJ+Lch0HOaXcCu c+eTWZo8seVmwbP3R1E2TR86ZUgTrSc0AdJMt5f4YnvNlxQpatRK11sOm7MESNWMJ1bx f28q7fh9dEnpl5F5iLnAUj3Y/qabyxV4UID7UMFS3XPki3ZjsDZzO3DB1qk6vNK2MLZp cw== Received: from aserp3030.oracle.com ([141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3ew6ss6ghy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Mar 2022 14:09:53 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22ME7AUu128201; Tue, 22 Mar 2022 14:09:52 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam08lp2175.outbound.protection.outlook.com [104.47.73.175]) by aserp3030.oracle.com with ESMTP id 3ew578uppk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Mar 2022 14:09:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=miGB7t6WcoZd0HouFoekawZgdnoI24JzGBpl05nMl32tz+ea8VXTJbctFG1pR08YDCzWIJc0bXNuetIYqfuYmczBHXkHNwg2Wa5JMF47mvhD7qAO1uuPVUiv4SLno6FU+eKKusMrDZOdfH3Ox8cYr6Z0h/y17TOiesMnslrn5J+lVz2VfflH003E/Qolm2fAuHMAe0QnYWZPoHXg7QgBp2TyAvcrpF4aGp6hz+Y5TKM3sN0/NmpkMHeMxlhtgadhZGEedIBP1SzwsRYaUrml2EFufQOEAmLIgPs5EnU29ftqwnVqh2wWrIt38r5I60k2zZcARJvaYWpMOhdlkrfcRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4WyFaoegTd+2mEc1VXcIcJIwtOTAxemCIB0WOdGwNNA=; b=Cvcxangj8tmTNyGAuO3FmcMpsSez+4+8Wm8CdKP3oUJaPmq69RNHf8ceLJqSPXxmlA6buGgTzfxAWeUSB3p6m5Dl8SWnA882RenbT4pF/uR6u93sVDRqMjvIuccDwSpfy4g1oQd+Y4+c9Spg3idg/arXRb7fAPK8dh5+v8lk0fupsp9vE8QviZvqnI+3CCTYo9osdiNjR4i0cXuZs56ZBBlKwfKep3DQF6sKQ7icttSLb5fVBfjJUSan2OtCGOnQpIrLSls5RPkTtlBCRtpCWsGKUUaHUfs4zmQ3CQ8htvjGG+jZnbcManvxLOhqMiNKwILUtbGRudM/5Kq/fqrnCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4WyFaoegTd+2mEc1VXcIcJIwtOTAxemCIB0WOdGwNNA=; b=nq/aBW1i9qhhg0oPZF6wya1s2Yo1i0Uj0NJb8jLHd/2IG7lbpBkSy9C4sfdts7RnQtBmEq345I4Eei9UiOnszXboU/55Ors6wa+S8Xt4IiqtFsKaD1pTOLbekrzBMCmnGyTL5FulYxXmFJbUgsuJDq6UYf3WxtgzTqXtnQN0RF0= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MN2PR10MB3357.namprd10.prod.outlook.com (2603:10b6:208:12e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.16; Tue, 22 Mar 2022 14:09:49 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::d4e7:ee60:f060:e20c]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::d4e7:ee60:f060:e20c%7]) with mapi id 15.20.5081.023; Tue, 22 Mar 2022 14:09:49 +0000 Date: Tue, 22 Mar 2022 17:09:31 +0300 From: Dan Carpenter To: Srinivasa Rao Mandadapu Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Mark Brown , Venkata Prasad Potturu Subject: Re: [linux-next:master 8752/11953] sound/soc/codecs/lpass-macro-common.c:53 lpass_macro_pds_init() warn: passing zero to 'ERR_PTR' Message-ID: <20220322140931.GW336@kadam> References: <202203111754.32TAMFKD-lkp@intel.com> <20220322135413.GV336@kadam> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: JNAP275CA0042.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4e::13) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 95a0f9f6-bcbb-40bb-6fb8-08da0c0da0ac X-MS-TrafficTypeDiagnostic: MN2PR10MB3357:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fsOrLj9LvuJIf9iSEJ4lZwg6l75oGbN2U4U3VJkIacYD9uCJO6luTefb/B4R9YEBkRvn4jPc4eUUZGIjMpiELiTCIx1rCRVHAOtVwAINFFxKlXE2BADRuP0Qs/AL4wswFyCeJ3RHmuFbubHx4LellJiQOjVP2nBvUfx3tLPMxRGB0ks3ujYk35ZmZ3XdepdCRslcxit+/kK5aiOMQxcEKxdwoAEoUHEJOaMgi/4xtC3j1sLjHakAEXSMfCCbzETnDPFtEC93tK1pxJ0vwNGa5QSgjM9MqEvqjvtVUHRspDk1FxNIwgNUUnNntDZWM5UOHr3AseCHItuonCDMXi03iKIXk5p36e9esLPJPgyG4epMvcfSEmWnv426EYz10eTAbDe6muyo1O0RMR5tmuj7+8uHw/JwfI/H4Ymo0H+w7do2gZbrMTa/XrHJmgaO5dKvd6gurIp4CumnKmFScSry+K3E9a8N83yvuK/uCKpQTAe7NgIv/vuFg8PuKKGxqrg44MHvhPBmDk5jOjFp1RfL7y2xlJ+IvhWZ7OHlyhXOajI0CbMi40QG/jdRH+IOtX6TY1DaAf9D1TValLENKWNLZkznSDzgko47EA0Pit53bhBL3ZmOAkZYLPDZebs33GCct5h0A0JH45g8OVS3LoISm/bFRL+3rXK3CfeHtKCC1GfOGrGrA4S92lTAPOV61XHJNcDur3O3G5LN0hPlV9KSsQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(366004)(54906003)(86362001)(53546011)(508600001)(52116002)(316002)(6916009)(26005)(83380400001)(1076003)(186003)(33716001)(33656002)(5660300002)(8936002)(44832011)(6512007)(6506007)(4326008)(6666004)(66946007)(66556008)(8676002)(9686003)(66476007)(6486002)(38100700002)(38350700002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?932BvZw3GpjhXPYjT6/Wl4VWcU00bSv2FfcaW4o01YOO/eo5eBo6AMCxhEEY?= =?us-ascii?Q?MOMwUVdLwkkF0Eo6CMzz1a4mrll9c6oTTpFhrE1FIH6nnjGHLgvj2LV+PxCo?= =?us-ascii?Q?FvKtOtg+/53JsVdmS9b6qeLI0ZIq+nhY2ia/u2E3IdTjt7Q+hlDBEHsyRK3B?= =?us-ascii?Q?e8t+UFZLRSVcsQXJviwQraHZusRYk8Z4Om9SkTBKhmOGIcJ9MIFyCx69EFiK?= =?us-ascii?Q?qr8dPoANmVhcFpZrcZRRXnEdTksO95Ugrp/hmNAlOBRLfhycgYluS/Sqkj3+?= =?us-ascii?Q?50+zMPlY/tzEaBx1KDyO4MqLj+QKs1EGi2LTd6tpHLJZLHETOl66aXBEc9zC?= =?us-ascii?Q?BTVvm01iTbs1VdPfr/b6EOW0yd2S+HTOZoAaVIV5l9ThDxNme/OQQI+XLP24?= =?us-ascii?Q?OZtaxSu/RVuspY8JRsmW/l75x87jEEUwcCrmf2vGb20UMhdfJmvdK+y5xVgl?= =?us-ascii?Q?GtEeAXjT4IZGcBML722FTGBK3HVLA2odIzZ0qkMHQGMluyjsUFiC6rIHolU6?= =?us-ascii?Q?GtVndNPmzCEWUN/Eyvvw4MjaTE34T0JGO2dRadEtmPyJk5xcSdS8cl9GlLxa?= =?us-ascii?Q?B9Hd68UTVvKwU3hAvI3p82i68rpMMasYgBoJGbqBl5glsfAsyzyyHixT7fCF?= =?us-ascii?Q?6wAO9/DXRRtyYMiTLHpXtziE9258mJEFZBDZFmiciUJMkY6IM6UTl6YZQ2j1?= =?us-ascii?Q?vjDTCzBbacABmbNUMD30vzTREmp3pf57bvWG0BNH9iHDJjuM0sFAujy5W33c?= =?us-ascii?Q?sACeguKfNxOUChld1oOojLVIQpx0V4cIGX1emhkgaVurYD9ZvbpLAt5dUB2l?= =?us-ascii?Q?WtbH9xq9nlDGfwGzEKoUOSJD4TjJ8KhRgNJa+zgJYtV1WIL//bx/99HrQN5F?= =?us-ascii?Q?WhW0AHRNGsdjrIJTkaX0GXh2BGt+yG6+4C0OydB0Y+SzuB2rt9mNiHrooCdW?= =?us-ascii?Q?+aQtg/ngcqiZmqZWwjGYZJ0TAud73rGDaSJnPBG0UfMK/5yYQZL/Q8Y+TFm5?= =?us-ascii?Q?zWmvo5OE/ITiWTX5z6bnkt/+AxiLB39zLWzoiiJW8DwAZlQUQXTj5yVb0qRn?= =?us-ascii?Q?DtM6y3hKRcG+wpe0pG/pwoZRvtYZLbpk00SKK6k4YJJt6D2qc2gaSSwGcMkM?= =?us-ascii?Q?eFqExCm1w/giCgiRjP8yE5cqcVp0jJKmx+fmCEVYvZMUGQ21c7FODrYFnLkq?= =?us-ascii?Q?CgaTFhB/xLRQ6P2b7cJBwg9BsAmzVZsaTD/WIjM740X2UXoQVKuFIFaaItF1?= =?us-ascii?Q?4JTjZKygHHTt/k0YM3IUm5+xvpLDd5s63IDwh7WGKHPEKGgjblsrDea3vIEQ?= =?us-ascii?Q?9Gv/Rh7CjehrSX5CeO5v0x3rQUVtqo9ehRslJjQfvT2fsfDddtOVvWyi10le?= =?us-ascii?Q?0onLdSJvTQTipxOs6yIwVQ86FbBkAgBKdk0ghYxrN4yCDU3Fh2BWo6vDkD74?= =?us-ascii?Q?TDhVGtmQJAMoxAPv4un7Bm44geUCMfb75rOvXYqIedxtiiHQwrYo7A=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95a0f9f6-bcbb-40bb-6fb8-08da0c0da0ac X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 14:09:49.7984 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N9bzKw1E1mMyKCO+TdjFnVvqRjNIVhurrIbdScOJonw5ClmgXYM16BQzQgGk1rY3Y1clgdbMG8YS8M4h/QBOS4+fhly5MzKhfRsz8/ct/pE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3357 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10293 signatures=694221 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=848 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203220082 X-Proofpoint-ORIG-GUID: pyGlOLmedIj--SJBuSYsevXpdOSSOxaq X-Proofpoint-GUID: pyGlOLmedIj--SJBuSYsevXpdOSSOxaq X-Rspamd-Queue-Id: 88FB018001F X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=HhVlGY0b; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="nq/aBW1i"; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf16.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com X-Stat-Signature: cqdz5g9jttbu8hk7uf1m33dwiwoh639e X-Rspamd-Server: rspam07 X-HE-Tag: 1647958199-950232 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 22, 2022 at 07:32:16PM +0530, Srinivasa Rao Mandadapu wrote: > > On 3/22/2022 7:24 PM, Dan Carpenter wrote: > Thanks for Your Time Dan!!! > > On Tue, Mar 22, 2022 at 07:03:23PM +0530, Srinivasa Rao Mandadapu wrote: > > > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 14 struct lpass_macro *lpass_macro_pds_init(struct device *dev) > > > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 15 { > > > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 16 struct lpass_macro *l_pds; > > > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 17 int ret; > > > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 18 > > > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 19 if (!of_find_property(dev->of_node, "power-domains", NULL)) > > > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 20 return NULL; > > > > > > > > Returning NULL here will lead to a crash in tx_macro_runtime_resume() > > > > > > > > When a function returns a mix of NULL and error pointers, then NULL > > > > means the feature is deliberately disabled. It's not an error, it's a > > > > deliberate choice by the distro or sys admin. The caller has to > > > > be written to allow the feature to be disabled. > > > > > > > > An example of this might be LEDs. Maybe people don't want LEDs so code > > > > has to asume that the led->ops pointer might be NULL and check for that > > > > before dereferencing it. > > > Actually, it's optional here. For some targets, with lpass ADSP enabled, > > > power domains are not required. > > > > > > So is the reason, returning NULL Here. > > > > > Unfortunately, the caller is not written to handle NULLs so it will > > crash. > > Yes agree. will add error check with in lpass_macro_pds_exit(). > > Will that make sense? Yep. Thanks! regards, dan carpenter