From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 746DCC433F5 for ; Tue, 22 Mar 2022 13:54:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAC966B0072; Tue, 22 Mar 2022 09:54:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D34B66B0073; Tue, 22 Mar 2022 09:54:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3AB56B0074; Tue, 22 Mar 2022 09:54:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id 9EB0F6B0072 for ; Tue, 22 Mar 2022 09:54:51 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5757F18287BAB for ; Tue, 22 Mar 2022 13:54:51 +0000 (UTC) X-FDA: 79272167982.16.F5D41C5 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf16.hostedemail.com (Postfix) with ESMTP id 93F9D180018 for ; Tue, 22 Mar 2022 13:54:50 +0000 (UTC) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22MDL9D2001514; Tue, 22 Mar 2022 13:54:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=oRZe2HNQihjreqZ7lJfcAkeCPUAAmbxmz0fzhjJuabU=; b=MMC4uC8y9mH4xuOQQ/UDm6h9iOPVu5ef6MICNT2MvhUjESvz+Gi65bfkP9UoAwWa6msn YIcEdgCTL03gTfNLurq5OPiQpZg9qv36dWkRYHBioxuMH0h+2JUEHRXHFqK4OBzsGpy5 MpyJ6dbfCBvmiAY85Z5bWL9qx+E45e2CTYadKI+SnjOuUgce0my/85T5ZjKi5MVBRWIP PqHY3hLKDqlBBgPiET0ZmoP5E3A/XheCyRzKOvCitqtGJB+ppbLSSQRdcRmhlftDpMPk D1XvxqP0DQZPgGmJoK45ZUCPK3i2ba+Vj4cmW7tPa/ZoIWtTXa1bCt5EOSBGbHdx7zUs yw== Received: from aserp3030.oracle.com ([141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3ew7qt6gvw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Mar 2022 13:54:45 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22MDp1kf110362; Tue, 22 Mar 2022 13:54:44 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2174.outbound.protection.outlook.com [104.47.58.174]) by aserp3030.oracle.com with ESMTP id 3ew578un9q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Mar 2022 13:54:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jK/a18XQYRo8sBWkqhhQGs72oXlJUwB9f3GDJ1dXZrefFxD/O60mvryH4olpnpqoyBDuC1NaiEfYTUooHnV4ddI8l1vkcGuOfJ2DMSEmUsFKqZe1agAvGWzrNAZoUgkRBnANgjIBVMRmUVnay4SelzSGLLHaDlVj9US2rScUlHpw6Yucw1QFg+MwJBPahrYWFrx5oVQX+VHGFxuNXtjfmtm6ARgYNxQMQsJSGi7is0G7RQWrOaW2WztDuNBTj/0Qg2fOJqYg5QTJ+WDvJItjeWeliY8gn4WPCkml3qo1T6vpjas86StfpsSUeaqPo8dPR/af02Oog2s/Pqr5kE0p6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oRZe2HNQihjreqZ7lJfcAkeCPUAAmbxmz0fzhjJuabU=; b=fsQbLkeDFmfwshYUinR7pELUpUoM1rXNltlhIKMjLEMWZzVGmFgGJTn39LksG4FuzYxwXoo2LI0BOsiGJP03fv/lNi669ASWHI8WXJMMmNC6MSODKmAwAS3cejw+40NDcN1qJFgnV+oMRmQYz8w2KfdB3pGFI8SyleusT2ONeaKLj9OSh+AngevcPBxoRUcUT6PIrFLOowDzaxGdqyBmvzHU8wbYuFXphYQsAQOSa9ETkNxBNfP5eQbqXz7v57wUAJ3EjTziKbiC3wcR2yZ1xCSh6qFp79FkgJ9zoX8wpL6xyWxWovGLurQGRxN2xXL0yaBygA3tjFthbNeQnipN6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oRZe2HNQihjreqZ7lJfcAkeCPUAAmbxmz0fzhjJuabU=; b=Weagss4vXv0W+FfcAkLf4fQ6eoDORXaNXVcpgNcPZ9g7u+pj0br7sJCHScdJFIlsGLuAbO+rtZCqzT/sPih/LQ19LKN1Rev2A4sL/2R11xGEeAjszJ+qTF79QQM58+mIItxDzjZhAkh28SABiKTKJzAv3h+jDVFRD8Z1kzznOeQ= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by DS7PR10MB4832.namprd10.prod.outlook.com (2603:10b6:5:3a6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Tue, 22 Mar 2022 13:54:33 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::d4e7:ee60:f060:e20c]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::d4e7:ee60:f060:e20c%7]) with mapi id 15.20.5081.023; Tue, 22 Mar 2022 13:54:33 +0000 Date: Tue, 22 Mar 2022 16:54:13 +0300 From: Dan Carpenter To: Srinivasa Rao Mandadapu Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Mark Brown , Venkata Prasad Potturu Subject: Re: [linux-next:master 8752/11953] sound/soc/codecs/lpass-macro-common.c:53 lpass_macro_pds_init() warn: passing zero to 'ERR_PTR' Message-ID: <20220322135413.GV336@kadam> References: <202203111754.32TAMFKD-lkp@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: JN2P275CA0001.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:3::13) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb4bb31b-68b6-4b6d-eebe-08da0c0b7e2d X-MS-TrafficTypeDiagnostic: DS7PR10MB4832:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 92hc9Xjc2TsUOTxb/t0hyMvjB876qKtdDwetbO2zkHDSZKLk5IozvuZUlx+syPO7ssYdHAqFoKjTv6QS9e71WtzxmcKh/tLyRFY3Ooy1RfOjnjE4f2TFecLtY2NCk/9y7brYk+zhUwtrb5KhlHemmYAr7zu7vu/vLbAgOhKxDAX67Ml1DSGmkqFV/tqKvoNHzSN5NOdxGRyiBny1bq9E3Vdgdaa6Pt4huiPSyg2YCNNyg1wlyJzInR5ILCvBVM/VINlu0b3fKq+l2m19l8eb6MYO8h/egHrsxJUb3OW9n8hw7KGPakSlNTmBWFjMkFxdvAk5AoS7AWtUVW4mixzP1VtDeLH6BJ6hDDdoEWdH4jRIdrlcKHHdwLBHy3DGmBlpPZVdL1tIPxsRd866dNnHFIaHy2QKPS/crIJjFOgHqgZyQe4u1ZEz3HM8NVo7f2+uH28C1DYuImGxJq+PANq014qmSjLE/bQ0CnVXqIcnsmocux/jb3tXPqu4Y1fg5ZAie24+boxwWSjNdNGnnaf1pA9XtQcOKhCvNrONEOIdj8YEREIeWWDLpFZeRUrxjpqxHLSu9K5xgeUmtE+x/tfnjCME78AIEqnTcw672AxPIiWT2ulu5GNSw4jFS3duVMX896aA4BsAqyZng8DeZjaUrWuxKa1IZ5ZVDF7/k387n0q9rvepswxmahgQhgtHlpytspprgSlKTqM7y7IEVkhZpA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(366004)(6666004)(5660300002)(83380400001)(4326008)(1076003)(66556008)(44832011)(8676002)(66946007)(66476007)(508600001)(6486002)(6916009)(33716001)(54906003)(33656002)(38350700002)(26005)(6512007)(9686003)(2906002)(8936002)(6506007)(86362001)(38100700002)(316002)(52116002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kpNjFwAQwKnDemlBk2VTHe9YR9XgyfN44a3IbKNItM8BXVgGCP8IQHiyCh5T?= =?us-ascii?Q?9wjIxLR1ONF9lEf4yYbLdWM4eENC9Ju1cLr73hdbplTyK034nUOX8c/wjjWt?= =?us-ascii?Q?f372KJO9aYRu6spidyLHuvgoSxEdEXmcfawxhKtF2UgJZRwHfQzQItcYQoyd?= =?us-ascii?Q?382OjCSE5VyIgFlKi1AvqOiittyWrwKlc3YMryfB55k8eGf9DTMq+G4KmkhC?= =?us-ascii?Q?Ou7JUt0dpys3KtpzOYxn5yFFoh5NOf4TrDc8W2OrY+lVlQOTpDqyIxdLaYc2?= =?us-ascii?Q?tUVG9LGA/ARipAxHOIYpaAH7LrVLl3zq4KMkUtQKG5lof8ooHQKIN70X/nIE?= =?us-ascii?Q?1F6By2iLCnPdF7beMiPRSRP3KHg59sgrFM188/Ooveo/eJ+EYfW8r7khxfsS?= =?us-ascii?Q?5htq99LiHCFz0aYILnYGzJtiCNu42E+2J4wBBfuoiM11ghaeBGzeEwbds9Be?= =?us-ascii?Q?EUBtH3cbKX1s3xS202lqzyroypy5K/ISqLZbvjZ1s1eHUzh47aaNOf6m6/pj?= =?us-ascii?Q?F4UtF4EZla3XtfaStZHq8ybsPwtlnPdv0Iq9cengxDLp1ofFnQjuUK2AYV4p?= =?us-ascii?Q?iQhab7B5henukCOINoKrPGTJge/oMOJyb3LDnYRmC3nVqUGTFK6GqCVUtaMA?= =?us-ascii?Q?0ZxsCC8FSi3nfytSBVE8X7cQvAlTWlnuAlMeqwk6mFeSvUyZd+HuU12Tax2D?= =?us-ascii?Q?qgoJc8gWj2dNNOhf5xqvIuL2WCg2x3fv0N3xEHms1g3xa9DFMYp6UryRrkmd?= =?us-ascii?Q?0lE07Sp1tBZpddZu+q96ij5C9it9zMiojpNwOwcClSDLIN6bhRXzSAsIVl32?= =?us-ascii?Q?8gy4jLJQA3e3wiYNCp4ElwCNYk2LEltl9rYD43doPSIohtx6wClJ280ev3xs?= =?us-ascii?Q?Lk3yU5txLw5xrVHgPx6NBMlNedVm308Pw+v8x/3omcde+c57EjGgoTpRfJce?= =?us-ascii?Q?5dcIAZXYEut27RqhamM+hLjzq7c1JsvlRIthGvc2DWwW1cS8QMEF1y9kgLW1?= =?us-ascii?Q?PCMjwL8D83O4KDsgt+RUpaL5ckQ4ydGIV/G1M/FeviuasrcIt7+qE6FNpFWJ?= =?us-ascii?Q?wKS4MVsiH+Xycci9+xG0I8Co3OTpv3mOWiujF3SRyFadEf8tvyWo3c5E42Z4?= =?us-ascii?Q?/enjyoKQU+3IZkunRt0rr1+Sy6Ggi2/l1Q8JMtqHY5Vr/WlP8xEDl90HeRGp?= =?us-ascii?Q?jkw5/4rnYu8I9VBKGlx55HtHOohl88QSaTHJE7jilE87Ky1kyUTRam9S7WFN?= =?us-ascii?Q?VxZHZuPuk2C9s4hek2kJJ+RLSAIj86aP7SP+eE9Txh0t+aXACE1dTXfdhJSL?= =?us-ascii?Q?7qYymIyxlY6FmqnsBApe1iqIsWkocsb0KCxQm/s2LGaWb/QJHgUNU5oZg4JH?= =?us-ascii?Q?zYcsNPWmizpREHvdxaTL1ooWJQ50tBP+/ELHxQsobsveCcUk6rSaelZFJmLT?= =?us-ascii?Q?OcE9cWKayzairbh8HkGQ7FCoY/ZQ43vitbt3v7BKSZP9rtc11uUddw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb4bb31b-68b6-4b6d-eebe-08da0c0b7e2d X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 13:54:32.9334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W/6R98dJcV5Ee6/ndGKn+sVG0Xd83plIhUfumhXblP67kc9gB7GQQv2q4Br/15N1lxFp6mqOpc76v4+UFyuNQU+nP4uK0NksDx4kaBreUhc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4832 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10293 signatures=694221 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203220080 X-Proofpoint-GUID: G17R4iXLa1tOgPI7-YuYGjroxOFCSOg2 X-Proofpoint-ORIG-GUID: G17R4iXLa1tOgPI7-YuYGjroxOFCSOg2 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=MMC4uC8y; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Weagss4v; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf16.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=dan.carpenter@oracle.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 93F9D180018 X-Stat-Signature: rh7pif58dubzogfyet9ebdbx84k6ch39 X-HE-Tag: 1647957290-386695 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 22, 2022 at 07:03:23PM +0530, Srinivasa Rao Mandadapu wrote: > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 14 struct lpass_macro *lpass_macro_pds_init(struct device *dev) > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 15 { > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 16 struct lpass_macro *l_pds; > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 17 int ret; > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 18 > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 19 if (!of_find_property(dev->of_node, "power-domains", NULL)) > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 20 return NULL; > > > > Returning NULL here will lead to a crash in tx_macro_runtime_resume() > > > > When a function returns a mix of NULL and error pointers, then NULL > > means the feature is deliberately disabled. It's not an error, it's a > > deliberate choice by the distro or sys admin. The caller has to > > be written to allow the feature to be disabled. > > > > An example of this might be LEDs. Maybe people don't want LEDs so code > > has to asume that the led->ops pointer might be NULL and check for that > > before dereferencing it. > > Actually, it's optional here. For some targets, with lpass ADSP enabled, > power domains are not required. > > So is the reason, returning NULL Here. > Unfortunately, the caller is not written to handle NULLs so it will crash. sound/soc/codecs/lpass-tx-macro.c 1913 static int tx_macro_remove(struct platform_device *pdev) 1914 { 1915 struct tx_macro *tx = dev_get_drvdata(&pdev->dev); 1916 1917 clk_disable_unprepare(tx->macro); 1918 clk_disable_unprepare(tx->dcodec); 1919 clk_disable_unprepare(tx->mclk); 1920 clk_disable_unprepare(tx->npl); 1921 clk_disable_unprepare(tx->fsgen); 1922 1923 lpass_macro_pds_exit(tx->pds); ^^^^^^^ Boom. 1924 1925 return 0; 1926 } > > > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 21 > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 22 l_pds = devm_kzalloc(dev, sizeof(*l_pds), GFP_KERNEL); > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 23 if (!l_pds) > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 24 return ERR_PTR(-ENOMEM); > > > > Good. > > > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 25 > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 26 l_pds->macro_pd = dev_pm_domain_attach_by_name(dev, "macro"); > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 27 if (IS_ERR_OR_NULL(l_pds->macro_pd)) > > 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 28 return NULL; > > > > If this feature is optional then it should be: > > > > if (IS_ERR_OR_NULL(l_pds->macro_pd)) > > return ERR_CAST(l_pds->macro_pd); > > > > The admin deliberately chose to enable the feature so we can't just > > ignore errors and convert them to NULL. > > Here it's not optional, if power domains feature is available then macro and > dcodec power domains should be present. > > So will update it like below. > > if (IS_ERR_OR_NULL(l_pds->macro_pd)) { > ret = PTR_ERR(l_pds->macro_pd); > goto macro_err; > } I bet COMPILE_TEST allows this to compile without CONFIG_PM but there isn't anything we can do about that... regards, dan carpenter