From: conor dooley <mail@conchuod.ie>
To: lkp@intel.com
Cc: conor.dooley@microchip.com, kbuild-all@lists.01.org,
linux-mm@kvack.org, nicolas.ferre@microchip.com
Subject: Re: [linux-next:master 7918/13392] drivers/soc/microchip/mpfs-sys-controller.c:73:1-6: WARNING: invalid free of devm_ allocated data
Date: Thu, 17 Mar 2022 21:17:35 +0000 [thread overview]
Message-ID: <20220317211734.1340281-1-mail@conchuod.ie> (raw)
In-Reply-To: <202203180259.lgIylRZV-lkp@intel.com>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 97add482e9033a9386baa8824fbea34d0cbfe663
> commit: d0054a470c33902f5ae88835ed8a8ecc3cf8faa4 [7918/13392] soc: add microchip polarfire soc system controller
> config: ia64-randconfig-c004-20220317 (https://download.01.org/0day-ci/archive/20220318/202203180259.lgIylRZV-lkp@intel.com/config)
> compiler: ia64-linux-gcc (GCC) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> cocci warnings: (new ones prefixed by >>)
> >> drivers/soc/microchip/mpfs-sys-controller.c:73:1-6: WARNING: invalid free of devm_ allocated data
Silly mistake, should've changed this when the alloc was converted to
devm_.
@Nicolas, rest of this week is public holiday, but I'll try to
send a fix before the weekend. Should it go to you or to Arnd?
>
> vim +73 drivers/soc/microchip/mpfs-sys-controller.c
>
> 66
> 67 static void mpfs_sys_controller_delete(struct kref *kref)
> 68 {
> 69 struct mpfs_sys_controller *sys_controller = container_of(kref, struct mpfs_sys_controller,
> 70 consumers);
> 71
> 72 mbox_free_channel(sys_controller->chan);
> > 73 kfree(sys_controller);
> 74 }
> 75
>
> ---
> 0-DAY CI Kernel Test Service
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2022-03-17 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 18:48 kernel test robot
2022-03-17 21:17 ` conor dooley [this message]
2022-03-18 9:42 ` Nicolas Ferre
2022-03-18 9:43 ` Nicolas Ferre
2022-03-18 10:35 ` Conor Dooley
2022-03-18 11:02 ` Arnd Bergmann
2022-03-18 11:59 ` Conor Dooley
2022-03-21 8:12 ` Conor.Dooley
2022-03-18 12:50 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317211734.1340281-1-mail@conchuod.ie \
--to=mail@conchuod.ie \
--cc=conor.dooley@microchip.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox