From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDE38C433F5 for ; Thu, 17 Mar 2022 23:51:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79B098D0003; Thu, 17 Mar 2022 19:51:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74B5A8D0001; Thu, 17 Mar 2022 19:51:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63A2C8D0003; Thu, 17 Mar 2022 19:51:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id 546118D0001 for ; Thu, 17 Mar 2022 19:51:06 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0764AA3EE5 for ; Thu, 17 Mar 2022 23:51:06 +0000 (UTC) X-FDA: 79255526532.29.703E798 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id 6CBAE40018 for ; Thu, 17 Mar 2022 23:51:05 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7BBE5B820F7; Thu, 17 Mar 2022 23:51:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0D9DC340E9; Thu, 17 Mar 2022 23:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1647561062; bh=c5eoa7XecUk0qot+FwjPKZfT8TI4sQLGAehXwg8J1K8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oopVa0BAXrDMEKaNLsKFU0IN7quVxZGL8VjtKsp/HPcMyKTUFICek5K3+6YmMioil GQbiJmnXhz2lfDO+k+pYgTtLKpZebKFOCDtUZmEDUNkI9xnaen9trRAKRDI+u8gaaV 9UGCX78YgwQ9lGVGWmyxgUXp2wqs3kSmxviMwB9w= Date: Thu, 17 Mar 2022 16:51:00 -0700 From: Andrew Morton To: Randy Dunlap Cc: broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org, linux-um , paulmck@kernel.org, Richard Weinberger , Johannes Berg Subject: Re: mmotm 2022-03-16-17-42 uploaded (uml sub-x86_64, sched/fair, RCU) Message-Id: <20220317165100.2755c5ae6a3a08b7ecb06181@linux-foundation.org> In-Reply-To: <917e9ce0-c8cf-61b2-d1ba-ebf25bbd979d@infradead.org> References: <20220317004304.95F89C340E9@smtp.kernel.org> <0f622499-36e1-ea43-ddc3-a8b3bb08d34b@infradead.org> <20220316213011.8cac447e692283a4b5d97f3d@linux-foundation.org> <917e9ce0-c8cf-61b2-d1ba-ebf25bbd979d@infradead.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 6CBAE40018 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oopVa0BA; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Stat-Signature: 9h7jz45tkh8gtupdjap6dqwkhpradu8s X-HE-Tag: 1647561065-716860 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 16 Mar 2022 21:52:44 -0700 Randy Dunlap w= rote: > >> In file included from ./arch/x86/include/generated/asm/rwonce.h:1:0, > >> from ../include/linux/compiler.h:248, > >> from ../include/linux/kernel.h:20, > >> from ../include/linux/cpumask.h:10, > >> from ../include/linux/energy_model.h:4, > >> from ../kernel/sched/fair.c:23: > >> ../include/linux/psi.h: In function =E2=80=98cgroup_move_task=E2=80=99= : > >> ../include/linux/rcupdate.h:414:36: error: dereferencing pointer to = incomplete type =E2=80=98struct css_set=E2=80=99 > >> #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v) > >> ^~~~ > >=20 > > Works For Me. I tried `make x86_64_defconfig' and `make i386_defconf= ig' too. > >=20 > > Can you please share that .config, or debug a bit? >=20 > $ make ARCH=3Dum SUBARCH=3Dx86_64 defconfig >=20 I still can't reproduce this :( > This fixes the build error for me when CONFIG_PSI=3Dn. I have CONFIG_PSI=3Dn > --- > include/linux/psi.h | 3 +++ > 1 file changed, 3 insertions(+) >=20 > --- mmotm-2022-0316-1742.orig/include/linux/psi.h > +++ mmotm-2022-0316-1742/include/linux/psi.h > @@ -53,6 +53,9 @@ static inline int psi_cgroup_alloc(struc > static inline void psi_cgroup_free(struct cgroup *cgrp) > { > } > + > +#include > + > static inline void cgroup_move_task(struct task_struct *p, struct css_= set *to) > { > rcu_assign_pointer(p->cgroups, to); Nothing in -next touches psi.h so I am unable to determine which patch needs fixing :(