From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62FE8C433F5 for ; Thu, 17 Mar 2022 14:15:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C43EA8D0002; Thu, 17 Mar 2022 10:15:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF3658D0001; Thu, 17 Mar 2022 10:15:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A93CC8D0002; Thu, 17 Mar 2022 10:15:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 966E68D0001 for ; Thu, 17 Mar 2022 10:15:43 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6348B249BA for ; Thu, 17 Mar 2022 14:15:43 +0000 (UTC) X-FDA: 79254076566.03.57E746A Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf31.hostedemail.com (Postfix) with ESMTP id 9E8B120024 for ; Thu, 17 Mar 2022 14:15:42 +0000 (UTC) Received: by mail-qv1-f52.google.com with SMTP id kl20so4266430qvb.10 for ; Thu, 17 Mar 2022 07:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ERYHSpe1+FU1IDWhLgLoQAdxEsWkuy46KP5iCR1Nx+g=; b=FdQQ96Mh3YSy+Of2eEjk1Rnqy3rZvWFhpdup4t6PrzMoUZseo/plcyKlTZ+Mw1LdUZ fQQg8Xw4s5gs23P5Pyh81GiHafAUeT/0CHxLAeaAMztrcfP6Vc8Wzpk7O2GguaOYtsHt yLxunmA6pswpUg/WCr77cdsJOFUknVOjpBfBmYvrg6FUgHJrhVVafP6QYFWIkQbqlbw0 /dSlC49HGv4+RtzFTA/p8sl5knXRdiG/zxvo6mvfrgF5euYrlWm5whfoPA/F7wENWglD s6eiAkUFEit7htOtINT6yp7iE08qEAVugCJdbBvqJ/EAMH82OwaVhw5z3QdxPaJZCii/ yJnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ERYHSpe1+FU1IDWhLgLoQAdxEsWkuy46KP5iCR1Nx+g=; b=pAPCSRF/3IywgHkd5z3UxA1JJfejbaie7mRWRGsj7H5o0Do9AG3rtY9LeD6aJ7yUqF f9hcAYNY07IeFzXB5A8/3rF3GWH1Tf9wAX31EfUc5qa2hlMkOrElEmHO/l0Ih4kCR4Cv tkN7q5WjAmYn2g/K9jzqjfnvjkh7cqK1+104grrKORpfnztL+8yKq+CJ8OqkdRm4fO69 MmA98trlZKX9t6f3HbOL+EnXFEwpka0Yiz9akWjHBLEkMzMkkvv/aDu0HB7z1WZrBq+k NJvpojUw9eSpYilJVd3LOa3ShH14JPXRZtICT8xCYwah/8NsmZJO3UVqGU60MyzstJ6H fbtQ== X-Gm-Message-State: AOAM530tcJTxDLqKUYZQJWf+rRDSWZic5DC58iUUYO1nQyRIy6zwzzg8 NOMWaVIoR3cHBlIQM4t6E04ksw== X-Google-Smtp-Source: ABdhPJzDaxqCpSNI0Z7pJR6AfVQtHqwyxvpCBKzwLxqFvxFcKV2fKmmPyrZTM8f/tQAk9iCZ+Yq6Qg== X-Received: by 2002:ad4:5f8f:0:b0:435:9505:b243 with SMTP id jp15-20020ad45f8f000000b004359505b243mr3388907qvb.18.1647526541819; Thu, 17 Mar 2022 07:15:41 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id 22-20020ac85756000000b002e1cabad999sm3697547qtx.89.2022.03.17.07.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 07:15:40 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nUquh-001tXD-Q8; Thu, 17 Mar 2022 11:15:39 -0300 Date: Thu, 17 Mar 2022 11:15:39 -0300 From: Jason Gunthorpe To: Mika =?utf-8?B?UGVudHRpbMOk?= Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, apopple@nvidia.com, jhubbard@nvidia.com, rcampbell@nvidia.com, vbabka@suse.cz Subject: Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice instead of char dev Message-ID: <20220317141539.GD64706@ziepe.ca> References: <20220311033050.22724-1-mpenttil@redhat.com> <20220314182439.GB64706@ziepe.ca> <20220315183922.GC64706@ziepe.ca> <8e836d75-97b0-d301-4d6a-92025e91cad5@redhat.com> <0f53c5ff-1711-861d-9a12-0634d4ab9fca@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f53c5ff-1711-861d-9a12-0634d4ab9fca@redhat.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9E8B120024 X-Stat-Signature: jg5hroupwpsaeyyj9eezh8hmn6pg11pb X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=FdQQ96Mh; spf=pass (imf31.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.52 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none X-HE-Tag: 1647526542-35412 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000097, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 17, 2022 at 08:58:52AM +0200, Mika Penttilä wrote: > @@ -1225,7 +1232,11 @@ static int dmirror_device_init(struct dmirror_device > *mdevice, int id) > > cdev_init(&mdevice->cdevice, &dmirror_fops); > mdevice->cdevice.owner = THIS_MODULE; > - ret = cdev_add(&mdevice->cdevice, dev, 1); > + device_initialize(&mdevice->device); > + dev_set_name(&mdevice->device, "%s", dmirror_device_names[id]); > + mdevice->device.devt = dev; > + > + ret = cdev_device_add(&mdevice->cdevice, &mdevice->device); > if (ret) > return ret; Right, miscdev isn't that helpful in the end.. Jason