From: Andrew Morton <akpm@linux-foundation.org>
To: Charan Teja Kalla <quic_charante@quicinc.com>
Cc: Minchan Kim <minchan@kernel.org>, <surenb@google.com>,
<vbabka@suse.cz>, <rientjes@google.com>, <sfr@canb.auug.org.au>,
<edgararriaga@google.com>, <nadav.amit@gmail.com>,
<mhocko@suse.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
"# 5 . 10+" <stable@vger.kernel.org>
Subject: Re: [PATCH V2,2/2] mm: madvise: skip unmapped vma holes passed to process_madvise
Date: Wed, 16 Mar 2022 14:29:06 -0700 [thread overview]
Message-ID: <20220316142906.e41e39d2315e35ef43f4aad6@linux-foundation.org> (raw)
In-Reply-To: <5428f192-1537-fa03-8e9c-4a8322772546@quicinc.com>
On Wed, 16 Mar 2022 19:49:38 +0530 Charan Teja Kalla <quic_charante@quicinc.com> wrote:
> > IMO, it's worth to note in man page.
> >
>
> Or the current patch for just ENOMEM is sufficient here and we just have
> to update the man page?
I think the "On success, process_madvise() returns the number of bytes
advised" behaviour sounds useful. But madvise() doesn't do that.
RETURN VALUE
On success, madvise() returns zero. On error, it returns -1 and errno
is set to indicate the error.
So why is it desirable in the case of process_madvise()?
And why was process_madvise() designed this way? Or was it
always simply an error in the manpage?
next prev parent reply other threads:[~2022-03-16 21:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 15:29 [PATCH V2,0/2]mm: madvise: return correct bytes processed with process_madvise Charan Teja Kalla
2022-03-11 15:29 ` [PATCH V2,1/2] mm: madvise: return correct bytes advised " Charan Teja Kalla
2022-03-15 22:20 ` Minchan Kim
2022-03-21 15:18 ` Michal Hocko
2022-03-11 15:29 ` [PATCH V2,2/2] mm: madvise: skip unmapped vma holes passed to process_madvise Charan Teja Kalla
2022-03-15 22:58 ` Minchan Kim
2022-03-15 23:48 ` Andrew Morton
2022-03-16 1:43 ` Minchan Kim
2022-03-16 14:19 ` Charan Teja Kalla
2022-03-16 21:29 ` Andrew Morton [this message]
2022-03-17 16:28 ` Minchan Kim
2022-03-17 16:53 ` Suren Baghdasaryan
2022-03-17 20:38 ` Nadav Amit
2022-03-18 14:05 ` Charan Teja Kalla
2022-03-18 15:37 ` Minchan Kim
2022-03-17 16:24 ` Minchan Kim
2022-03-21 15:02 ` Michal Hocko
2022-03-22 5:19 ` Charan Teja Kalla
2022-03-21 15:34 ` Michal Hocko
2022-03-22 7:10 ` Charan Teja Kalla
2022-03-22 8:40 ` Michal Hocko
2022-03-11 21:42 ` [PATCH V2,0/2]mm: madvise: return correct bytes processed with process_madvise Andrew Morton
2022-03-15 14:26 ` Charan Teja Kalla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316142906.e41e39d2315e35ef43f4aad6@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=edgararriaga@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=nadav.amit@gmail.com \
--cc=quic_charante@quicinc.com \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox