* [PATCH] mm/damon: minor cleanup for damon_pa_young
@ 2022-03-16 8:15 Miaohe Lin
2022-03-16 8:53 ` sj
2022-03-16 14:11 ` Matthew Wilcox
0 siblings, 2 replies; 3+ messages in thread
From: Miaohe Lin @ 2022-03-16 8:15 UTC (permalink / raw)
To: akpm, sj; +Cc: linux-mm, linux-kernel, linmiaohe
if need_lock is true but folio_trylock fails, we should return false
instead of NULL to match the return value type exactly. No functional
change intended.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/damon/paddr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
index a01495cebdad..21474ae63bc7 100644
--- a/mm/damon/paddr.c
+++ b/mm/damon/paddr.c
@@ -152,7 +152,7 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *page_sz)
need_lock = !folio_test_anon(folio) || folio_test_ksm(folio);
if (need_lock && !folio_trylock(folio)) {
folio_put(folio);
- return NULL;
+ return false;
}
rmap_walk(folio, &rwc);
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/damon: minor cleanup for damon_pa_young
2022-03-16 8:15 [PATCH] mm/damon: minor cleanup for damon_pa_young Miaohe Lin
@ 2022-03-16 8:53 ` sj
2022-03-16 14:11 ` Matthew Wilcox
1 sibling, 0 replies; 3+ messages in thread
From: sj @ 2022-03-16 8:53 UTC (permalink / raw)
To: Miaohe Lin; +Cc: akpm, sj, linux-mm, linux-kernel
Hi Miaohe,
Thank you for this patch!
On Wed, 16 Mar 2022 16:15:28 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> if need_lock is true but folio_trylock fails, we should return false
> instead of NULL to match the return value type exactly. No functional
> change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
> ---
> mm/damon/paddr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
> index a01495cebdad..21474ae63bc7 100644
> --- a/mm/damon/paddr.c
> +++ b/mm/damon/paddr.c
> @@ -152,7 +152,7 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *page_sz)
> need_lock = !folio_test_anon(folio) || folio_test_ksm(folio);
> if (need_lock && !folio_trylock(folio)) {
> folio_put(folio);
> - return NULL;
> + return false;
> }
>
> rmap_walk(folio, &rwc);
>
> --
> 2.23.0
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/damon: minor cleanup for damon_pa_young
2022-03-16 8:15 [PATCH] mm/damon: minor cleanup for damon_pa_young Miaohe Lin
2022-03-16 8:53 ` sj
@ 2022-03-16 14:11 ` Matthew Wilcox
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2022-03-16 14:11 UTC (permalink / raw)
To: Miaohe Lin; +Cc: akpm, sj, linux-mm, linux-kernel
On Wed, Mar 16, 2022 at 04:15:28PM +0800, Miaohe Lin wrote:
> if need_lock is true but folio_trylock fails, we should return false
> instead of NULL to match the return value type exactly. No functional
> change intended.
Thanks. Given the extensive changes I've made to this function for
this merge window, I've added it to my for-next tree.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-16 14:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 8:15 [PATCH] mm/damon: minor cleanup for damon_pa_young Miaohe Lin
2022-03-16 8:53 ` sj
2022-03-16 14:11 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox