From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D659CC433F5 for ; Wed, 16 Mar 2022 08:53:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C0428D0002; Wed, 16 Mar 2022 04:53:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 270AC8D0001; Wed, 16 Mar 2022 04:53:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15F848D0002; Wed, 16 Mar 2022 04:53:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id 033F18D0001 for ; Wed, 16 Mar 2022 04:53:27 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B632AA30AC for ; Wed, 16 Mar 2022 08:53:26 +0000 (UTC) X-FDA: 79249635612.30.BBF31A6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 2929B120012 for ; Wed, 16 Mar 2022 08:53:26 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4872E6153A; Wed, 16 Mar 2022 08:53:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 394A4C340E9; Wed, 16 Mar 2022 08:53:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647420804; bh=ekLZb1lbsVmd4fFmXwiqzIWmyw2ad5ve/nwLpaF/zPQ=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=WKqSf2pUUMqXLJTkULj7fj1QQVTwBXv7eUcNotlQpZexaIEytHZ0X+SSewVT+razl UKeiir/DNztl1Kh7SK+llTzjK7sW5TK64rjqjU8kYhsNqJqdg7Qx3J7yNHs/Jrs7r/ dPUZspJqIUdow6AZX6DIEHvcw47rW+x4KrO02Ca6na6EVTVQevcMRctfrEVg/kc7sf 3+cnisHSa4xsVu3Z65QNMWotf4nQZsh24Z9J+JnNPRJ1k0wrxWYpgAWN1Qioxh977f XQiXdbx2UDHkbQMo53Id24mTIbfiUfr1c8YFr22/ng1JZsH3zN9pmy2jN9tt9OzFZr 6qMGHeGWw3UOQ== From: sj@kernel.org To: Miaohe Lin Cc: akpm@linux-foundation.org, sj@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon: minor cleanup for damon_pa_young Date: Wed, 16 Mar 2022 08:53:15 +0000 Message-Id: <20220316085315.21054-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220316081528.6034-1-linmiaohe@huawei.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2929B120012 X-Stat-Signature: bw5dwo5ukb8ocumouw98u8739zwgnci9 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WKqSf2pU; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-HE-Tag: 1647420806-66891 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000213, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Miaohe, Thank you for this patch! On Wed, 16 Mar 2022 16:15:28 +0800 Miaohe Lin wrote: > if need_lock is true but folio_trylock fails, we should return false > instead of NULL to match the return value type exactly. No functional > change intended. > > Signed-off-by: Miaohe Lin Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/paddr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index a01495cebdad..21474ae63bc7 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -152,7 +152,7 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *page_sz) > need_lock = !folio_test_anon(folio) || folio_test_ksm(folio); > if (need_lock && !folio_trylock(folio)) { > folio_put(folio); > - return NULL; > + return false; > } > > rmap_walk(folio, &rwc); > > -- > 2.23.0 > > >