From: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: Yang Shi <shy828301@gmail.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"bp@alien8.de" <bp@alien8.de>
Subject: Re: [PATCH v2 1/3] mm/memory-failure.c: fix race with changing page compound again
Date: Wed, 16 Mar 2022 08:30:46 +0000 [thread overview]
Message-ID: <20220316083046.GB3840907@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <a3a2ee10-95a5-6624-7846-54e21319c444@huawei.com>
On Wed, Mar 16, 2022 at 04:18:30PM +0800, Miaohe Lin wrote:
> On 2022/3/16 2:19, Yang Shi wrote:
> > On Tue, Mar 15, 2022 at 7:19 AM Miaohe Lin <linmiaohe@huawei.com> wrote:
...
> >>
> >>
> >> Many thanks for comment.
> >> I assume that Naoya's patch "mm/hwpoison: set PageHWPoison after taking page lock
> >> in memory_failure_hugetlb()" would set the PageHWPoison after the above check.
> >> So I think the below operation is not needed as PageHWPoison is not set yet.
> >> Does this makes sense for you?
> >
> > I'm wondering if it might be better and helpful for review to squash
> > this patch with Naoya's patch together? It seems we always missed the
> > other part when reviewing the patches.
> >
>
> Sounds like a good idea. This would make the reviewer's life easier. I'm fine if
> this patch is squashed into Naoya's patch altogether. But we might have to consult
> the opinion from Naoya.
I'm fine with the squashing, so I'll send v4.
Thanks,
Naoya Horiguchi
next prev parent reply other threads:[~2022-03-16 8:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 7:46 [PATCH v2 0/3] A few fixup patches for memory failure Miaohe Lin
2022-03-12 7:46 ` [PATCH v2 1/3] mm/memory-failure.c: fix race with changing page compound again Miaohe Lin
2022-03-13 23:41 ` HORIGUCHI NAOYA(堀口 直也)
2022-03-14 1:51 ` Miaohe Lin
2022-03-14 18:20 ` Mike Kravetz
2022-03-15 14:19 ` Miaohe Lin
2022-03-15 18:19 ` Yang Shi
2022-03-16 8:18 ` Miaohe Lin
2022-03-16 8:30 ` HORIGUCHI NAOYA(堀口 直也) [this message]
2022-03-16 8:41 ` Miaohe Lin
2022-03-12 7:46 ` [PATCH v2 2/3] mm/memory-failure.c: avoid calling invalidate_inode_page() with unexpected pages Miaohe Lin
2022-03-13 23:41 ` HORIGUCHI NAOYA(堀口 直也)
2022-03-14 1:58 ` Miaohe Lin
2022-03-14 2:50 ` HORIGUCHI NAOYA(堀口 直也)
2022-03-14 2:59 ` Miaohe Lin
2022-03-14 23:45 ` Andrew Morton
2022-03-15 13:55 ` Miaohe Lin
2022-03-12 7:46 ` [PATCH v2 3/3] mm/memory-failure.c: make non-LRU movable pages unhandlable Miaohe Lin
2022-03-13 23:43 ` HORIGUCHI NAOYA(堀口 直也)
2022-03-14 17:34 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316083046.GB3840907@hori.linux.bs1.fc.nec.co.jp \
--to=naoya.horiguchi@nec.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=linmiaohe@huawei.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=shy828301@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox