From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F1C2C433EF for ; Tue, 15 Mar 2022 14:28:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D47DC8D0002; Tue, 15 Mar 2022 10:28:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF8138D0001; Tue, 15 Mar 2022 10:28:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFBA38D0002; Tue, 15 Mar 2022 10:28:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 99A038D0001 for ; Tue, 15 Mar 2022 10:28:03 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 603C161709 for ; Tue, 15 Mar 2022 14:28:03 +0000 (UTC) X-FDA: 79246850046.12.D7C2C4A Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf09.hostedemail.com (Postfix) with ESMTP id 9C11214000D for ; Tue, 15 Mar 2022 14:28:02 +0000 (UTC) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22FD4nd8000760 for ; Tue, 15 Mar 2022 14:28:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=Wg8GSzxRyovdybvu3mvckPgAYEA+ZIt+HInRXMMiX4I=; b=QXeFW24STk8DyqU1z3Wbw2dMRFWjbsgwARyXuFA3WwLYRWljI8/7USRTc8EBFY3SxDjm H3/Pwq4h6iKzRtZpznNP6hHmYBfJJPAR7eFjPPtp0b8E0Y/rXcV4kZ8UKEgOrcqz+PD3 26VbQ5Givk7+NleINwJoHXBmZwvRtbde2yGAI+eX6QNpCmsRT1IbqkrEXpWZLZz80TDK i+GodVITQdITFhQmMs7fdkeskX7nH0H9uKvcSl73zNXMFdlqtDWwREYqAPky7BetFLiK ywfAHT7ZsUGIseS8tkHbBqBqqtKOJ81vlFT43iGejBOV1DI3aXjIrDaufW3R63nYg+EJ dw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3et5fu3d06-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 15 Mar 2022 14:28:00 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22FEBxdt074139 for ; Tue, 15 Mar 2022 14:27:59 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175]) by aserp3020.oracle.com with ESMTP id 3et64k0gpd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 15 Mar 2022 14:27:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i4YnVSurQGoR3Vui2XkF07C7ltLOjg5PmIDj4GsiqLLWvtt83vAaMSYmRYii5c4iqSAtua5jTE5LNWsiBC0+qqzXT0xJ7IoP6dO/vq3O1QbQJWJLXnKPjz9bqup/cgpyQY8DcVuXQ6YZMooQ5XRvx74v+t6Q9GHT/guweJrzp6riLPB8UbvTii4ZcpHd6U8wf7YRA9TCZa/Ld1K9Ur4gvYtuAimCt9LHXqBDrrelH7s1Uhy2h4RiMQTTCi3ZNCF5zcjzkCukNZxUkGozSwJZfsk356arm+TLCcGNneKNqCq/smz37YH0Tas/RFGrfYngOi88AzxxwDBS8hGg7M0LmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wg8GSzxRyovdybvu3mvckPgAYEA+ZIt+HInRXMMiX4I=; b=DhRHvWZBX+F+ERhUQS/yt3UZEkJUDuQY0TFUfcLGmAMZ1x8WrqRimPbgm9V8HZU+ZH4NKH2wc+VIadh2JRU5NAaVNWhJnJHNkI1kke9ehO6AcSYAZjJHOLqFTHcpsKajLk78yKuh8xOQACaSN1NJn/mIor949ZoCPo5nzlmu/DIz09KtHB3R6QxxikjOZ544wZwPLQ6epc8JnxXn2lSmvkdmTj12E0W0ih1jTmdQ8z7YMlzrecairwIHL9fL/FwRt9G+VlUD+PTWVoHukVM6z0Zf3Tdyl7LBWtiZ1pLemqEM46eoJGmFzYwVEIZYuACWyv5TrB1nte+havvP2VOBFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wg8GSzxRyovdybvu3mvckPgAYEA+ZIt+HInRXMMiX4I=; b=ENoaiTFE+kGf7jkJl0S85xm9vH/XtxKzPJ6ZF65wx34oI61fyK0/F1FN8OdheQ+4OF9fKg+f6iUwwmH7roFNPLRhMW6K3AsztxRcnkxLL5mrvug+WTKJEk6gUNmfPBowdYbUaDgM3FdOwpShlaVkMvFb1flXqWR+lr7ciJ5zszI= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MN2PR10MB3758.namprd10.prod.outlook.com (2603:10b6:208:1b9::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.24; Tue, 15 Mar 2022 14:27:57 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5%4]) with mapi id 15.20.5061.022; Tue, 15 Mar 2022 14:27:57 +0000 Date: Tue, 15 Mar 2022 17:27:46 +0300 From: Dan Carpenter Cc: linux-mm@kvack.org Subject: [bug report] Memoryless nodes: Generic management of nodemasks for various purposes Message-ID: <20220315142746.GA19924@kili> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ZR0P278CA0096.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::11) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18fd079b-16a0-436f-9644-08da0690001a X-MS-TrafficTypeDiagnostic: MN2PR10MB3758:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HSSsmiWjRrhliExRM60Wp2HUNLEqx0lvfUTgjg/uLCCegZ8NCTHkKjpdyinuEIHmC4BGqRyee7DqhpezMSwsESFa5vKaBU9ILTAacIB5DP2a9KFllqCSv7TFx/4y9qWpDVacERE7YRwQbGtjCho0TS1QmdI7qhZp2X9CTnZODLfqK+4vzdLuXqTtWD02pPMnH44So/zicj011/++bU6b/TmTKlHkbMlUyabZsKPf+6DWPWcW6BvehvR3o9Z83+3+K4EUiIf8A5QRfjQQJ53OWQYLzSw+bYOafG8t52wI3PvfkurfeGUmkk86YlSbvQrSGh4AepSbQ4ztrj5dyMdSRS7DEskAFvIli1h0m1GiytHk4WmylqnolFb4XvKDoPbB+dWfoNln/lTnkNTrc5dOHaevlVVgjS6SfyR6wa1Zw3rfFSaKt/kWvlHPTFvoVAz5JqK3pNauqeabg8W2MuFC3rqcsnRvzonNqz8pFKNibf2K/56tnyKuyAmAH/vda6hHRJoebZe4nCrhc2n8ZMW+wgTrrNzpw9UMJUsHR16b7LIjuncTEVGZsUml9xZsxjAJ2OnBHqOP/kZwYGlx/YOHZ/ZXbaxT1GxtzhIPKUXl0LrOSHHKEQvkI0tlFn63/YbMYD46ow0hmgkOQGzmudb4cucPg/Hidhm0PFc8v65cpiIRtSrp4BJpXTwjIrXkXQlBrZZZ3JlssVugrTm69mSsIMWXoQtQKOKrXnLd2fbEC8o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(366004)(186003)(1076003)(83380400001)(86362001)(109986005)(26005)(38100700002)(38350700002)(66556008)(66476007)(4326008)(66946007)(33716001)(316002)(9686003)(8676002)(5660300002)(8936002)(44832011)(508600001)(52116002)(6506007)(6666004)(6512007)(6486002)(33656002)(2906002)(41533002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i7CkN0Stjkh/iagmqqCSNXl05dE7IuvdOw79I8E2z1/lv/Is3F+mo/Bb6v0z?= =?us-ascii?Q?qXl4fvAkVBYPaf/vXbzTLJ/ZVhXJoSXr0SUGVqKmF+pZZUk+sNnAgTXZh02A?= =?us-ascii?Q?xkfaFykrlp0CVWhlIYAIdagstZsb9beYIVLn6VW77JeWIoHlPlszyrT9gm3P?= =?us-ascii?Q?BVORY8HoE9RKb8eUWKA00aBQwvPuISkEw2yB/ZQ9inWdJE3k3aaYghy8gYTi?= =?us-ascii?Q?vc6NkWRoe+B6SA04YxJWN+lIzM+IRCfE2qvCfCc/uSrkOTq0M4mEiOx6JrBr?= =?us-ascii?Q?oY9Bh9qlvl3NsVpah/4Ztss1Au0uKKui5ZlE5S9dhyv4iiFxFlAsZ2rtKsGZ?= =?us-ascii?Q?Y0z6+jW6vCT4yFx86gDX76dxGJhIXxSpvtmHN2iaId19abNxr8ZWfQh2hVtY?= =?us-ascii?Q?2CKYO3SfyXg24S03YwShzHGb19GHoTu6avmsy9MT37fXUd6ybdb9ZU+IWnVc?= =?us-ascii?Q?N37kHVQ+uJbVw/go3Lqih/JitHLSc47cTPTxEfcq8Ha4VcXnSI9/62OqjYZl?= =?us-ascii?Q?8QI6rdV4OYPIHPZhzkvfrr11fvAZlVyw3fQxxRdu9vrUrWsfUBltL8Pz7j/c?= =?us-ascii?Q?GWUsT3FTmUVcBPbLi30ErtnqOVLlCd9374KkqpemJSWLXvlVxVwyYIdl5u6M?= =?us-ascii?Q?VMJfasjzMOkmPfJ14U7Zsu3SNepT4KOptzc8Fkb1dbh/dDEjcWhoiMj6eN94?= =?us-ascii?Q?jtsUw37bWXgpPKtU3oRe1YYEW6tLLLJx4hTX9+swZHA215KE6J8V5CR3Hc/z?= =?us-ascii?Q?U00RGjbN6/cWsNTaV017GAaH1Mw99f0CTmFzVFnnRJf+qFn+/GRmBQPnakuA?= =?us-ascii?Q?bA5q1smAxl0STE1cQSUBy2+J3Wz302Xln18g+h95E3U9joXnJ832O78hULhb?= =?us-ascii?Q?+3nHP7nEdDbLhJO1MY7kJqSYKMxZBbBO1oH/hKzfAu45AFdRrkhBlsWvsKyc?= =?us-ascii?Q?IHNw34NjIbqfSuNUZ80UxIBLDQ0Ul5Z5l/ixbb+fbbBAthK/nqYVKWwWdbtt?= =?us-ascii?Q?ve0KQDXeIQn7zzqK4+IUqQP/jikxoa+u4m8Z3hK3qJRzQ0qsu0Vy2eL4K2J3?= =?us-ascii?Q?zRO5PEv4dcq/XbFWnditMBczXFBwYVheBdpLtgqNabvVcJ2aIWxWPEbk5HuC?= =?us-ascii?Q?hKpp8tpI9hXpkQhcF73Cd+39RSGV+ljJy18rImKl7l5VxFNyNidls9fu6aFc?= =?us-ascii?Q?GHm/fEqpYZA+q15Rt2uJ6qWyBN2eXWwB6xwT0U0woKYNISyoaiTYj0P3Hs4M?= =?us-ascii?Q?kIVWSrg0H0ZfYYgSJ0RESsjejnvUo48qJPiwig2Bd7cFpxDcdqIAGW2eq4rU?= =?us-ascii?Q?snxMkPLlKZTgTFSSllRtlxnK03J4tJEC7+P6P8RlPUokZqrrQqNqrajIX2NN?= =?us-ascii?Q?P1iTcRA9Lh5R8HF4tdL8IlMvrMZ3EO99SuQ7MHrFBgxyoH3XYjeqEp7P4FAm?= =?us-ascii?Q?yqYkA1P9XH1e4Oa78LZLjZT8uWSA6lMaLIhb2hS4P6RPlGL7SL5pmQ=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18fd079b-16a0-436f-9644-08da0690001a X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2022 14:27:57.7052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Er0l47Y9aI51h6p4jYPsn5EFgJDsMc/nrCNzZQT1GW5qNdWsJUC9cU6k8ugxhORLQwska7rntE/zau2KOyG2ggbvuaHQNBUi6irVAdkSIvc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3758 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10286 signatures=693139 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxlogscore=718 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203150093 X-Proofpoint-GUID: PBrEmJm38pQnEB8M0vEB4ADe_nnW54VH X-Proofpoint-ORIG-GUID: PBrEmJm38pQnEB8M0vEB4ADe_nnW54VH X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9C11214000D X-Stat-Signature: 4g7sm1tbkqgngfnknj3jwhmrtzbijyoc Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=QXeFW24S; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ENoaiTFE; spf=none (imf09.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspam-User: X-HE-Tag: 1647354482-966159 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello mm devs, The patch 13808910713a: "Memoryless nodes: Generic management of nodemasks for various purposes" from Oct 16, 2007, leads to the following Smatch static checker warning: ./include/linux/nodemask.h:416 node_state() warn: passing negative bit value '(-1)-1023' to 'test_bit()' ./include/linux/nodemask.h 406 /* 407 * The following particular system nodemasks and operations 408 * on them manage all possible and online nodes. 409 */ 410 411 extern nodemask_t node_states[NR_NODE_STATES]; 412 413 #if MAX_NUMNODES > 1 414 static inline int node_state(int node, enum node_states state) 415 { --> 416 return node_isset(node, node_states[state]); 417 } Smatch thinks there are a bunch of callers which seem to pass NUMA_NO_NODE (-1) as the "node" value. Passing -1 as a bit number to test_bit() is a bug. Looking through the callers it feels like Smatch is probably correct. drivers/iommu/intel/dmar.c | dmar_parse_one_rhsa | node_state | PARAM_VALUE | 0 | node | (-1)-64 drivers/acpi/numa/hmat.c | alloc_memory_initiator | node_state | PARAM_VALUE | 0 | node | (-1)-64 drivers/acpi/numa/hmat.c | hmat_parse_locality | node_state | PARAM_VALUE | 0 | node | (-1)-64 drivers/acpi/numa/hmat.c | hmat_register_target_initiators | node_state | PARAM_VALUE | 0 | node | (-1)-64 drivers/base/node.c | node_set_perf_attrs | node_state | PARAM_VALUE | 0 | node | (-1)-64 drivers/base/node.c | node_add_cache | node_state | PARAM_VALUE | 0 | node | (-1)-64 drivers/base/node.c | register_memory_node_under_compute_node | node_state | PARAM_VALUE | 0 | node | (-1)-64 drivers/base/node.c | register_memory_node_under_compute_node | node_state | PARAM_VALUE | 0 | node | (-1)-64 kernel/sched/fair.c | task_numa_placement | node_state | PARAM_VALUE | 0 | node | (-1)-64 regards, dan carpenter