From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 777DFC433EF for ; Mon, 14 Mar 2022 23:21:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 931846B0071; Mon, 14 Mar 2022 19:21:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E0846B0072; Mon, 14 Mar 2022 19:21:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 780088D0001; Mon, 14 Mar 2022 19:21:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 6870A6B0071 for ; Mon, 14 Mar 2022 19:21:36 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 14BD6225E4 for ; Mon, 14 Mar 2022 23:21:36 +0000 (UTC) X-FDA: 79244565792.14.885661E Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf18.hostedemail.com (Postfix) with ESMTP id 93E7C1C0004 for ; Mon, 14 Mar 2022 23:21:35 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id qx21so37436815ejb.13 for ; Mon, 14 Mar 2022 16:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6R11bvjmYsahK0gJVGfVX+7+GFhuag8IbRPGFQJNZaM=; b=j/wjktA6qFCOxz1OA06/g8dx7uSwFMKqT1oNnSCtnjX9Lwo4cFU16UFCNsIueVvXs3 45cYyul1S9P2C1B2MTsXqDa+LqH63ZmJDUpI/YuAkns8KCXgyzG+XhkXpr/Sb2PaBZVQ jtm2fGEWfakDVIzWQT6BBDk4cQ/qmZE24a5z6tPgjz6b8d3yvqR33lFdb9rzMIoz9f6y UzW/dz/Hy034/KJ/7PKPUFNDjOoOqD/03/K1NY/K9qqYu58Yw5ZUpnevBvhbCt9D35Xs CJNYN4OQxQcseaAPOhKoLWG9KQ70ftA298t96NXG+TUhplqRXylnSw91DLK+l9P+g6r/ kAmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=6R11bvjmYsahK0gJVGfVX+7+GFhuag8IbRPGFQJNZaM=; b=lkraq2Ago2Fr9Oq9czlb/rEoxTso1ikyAGJDKMei2kmZjbGmeTZcceXLznQCG6LoK8 eG1wV5rS07KhwnwwwQKUK/Lh7tK3wk96EqAaU7Ps156R8nzZvD3MQAmWoIQOftIk6OtK HyUaWFMtL22TYSlwACA7vRWlBBysy2wc/rm3zgB0urRFILXxbeEWZZOheVDT9Bc3YWWt EIGoLzokGe5Ctohd+ZrU76N7SjyPwTJAZ6J2szmRlhTpmjMrcMan0GHxzjb4g5nyt8GQ DOHlHb69+RYGJ9PMYVRpvbY4Nu2zc8onvUYsy/06NVNaMh9mHvG0bFubz9RUC0gPPyX6 2P6g== X-Gm-Message-State: AOAM533KMuwBD7nNzaj3RHEn//l1Fhc7jKTKACXLSajjLJ4xulvFU36J BpPHg8wKDNkmMziFrCrt8wg= X-Google-Smtp-Source: ABdhPJx6MtlWw8feC1uuozWu7W0VrXop/X2ZU1IUPQUgarYKXBHnpU+TH2gk8ejob/DgFMewUmo5tA== X-Received: by 2002:a17:907:a089:b0:6db:ef38:1a29 with SMTP id hu9-20020a170907a08900b006dbef381a29mr1540111ejc.269.1647300094426; Mon, 14 Mar 2022 16:21:34 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id z5-20020a1709063a0500b006da8fa9526esm7355971eje.178.2022.03.14.16.21.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Mar 2022 16:21:34 -0700 (PDT) Date: Mon, 14 Mar 2022 23:21:33 +0000 From: Wei Yang To: Michal Hocko Cc: Wei Yang , hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [Patch v2 1/3] mm/memcg: mz already removed from rb_tree in mem_cgroup_largest_soft_limit_node() Message-ID: <20220314232133.owoq5vzsd2bvggma@master> Reply-To: Wei Yang References: <20220312071623.19050-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 93E7C1C0004 X-Stat-Signature: w7yq37hqupauqnudxtp46bzzrfj3rsiq Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="j/wjktA6"; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1647300095-840038 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 14, 2022 at 10:51:51AM +0100, Michal Hocko wrote: >On Sat 12-03-22 07:16:21, Wei Yang wrote: >> When mz is not NULL, mem_cgroup_largest_soft_limit_node() has removed >> it from rb_tree. >> >> Not necessary to call __mem_cgroup_remove_exceeded() again. > >Yes, the call seems to be unnecessary with the current code. mz can >either come from mem_cgroup_largest_soft_limit_node or >__mem_cgroup_largest_soft_limit_node both rely on the latter so the mz >is always off the tree indeed. > >> Signed-off-by: Wei Yang > >After the changelog is completed you can add >Acked-by: Michal Hocko Will adjust it. > >In general, though, I am not a super fan of changes like these. The code >works as expected, the call for __mem_cgroup_remove_exceeded will not >really add much of an overhead and at least we can see that mz is always >removed before it is re-added back. In a hot path I would care much more >of course but this is effectivelly a dead code as the soft limit itself >is mostly a relict of past. > >Please keep this in mind when you want to make further changes to this >area. The review is not free of cost and I am not sure spending time on >this area is worthwhile unless there is a real usecase in mind. > Yes, after more understanding of the code, I found soft reclaim seems to be not that often. Thanks for your time and will choose some more important area for change. >Thanks! > >> --- >> mm/memcontrol.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index f898320b678a..d70bf5cf04eb 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -3458,7 +3458,6 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, >> nr_reclaimed += reclaimed; >> *total_scanned += nr_scanned; >> spin_lock_irq(&mctz->lock); >> - __mem_cgroup_remove_exceeded(mz, mctz); >> >> /* >> * If we failed to reclaim anything from this memory cgroup >> -- >> 2.33.1 > >-- >Michal Hocko >SUSE Labs -- Wei Yang Help you, Help me