From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 224CEC433EF for ; Mon, 14 Mar 2022 22:51:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3849F6B0071; Mon, 14 Mar 2022 18:51:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 335468D0002; Mon, 14 Mar 2022 18:51:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D55D8D0001; Mon, 14 Mar 2022 18:51:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id 0EC9E6B0071 for ; Mon, 14 Mar 2022 18:51:54 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 978E59F5DB for ; Mon, 14 Mar 2022 22:51:53 +0000 (UTC) X-FDA: 79244490906.31.4BBED1F Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf15.hostedemail.com (Postfix) with ESMTP id 111E4A0004 for ; Mon, 14 Mar 2022 22:51:52 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id r13so37379873ejd.5 for ; Mon, 14 Mar 2022 15:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wCeR5z7Z9I0OZ5CW9/ENgLziIVfJwONuLcSxsmCrGvQ=; b=C0C8NN3xNrpb0KoqYriDF0/coODFEYWWLzYOmoHnZsjra3mm06pm8YS0CMGKFLt21h d4xtohTHd3MOFp9xPgAKmy0nXJ9B7PV7He5Eh6K+4Cb4BXdxHUMBQ8gR0gTnvwhdqfqQ d8QZA0r26ZW7orl+WkOUjr1mqXxWk1UeBzJRuoMT0TRM6Vm3xzLfA8OYL8OE+Qa+Wc2s oo72lh8kFvnijMO8WnuQDRAvIQDQuQEVGDu4/LdvDKzpjyVDEi6SZk2+0ouqqAIiwoAc qMCkkLK+Vy/bRn4QOskN46wbNMNVONWyeZtF/FI9lTRWxBh0RChuviSAXIRryv8SvqoX +n3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=wCeR5z7Z9I0OZ5CW9/ENgLziIVfJwONuLcSxsmCrGvQ=; b=qhoKWEo5d67H21S2thldAmLGy5kfZtdImeVECUI/wbwj/X6N5XIDu9wDhrAszM9T0h SRcYxnrxxEpzp4w1vfIPMqJxsUuCt5SuBWtI9KMeYCS4fjIDQOaU5QfIo0EFKPwXM/o/ RVoamW5fR0LW8wifB6N24ZqrLCY47in4jMM0MvHre0wIWS4JChWBP++52l5MgHwa96fG I7rhRv8E139cb45FRoah2QQpxgXm+61XZHapceTXJT+qnqKCXcCvpHFvUQcc75QYTk3c UTOcwG2+LoLwk9P6KKZW/wng0knlLSCM/7hFGCt+ZYiH7WcBrdVj1+qQOeJLSfCwbB2s cgcg== X-Gm-Message-State: AOAM533QPIW4kKmT7qxJ6tpY0DlAI3H6zyy1R6bzKbG+fpsZxYClDaF/ jp+G3UKaCWL7y/hdDtXlgqo= X-Google-Smtp-Source: ABdhPJz2iFWYlpahGGyqdkRdhh/60lKzlbsCAsF3zu4k2xuvC579SqvfVVIF4SxOSeriVqJIp+5TwQ== X-Received: by 2002:a17:906:30d1:b0:6cf:c116:c9d3 with SMTP id b17-20020a17090630d100b006cfc116c9d3mr19545523ejb.245.1647298311650; Mon, 14 Mar 2022 15:51:51 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a1-20020a1709063e8100b006ce06ed8aa7sm7360040ejj.142.2022.03.14.15.51.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Mar 2022 15:51:51 -0700 (PDT) Date: Mon, 14 Mar 2022 22:51:50 +0000 From: Wei Yang To: Michal Hocko Cc: Wei Yang , hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [Patch v2 2/3] mm/memcg: __mem_cgroup_remove_exceeded could handle a !on-tree mz properly Message-ID: <20220314225150.fhwny4yhxgjevwxx@master> Reply-To: Wei Yang References: <20220312071623.19050-1-richard.weiyang@gmail.com> <20220312071623.19050-2-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 111E4A0004 X-Stat-Signature: x57ruoc3tjzt1supqzqz11zf8wu4yssd Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=C0C8NN3x; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1647298312-186644 X-Bogosity: Ham, tests=bogofilter, spamicity=0.070322, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 14, 2022 at 10:54:03AM +0100, Michal Hocko wrote: >On Sat 12-03-22 07:16:22, Wei Yang wrote: >> There is no tree operation if mz is not on-tree. > >This doesn't explain problem you are trying to solve nor does it make >much sense to me TBH. > This just tries to make the code looks consistent. >> Let's remove the extra check. > >What would happen if the mz was already in the excess tree and the >excess has grown? The purpose mem_cgroup_update_tree() is to update the soft limit tree. And the approach is to remove and add it back to the tree with new excess. I don't get your point for this question. -- Wei Yang Help you, Help me