From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732D2C433EF for ; Mon, 14 Mar 2022 18:24:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFE026B0071; Mon, 14 Mar 2022 14:24:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAC708D0002; Mon, 14 Mar 2022 14:24:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C749A8D0001; Mon, 14 Mar 2022 14:24:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id B84506B0071 for ; Mon, 14 Mar 2022 14:24:42 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9262C60FF4 for ; Mon, 14 Mar 2022 18:24:42 +0000 (UTC) X-FDA: 79243817604.05.F30D6E4 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf27.hostedemail.com (Postfix) with ESMTP id 151864000A for ; Mon, 14 Mar 2022 18:24:41 +0000 (UTC) Received: by mail-qk1-f175.google.com with SMTP id q194so13528495qke.5 for ; Mon, 14 Mar 2022 11:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=WzM8onKgtpRf9pu36Rc/MnvN6d5RHE8+6dA8lDFE29o=; b=UkknauDkLxctXMKPfBYReK5fLkpsRQnTb/lLakkCtayo91pyMtn/BQP92ntSIFnPJL zZZ3EEoKVq800PEDwB+SNhsgFc7/fLsIsldKGOW8v1tkZei8HSoUWNUm348c5ErUPRyk XXn5Eb2+ncqb4rwQfBk23KTBvyC3qaCGw13o8az+b8K9ZMLUcuzsNVbiOulwbvlO9HgW zg5C6iH5wzaN/MMVKhtkCCRr4ts7pSNjNSjKiLJofV4Q6hIQN1JraRLrJzszh7vwKsvD Ev2KlofLSfMNLLq6369iiMEH9/z8ztLK33lIVrdbG41ii9uQvpDBqtbLWoAF5dYb3svD o/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=WzM8onKgtpRf9pu36Rc/MnvN6d5RHE8+6dA8lDFE29o=; b=Vxb0xtYZ+JDDcFOV3RgKojk/aGG2iWrri0cpVjQl97yDKN5AWOIu7UC6uqot4e98RE EPoj2nvIyNFOi0Uiv1jWLMIWTs2XAmzFpCoYaBYic51TRvnQ0s6EBBqVhpbwWzC1psZJ 2G+MEK3UPWOsAzXf044V1YaDhnW9Gj7uA/AAbc66hBGNj4TD1iM4ngpeociG3xVmkPpM /OV+gzs7VtTnyBJv6PQ69aU8gluKwzYlnGG9YbQi9QHypEAtWGT4q3XfD8JfduUk3SBg 5T+MRue0y2ne+RUZRlxNAckwQ78pX6SzUK2oQvGsjIILLO0mV+bsxvkYfx4O0KXzSHxK ZgfA== X-Gm-Message-State: AOAM530ROSVVoZcw9F1n0gb6OLGiyTCikXhX6eGhOEkViVZUjvX0A0Kj NKrQr0J2oehoD5qaor45o1YG3Q== X-Google-Smtp-Source: ABdhPJza7gdcTvDezy7LqMZeXnQjGtoym/j9bUPXKCDR3cRCg6RvO9AQ1sVjjcpITrhsob4oZktxkA== X-Received: by 2002:a05:620a:13f2:b0:60b:d595:6db1 with SMTP id h18-20020a05620a13f200b0060bd5956db1mr16006671qkl.366.1647282281351; Mon, 14 Mar 2022 11:24:41 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id t207-20020a3746d8000000b0067b33b6a4efsm8111557qka.21.2022.03.14.11.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 11:24:40 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nTpN1-000RjZ-Hw; Mon, 14 Mar 2022 15:24:39 -0300 Date: Mon, 14 Mar 2022 15:24:39 -0300 From: Jason Gunthorpe To: mpenttil@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, apopple@nvidia.com, jhubbard@nvidia.com, rcampbell@nvidia.com, vbabka@suse.cz Subject: Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice instead of char dev Message-ID: <20220314182439.GB64706@ziepe.ca> References: <20220311033050.22724-1-mpenttil@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220311033050.22724-1-mpenttil@redhat.com> X-Stat-Signature: xmwihjgh1jowpwkrcpsxsa9dahgxjdc6 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=UkknauDk; spf=pass (imf27.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.175 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 151864000A X-HE-Tag: 1647282281-826916 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 11, 2022 at 05:30:50AM +0200, mpenttil@redhat.com wrote: > From: Mika Penttilä > > HMM selftests use an in-kernel pseudo device to emulate device private > memory. The pseudo device registers a major device range for two pseudo > device instances. User space has a script that reads /proc/devices in > order to find the assigned major number, and sends that to mknod(1), > once for each node. > > This duplicates a fair amount of boilerplate that misc device can do > instead. > > Change this to use misc device, which makes the device node names appear > for us. This also enables udev-like processing if desired. This is borderline the wrong way to use misc devices, they should never be embedded into other structs like this. It works out here because they are eventually only placed in a static array, but still it is a generally bad pattern to see. > Delete the /proc/devices parsing from the user-space test script, now > that it is unnecessary. This is all because the cdev is being used wrong - it get all this stuff it should be done via cdev_device_add() and a dmirror_device needs a struct device to hold the sysfs. Jason