From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D83C433F5 for ; Mon, 14 Mar 2022 13:31:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AA3C6B0072; Mon, 14 Mar 2022 09:31:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 381B08D0003; Mon, 14 Mar 2022 09:31:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AED38D0001; Mon, 14 Mar 2022 09:31:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 095796B0072 for ; Mon, 14 Mar 2022 09:31:22 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BA58C8248D52 for ; Mon, 14 Mar 2022 13:31:21 +0000 (UTC) X-FDA: 79243078362.26.C52928C Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf26.hostedemail.com (Postfix) with ESMTP id F34F214002B for ; Mon, 14 Mar 2022 13:31:20 +0000 (UTC) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22ECUcwj013725; Mon, 14 Mar 2022 13:31:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=HXhOoTqxUUKBpcSGMTejPZJmTGywqbtWwgm6REy3f4E=; b=HflrBioGGN5sRezBoBga3x38KD1SX50Ws3J+4e+Qk1KANyD1yAJOPyhx7wkRvcgTiqeK fmCpVMTKFv8is3jG9m2Tp8SMmcU8n8nMPF42cNVynb1XDYlExCFm8qbYuwYfWR+27YNG zRdMSRePzz18S7jrLgVBTDkCZ38ZSa4JP+ihXOWwyVoWfRmejj5JOP6Yynvp2gpj6Cwp xsdlgJwfnSITXxAizT7i4o48N1rHwQ9xp66jBnfZi/ZgEN6O8mhs8nt69QJSZMPAZTxp EWT4Bp4ewbTz3vYTaNfvjJcwA/onDiZenxu0bdFwwusXsxhC0ROFlGCkTN3z1BcrvmO7 8A== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3et5s6g600-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Mar 2022 13:30:59 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22EDUUMo177937; Mon, 14 Mar 2022 13:30:58 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2049.outbound.protection.outlook.com [104.47.51.49]) by userp3020.oracle.com with ESMTP id 3et656rtrh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Mar 2022 13:30:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zudp8UbZrrOEF1EAXt4UaUP1OLfqwCeFbWr4Jf7Jig/f9eF/6XBtTpVJDULWdnEDhNGK6l/m2FmlXgH3BNvoQmI9gI51DnI8AWPhNknYc361B4gCdgFDFKa/+II+wG2b5MRq+xMrLoLycuIT5T9alJbJ6ir5HBtIHUuGWYfVyXOKVqeXAidSarfE/+yM39UNiKshKYjHf2A/UxfxJVbrOP/K2DEPO85VZYs6ywQkhrk8iebTLL038zOW0YPrKtWgawqw/GIw9/7AlguRDmVGiiV06sxQxnqVVUqwTN3/7MaFGVbkKVVh0emcyTIWIm0Qh0+OaQLdeB20vqFJojpl1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HXhOoTqxUUKBpcSGMTejPZJmTGywqbtWwgm6REy3f4E=; b=Xsd6GXeq47C9XNb2ei7fk6b6aHhiePbM0MSIUEChnhYGt7+jIXhSKHGmyds+AiJMFMODN4Ov0tOPQQyeaZkAI8M7nGZlXDzCrkGN02bkKpJuEDlekkxyZCU1+r1dXO9drSkaRVVUAm5O5VoO66u534+kW6dSa8r9RuCsgokkO/zGf7DcpXcnMTEHDaKQcJqkOnsN0T4VkIF16xumyk1sP1ZfDwqy1YSu0WTRZnjWjaTRtCNu3BQI0b+fjfN/NP1FSYW3oEiy7NAkceDHjmxJ1tAW2oJOuHK62GvOVA+5XBzOiustn0tJ5AfdIxDus8rJ2vgJo5d4nub2/djMy17cmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HXhOoTqxUUKBpcSGMTejPZJmTGywqbtWwgm6REy3f4E=; b=JyOknII2/UgEbQWvFyRElSmMXK6Tkh7ycC8EC5ZUGt6fn0Afn8wpz7wAxie8nBJx31lawLXlKnNrwxW66yk3XNz0uj1SdfNPuxYsmE1vntmutA8Vxkhl0JHseB/DlMUa0XJyE8gBZkpjJoT6JnmHTjowQVBFgeMS3aKRzV4fO2g= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by CY4PR10MB1751.namprd10.prod.outlook.com (2603:10b6:910:b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.26; Mon, 14 Mar 2022 13:30:56 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5%4]) with mapi id 15.20.5061.022; Mon, 14 Mar 2022 13:30:56 +0000 Date: Mon, 14 Mar 2022 16:30:38 +0300 From: Dan Carpenter To: Matthew Wilcox Cc: kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 9762/11953] mm/page_vma_mapped.c:246 page_vma_mapped_walk() warn: always true condition '(pvmw->nr_pages >= (1 << ( - (12)))) => (0-u64max >= 0)' Message-ID: <20220314133038.GS3315@kadam> References: <202203131056.WINF40Gt-lkp@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: JNAP275CA0003.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4c::8) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 593e3f1e-3070-4d74-14fd-08da05bede6a X-MS-TrafficTypeDiagnostic: CY4PR10MB1751:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5mpwqGpuU2BcIQq3bdCTypmG8PLfDF2XUruZAKmpSHQ3kwtaOp75zvFFOBL8jLdM6TzaDmcmpX6fmWHgS/jHGaEp1+nj2g3Y6tOSp2qsSLZvppKzEC567frvwdu5nbN3s79KLA6kDEypHh9Tlo0mULBcQuGvj2D1Wlg9n6mfQzKl9O33WS94ytzECsYqAb9cmGfwNQKR9hYmuQUYIwHj9LbmZvd1TpRlUL6tZST/XD6a0ntvjhyMa9ce46lp9nF1wtmeM+7JqzzmcWpkzPoSXWfZskqISLg0i+vuUNh+sxFT/weCuhnvneZ0ZNfmVNJhY73LigsmnJYg4a8U5dOnWawLEK5JKA7QzdnVZ6hQG7MjCFZuJTbGTsxLKEOvNKh/4CQNhGZ+5KOlVjjp+UX0qSLPUYHUlt4STCQS/G+g5/tHgcFUkc+uX2FocGbGVdhnUiHDqdCR1J39waSLT06rWnoMZBRVTIZFvqlx0vsnsb0E9X3lN4E6wwKho0ECzjQ+Soc7zREjaD/DWxTyLgF3P1Ur3w66Ec2j4sNnMC/O76TzlmHpcT9KaOYCh0S1qXzrKwb5nlcaEvBveEDcXG7q2XnF/CLclYXe6VJNOQc6U7LJ5/Qsp/eAj0VOfWSnIU/Z6XcxUi/AhkOOhX+lw0JFtZTjJYASVZttQIkpbFM4OXFw4IYIqaew4408A8ksU+MJbNqvoq2h49XYq9QxEESZYlIIsYu0aOAboU0HpevJzZh04OjV8ygkNVgWEktzpdNJsPxmTqx/oj9RTLVAtAnDrYgn3KFVI9gcgxJzTwFDdmV/7U9x85ggROn8VbQ9CFshBZACXwAKAWqxxu+XBX4bhg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(366004)(54906003)(316002)(33716001)(6512007)(6916009)(9686003)(86362001)(33656002)(66556008)(508600001)(66946007)(6666004)(66476007)(4326008)(8676002)(6486002)(966005)(52116002)(6506007)(83380400001)(38350700002)(2906002)(38100700002)(44832011)(186003)(1076003)(8936002)(26005)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?f6J7y9aMMbQjQK2qe9FzdZnovV1s4dl3wTf6XK1d47jclsYPFVk43X0RVaTK?= =?us-ascii?Q?CXZxcxUh4C9uJND8U/6fRo/CCa7HjJhCW05/CptlC/H2vnS9sGqTyfaHF4+H?= =?us-ascii?Q?0XKTNmJRRxppCsDdZ3QzCACjCVOGdmQv/DLAuzK4zYWid/yd2A0yrb607+3p?= =?us-ascii?Q?eAVIq0GaW4Xp0Y5OAvhEVxWby6mtKcf0xXju3GvitlOv983SFpDO/4BvIAPc?= =?us-ascii?Q?fdAVe8RhwRnBrjWSfCjA/km9zuKRXcQEiyH5uDQO9xguYkzyDXIUFl5rn14o?= =?us-ascii?Q?q49RHWRck3YGToxPryeZ0NQnbVcvhLrciT7d5IosUTgyJW7lnQU3+1bQuTTI?= =?us-ascii?Q?MYF2F/OAgah6F5UAOpg/OSNono4z4JxyB+ZK8HZ8SmUMROqNfy+/UBstnYiX?= =?us-ascii?Q?pBV7PHD07nxvuLTlNFBxSAgARWL/aR2XJ1az0/Tvpi3xW+YbiGNVorts+HB4?= =?us-ascii?Q?iLR4GFRYhiViAn6ABYHNl2x7iq/MK8/WHZsBBc4PABbQPDRdXe04Mey1Hezs?= =?us-ascii?Q?EBJNdoj+/cjCSI/8+umrhYAeThX96y02jubBJXYhI9380I92BLe2OwJPkgxd?= =?us-ascii?Q?aFCVQ0PtyRUh84Dj7lYJGTWtXN44JyibeKvuebdO+KQpsr59TGknOrV3LMr9?= =?us-ascii?Q?S7HXxDE8ud5wXkBPwFN5cL9mOJ5GgDQxsYdYU+ox+VsuJx9PeKU0YgoMmRHq?= =?us-ascii?Q?ShIQwmu01LQ2idgQxXYkQf/uSZMm9Jz2DsQavWf5Z3I8FrthsM5EJLxjsvyz?= =?us-ascii?Q?sId05K+oCvkGAJ2tD6U+sAQZHWqIzu0tZ64Vc+8Wu6hzV7OYX1fSEslHW79C?= =?us-ascii?Q?8RFz/t0eNpWjMycnM+XmemWbnxr/GrsVvBwSNdCn4DIUPxg0G91On03IeSUE?= =?us-ascii?Q?dQefdpNrnJ6TGVKehuGUkRz0MKHb1VHbiPmXz2hix8E25CxoB344Vu74JQ1V?= =?us-ascii?Q?hlZRH4f3pcfYwLMQ94uZjiQNsAfVHpiujByJGIWsgLQJcmUB2Q4utlJ87f2B?= =?us-ascii?Q?xGgM6XGyao6jSz3mVQO0QRLBwgbOiJ9x5MqzT6QzGJKXll5AzOI6f/emgOb7?= =?us-ascii?Q?DByWXFA5te20WJqH2uCYvl0518wNb8X0mAqa9oZy7h1Rb/YVZYZQ6mtwDgGz?= =?us-ascii?Q?aPXs7pHOixwKfqqV03ualTHRW7LHcA1elGdv6bvIdNejmatxSocPyYEW0OdP?= =?us-ascii?Q?cdcB9jXqkuZ1A1RDRs6xTJRR8IkSFn2SiIw8KzvAAFoYXv3rcDjO0um0oCA8?= =?us-ascii?Q?zxSlXcOZzZ+w+Hg3keK3puNW3ckQOZp04KMv/CeHUTdrwppZO1jV5Mz6291C?= =?us-ascii?Q?4Z7nJVUnehzrSeJbQrE9o6HPLk3e6kvrgESc/6Y/rsXfEFyiRGbo3DuLk3/m?= =?us-ascii?Q?Sjxi8er8/p6HrdsChHxnYiwaDnZS1RyCHWQs40RLrwAYVC1BIkYEJjrXCGQm?= =?us-ascii?Q?7TAj0JpTl+fd1MQDWR13CJ407fpcwOMIqwpL+Q+JdOvZLFZxxfUN4w=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 593e3f1e-3070-4d74-14fd-08da05bede6a X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2022 13:30:56.4765 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t4QHnE9dqWaNZexlPcOMfiKTL08WgaYAEORgSncSKZvGrgfPn5aVTB3F2jXwJluBMFIFOB/af4FfCFAZdsn0InZjZgpeVGsL2wcY7pd/jxA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1751 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10285 signatures=693139 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203140085 X-Proofpoint-GUID: m2Sf-N5LwbmwXSd5_APcsIoJivfsuiHp X-Proofpoint-ORIG-GUID: m2Sf-N5LwbmwXSd5_APcsIoJivfsuiHp X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: F34F214002B Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=HflrBioG; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=JyOknII2; spf=none (imf26.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspam-User: X-Stat-Signature: b5gaeskim184ut4izi5jwiemteerembz X-HE-Tag: 1647264680-723391 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 13, 2022 at 04:06:37AM +0000, Matthew Wilcox wrote: > On Sun, Mar 13, 2022 at 11:01:09AM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 71941773e143369a73c9c4a3b62fbb60736a1182 > > commit: b786e44a4dbfe64476e7120ec7990b89a37be37d [9762/11953] mm: Convert page_vma_mapped_walk to work on PFNs > > config: riscv-randconfig-m031-20220312 (https://download.01.org/0day-ci/archive/20220313/202203131056.WINF40Gt-lkp@intel.com/config ) > > compiler: riscv64-linux-gcc (GCC) 11.2.0 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > smatch warnings: > > mm/page_vma_mapped.c:246 page_vma_mapped_walk() warn: always true condition '(pvmw->nr_pages >= (1 << ( - (12)))) => (0-u64max >= 0)' > > Looks like a duplicate of https://lore.kernel.org/lkml/YgpzPru8aFA5sHOI@casper.infradead.org/ > > Dan, any thoughts? Do you consider this a false positive from smatch? > That's really weird that HPAGE_PMD_NR ends up as zero... Does it wrap to zero? Anyway, it would be easy to silence the warning based on that it's on an impossible path but I think that's not the right idea. if (is_impossible_path()) return; A lot of the bugs that Smatch finds are in impossible to reach error handling code. I'll instead silence it based on that the macro definition changes. Add it to smatch_data/kernel.unconstant_macros: - if (!possibly_false_rl(rl_left, expr->op, rl_right)) { + if (!possibly_false_rl(rl_left, expr->op, rl_right) && + !is_unconstant_macro(expr->left) && + !is_unconstant_macro(expr->right)) { char *name = expr_to_str(expr); sm_warning("always true condition '(%s) => (%s %s %s)'", name, I'll test this out overnight, tonight. regards, dan carpenter