linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <tony.luck@intel.com>,
	<bp@alien8.de>, <naoya.horiguchi@nec.com>
Cc: <mike.kravetz@oracle.com>, <shy828301@gmail.com>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<linux-edac@vger.kernel.org>, <linmiaohe@huawei.com>
Subject: [PATCH v2 2/3] mm/memory-failure.c: avoid calling invalidate_inode_page() with unexpected pages
Date: Sat, 12 Mar 2022 15:46:12 +0800	[thread overview]
Message-ID: <20220312074613.4798-3-linmiaohe@huawei.com> (raw)
In-Reply-To: <20220312074613.4798-1-linmiaohe@huawei.com>

Since commit 042c4f32323b ("mm/truncate: Inline invalidate_complete_page()
into its one caller"), invalidate_inode_page() can invalidate the pages in
the swap cache because the check of page->mapping != mapping is removed.
But invalidate_inode_page() is not expected to deal with the pages in swap
cache. Also non-lru movable page can reach here too. They're not page cache
pages. Skip these pages by checking PageSwapCache and PageLRU.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/memory-failure.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index dabecd87ad3f..2ff7dd2078c4 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -2190,7 +2190,7 @@ static int __soft_offline_page(struct page *page)
 		return 0;
 	}
 
-	if (!PageHuge(page))
+	if (!PageHuge(page) && PageLRU(page) && !PageSwapCache(page))
 		/*
 		 * Try to invalidate first. This should work for
 		 * non dirty unmapped page cache pages.
-- 
2.23.0



  parent reply	other threads:[~2022-03-12  7:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-12  7:46 [PATCH v2 0/3] A few fixup patches for memory failure Miaohe Lin
2022-03-12  7:46 ` [PATCH v2 1/3] mm/memory-failure.c: fix race with changing page compound again Miaohe Lin
2022-03-13 23:41   ` HORIGUCHI NAOYA(堀口 直也)
2022-03-14  1:51     ` Miaohe Lin
2022-03-14 18:20   ` Mike Kravetz
2022-03-15 14:19     ` Miaohe Lin
2022-03-15 18:19       ` Yang Shi
2022-03-16  8:18         ` Miaohe Lin
2022-03-16  8:30           ` HORIGUCHI NAOYA(堀口 直也)
2022-03-16  8:41             ` Miaohe Lin
2022-03-12  7:46 ` Miaohe Lin [this message]
2022-03-13 23:41   ` [PATCH v2 2/3] mm/memory-failure.c: avoid calling invalidate_inode_page() with unexpected pages HORIGUCHI NAOYA(堀口 直也)
2022-03-14  1:58     ` Miaohe Lin
2022-03-14  2:50       ` HORIGUCHI NAOYA(堀口 直也)
2022-03-14  2:59         ` Miaohe Lin
2022-03-14 23:45           ` Andrew Morton
2022-03-15 13:55             ` Miaohe Lin
2022-03-12  7:46 ` [PATCH v2 3/3] mm/memory-failure.c: make non-LRU movable pages unhandlable Miaohe Lin
2022-03-13 23:43   ` HORIGUCHI NAOYA(堀口 直也)
2022-03-14 17:34   ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220312074613.4798-3-linmiaohe@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=naoya.horiguchi@nec.com \
    --cc=shy828301@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox