From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03864C433F5 for ; Fri, 11 Mar 2022 11:53:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16E118D0002; Fri, 11 Mar 2022 06:53:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 11D228D0001; Fri, 11 Mar 2022 06:53:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFFF18D0002; Fri, 11 Mar 2022 06:53:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id E11BE8D0001 for ; Fri, 11 Mar 2022 06:53:58 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 86C48181BC0AD for ; Fri, 11 Mar 2022 11:53:58 +0000 (UTC) X-FDA: 79231946556.29.0D133D4 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf26.hostedemail.com (Postfix) with ESMTP id C3B4E14001D for ; Fri, 11 Mar 2022 11:53:57 +0000 (UTC) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22BBMd1o021579; Fri, 11 Mar 2022 11:53:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=rHUZYWCDNshnFQamWW6UBDRL4+XP1XxlcolKs0cPruE=; b=yfIvKpH2yMGRI7RGPHeT2Ixpt4r5+79oOTkUyuqgcJBlun+tlQ7X7p36bMLd8E94gBEM 7XUoGq6isCNJLa1METhh2XypLAs5irxbeeUlQRDWvdAYHj9xUnpQOdbzP+tCMPboP3lM R78dhnDdOR+j6CGmZ5eLOwWe8p9raNTtvYW4TGy60RHZ8+zGuos0tINa0TDqlNu4q0eK gKDkwwFCGnUKiKd1/iWWubtjZ6r91stEFkz5cBNsyxY2LnydgudCLISgAB0dekTRN3wj gCNdOxZ9h1nkBuHfrgODMSfb1HXjy39gPg2nJlffB1kkcVN6h5M+WKLBRznLWWgaoIgh wQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3ekyfsrxyb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 11 Mar 2022 11:53:52 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22BBoV0o093079; Fri, 11 Mar 2022 11:53:51 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by userp3030.oracle.com with ESMTP id 3ekvyxj57d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 11 Mar 2022 11:53:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k8zeCgy9uHdP+BXnuHya1Y4EpQbhfC0HgYnFljhpW+DBseNmCOVCa75pt4cBmnCGOQRKHrISTq/wKJGw/WnUY77VYKfWt3C+sFeMQDlXz745TLMyD34hfgm4RjgSdBnQjvJHI7ZtaeNZfIwS9KJnyCE5D3MiQhcgqOf6ZTpwOGw8IiLb9/BCnPEiXsewChmDDFEHjrY6rpu/SlCY7tF+KtbgW0eNJ4HSClASUDz/n7VE+ex/ZmMoJIdO9zQAeHUWbt4b5ZeEsoYcJB6L7V8VeU3VRS6pA0G7OuUhzXlXJZRsALTzhGIPU8+Hq4hz8gXYRolhRC/M8hmZnwIG9RZFQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rHUZYWCDNshnFQamWW6UBDRL4+XP1XxlcolKs0cPruE=; b=hVJ4/s3ocaRQ+UnHHwWtXW2+SA1HX7oUOnkJ1HIWyWxiRY2nQiDIypyi0udtte0duWyvqZRLasSwehhBM3+wZRUJu4IKYrNQnMzwa/siyJ+PCwPCigU5j1qusbNlAdfReVDweQJCHeWkwW1NIQwRG9Sgbgqfwj26JfwfTHPmgsQ5CaQDxzx5m/2usW5HKTHqpisY/4s34Ig7NozlLcIV7KCB87nB+HJJHcj5ln6U4FH/ym7OVTJWZHlskm2TptM4gx4USuChB0wntlz7hznDRUOw/l6tGaKQZsVVWuT5CJ+wtfrjPtDIao723jsxVC4PUnMtcWz64bi1FQ5TNsjkaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rHUZYWCDNshnFQamWW6UBDRL4+XP1XxlcolKs0cPruE=; b=nB2qlCs6dGNIkCczYOoP7bXimWMgIcP/H20vsjKRRmQEppK4QFKgr/bPOUuR4hKAiDlK5e3tqVuS2AmZ8gFos4sH9BF7pH8/No2+JxJFIc5FPCego6876O9wvPDsxvR2o2CqyK7s4k987PU1YSVupHK51QXxB47ojt/ecR/TWYk= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MN2PR10MB3264.namprd10.prod.outlook.com (2603:10b6:208:131::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.15; Fri, 11 Mar 2022 11:53:48 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5%4]) with mapi id 15.20.5061.022; Fri, 11 Mar 2022 11:53:48 +0000 Date: Fri, 11 Mar 2022 14:53:24 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Srinivasa Rao Mandadapu Cc: lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Mark Brown , Venkata Prasad Potturu Subject: [linux-next:master 8752/11953] sound/soc/codecs/lpass-macro-common.c:53 lpass_macro_pds_init() warn: passing zero to 'ERR_PTR' Message-ID: <202203111754.32TAMFKD-lkp@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: JN2P275CA0010.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:3::22) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f0a53320-c64b-41ec-1a00-08da0355cd5c X-MS-TrafficTypeDiagnostic: MN2PR10MB3264:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HSZmb8Fou7vtkxrzdBGx8/YOwC8z3ta+bx8qKD7o1Hb81NgvZUbI3nPzyXGsyho4W3+UR17OnV9yO5moxxybrNm4U4w7soszdRkYfaGrkOr1uCAahuPbKttCDCoE3zpWrI+nEkaxBGD4SV9ngFq82EEM9VU2A8wV+J1W19eF8RLgUSiWZE2yQURtwsMGIp9YnzjGZtdHbmkca9D5iXt4RW0uyzNpr5XigJvVtdn3USvQmVlvDZXE95wY29mdhzCVl0+8P4FbMXjuUtwKv8kxDPS33nGFPDFsRhFegsuTt7l24qSbv0HhLIqTJcf0OZ4N8IbNHRhieDxv85THEJ6RVRlleU7y/b5V7n2U8eGxkyKuCrYE98RjxWDtL1IMAPPMXeTPFTgq5hrjQj1jh7LCC/obP57n8hqa8cFz8Wec2rsZnM0IEzvHJ08VOnifbdhrVsQ+z4jrQFo2dKPTH+Yb5gDe2HJaGs6QWL/1nYRoZpRSwJmfYvXP6BZcVD5aOzogyTQomCkJHBIdXqbJjAw3vvbZKGshk7/gI1QPIC7xPixDn5L0axOoT+/r2oXg1aapcNM1wuNP72vHmfH2ftePnl9hmQ5uomr0zVDdsZCFy6xOb75G5WkwfkLA5hEdxdYTHRB4jwkA6A/CqWaujrZvYPGEBdTqj9A/s0EFnUCF6jS/YcXsBBRLF9UX2teT2mr+YeKCpB4K52CQBAAcOfK4OmzYc8uw81HDVn+772+vjZhj59tyYQhWgVQu1IBY8IyWVptl7ymFqVrx78hprxF27B7Vmu6Dal4CSHCHazydkf0LPg0lFsRBOGLf02ehLC+2vyf9f9fqkx3Yc2sgjOV8kA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(4326008)(9686003)(6512007)(508600001)(5660300002)(966005)(38350700002)(38100700002)(36756003)(66946007)(66556008)(66476007)(8676002)(1076003)(26005)(186003)(6666004)(8936002)(86362001)(83380400001)(54906003)(6916009)(52116002)(6506007)(316002)(2906002)(44832011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gE4YPTBntkEZbtFiWWmqChxmPkVlddy/fGNe+ZobxiU1c+y1JGewYmDHELxX?= =?us-ascii?Q?6Go8wyrB1bhsh7DIQAK6p8At1Uw+U21MkfytKcKdCDglv3Cz+JBP4Tu6TgPg?= =?us-ascii?Q?RXo+9WWI6mPR6Ht6Cxsgw/rN3xfmklXEDIxxfwhd9ZQl74n1fmsvadbss7oY?= =?us-ascii?Q?KvQrmbxahL+6en59pAhSD4ZfL5MUTKAywD8CGpGpiaVQ/S+CLdKqG+S6SLa3?= =?us-ascii?Q?huBaWtHHf5xblu2zIBio3CfVsy/qFreJL2BNOzxvkuAtCvEktVY5xmNQQ+ir?= =?us-ascii?Q?JwZrgR2XzhgisLdpjB/T0UzRXUfLDktRsJci4duZ6DEjqjDWh3NZGapPhk8m?= =?us-ascii?Q?FL8hWvS2LDCU1vZ88ndPOGAu99mdVRV/N1UIrQHL3Gl6VQ3nLtd7HvJmcPp0?= =?us-ascii?Q?yf3T4T+VDGIQZwE2qbnWm0R1F403ygpt2p8RyIPlihZ4Z+DUqR9cAlnOjFRK?= =?us-ascii?Q?57QgjojsjGKmLZVFoF4kEiKo2RVs4vO1AR7M7ZCt7Iathz1R8Imm0xVmrvvv?= =?us-ascii?Q?Qu45O+ZaXYS3rSEsZ45xY0LySHTh35LJ1K5duEddIqyZkwUyZCr/yEV9volM?= =?us-ascii?Q?Ox6+JyL3+SPqobilvl6j3XPzhS984QBlkECsoOCTWIirHvT08fBREmDixaIh?= =?us-ascii?Q?ObJIQnEyPiQsyplgJhXx//+JHihXZnwOk6uS5Cs9dgwtfgMx4kiFtW0C8KY+?= =?us-ascii?Q?ANfTtElI3Hz3gxE16G0bCjYpXtvPv8vUUC5/qKfcxkV6jYRUQgzDUbfohMg0?= =?us-ascii?Q?4FhCG+9h/kfdsqKv+1WGGQ6FEWd5yiPdcOE9+4e+UV6UYL2OU9u5ivxlhBj+?= =?us-ascii?Q?qZGE0ykETNAYLY4V8Z87K6UWhCwQwAgNGsx2Z2gfKC9QdGHb9La7Jsjg8Hfk?= =?us-ascii?Q?lU3EnAsecwKAL/Vluwj0B9+W2FSF+WdR/TnJTG3Lg1uc6OJ+mqrDPrqzp0wE?= =?us-ascii?Q?H3ZQED4ELeuB735P92KVs4tPyZRe1OCtSdxkF2zvtg10qtYKtIIycSJQt4dr?= =?us-ascii?Q?GvW80qlNteA0/fvLKk2w7BNHNHNUsP5IDx14j4bxsLjmkDvzFlkJwL8gL/jq?= =?us-ascii?Q?6qHU8GwIJ6hlWnBAVud+cQ3iKqvC9Pe/N0bOxnz3QGlJ2TFOWgBwiTN2eD4x?= =?us-ascii?Q?YFM5WkR8lew8LFWRv02MgB5m2+kSmnlf0q/DGrX5DL2Pz98Zi9zZi83J4kff?= =?us-ascii?Q?2CrI9t+ESOfFZoQ9ZWCGjI/QRrJz5yQh0DV2HXWkWzsrxu+zmSWS+ZGzUeUh?= =?us-ascii?Q?s5GJ2Oa2p7uDLi+54IkqvCAhFcyjI/C447+EAOcpKrNFJjZf+I80SWWeQszH?= =?us-ascii?Q?LkgW4e2+rHWDtXNbe8BGgkq5i9O1KBHCDShNQpITrYGKGih2bXZPKEYgb85v?= =?us-ascii?Q?5AGddRnkpAD3jUn1RWcE6hX89C9DRud7T8iB2ZbsDroRqoZ+0BmkPZhNhMlZ?= =?us-ascii?Q?TgUl7eiIihQ1AQxsn7pNqSvvfjaUGpk7wYFWYwHkqcJs6AEokzefEwviyHHS?= =?us-ascii?Q?MbuzrjDAv42BgAQqRR0V5B6kAozOab5ViAtpu9nWnTzngTL4B6rsd3dK6/jN?= =?us-ascii?Q?tBagW1YiDP8rPZtBxsExPh1GYth4ltZ+r5FvkGVJ8AhRQxP2qh6kdyuvip/H?= =?us-ascii?Q?U6TkaJ8pJ2v6C/q5B2nhc9RKNkdqPkgK9lGMNqnXZ69Q433vwBYGizbnlUoY?= =?us-ascii?Q?eaZ6Cw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0a53320-c64b-41ec-1a00-08da0355cd5c X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 11:53:48.0846 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WMnZFAAWrmfbZ+9JeFjJu3FbNbkJtrsGx/kkbtgSlxejl98FISxsyhUpjvW9kT1VZxSIUtsWH7Q0jDfQgxJdN0hme3c2HSyWWGhS1Nn6XYw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3264 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10282 signatures=692556 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203110058 X-Proofpoint-GUID: VmHJqrJn5d4lTWW7AZnB-KE9Tmvt9Bp5 X-Proofpoint-ORIG-GUID: VmHJqrJn5d4lTWW7AZnB-KE9Tmvt9Bp5 X-Rspamd-Queue-Id: C3B4E14001D X-Stat-Signature: 7ihk4q1ga3ik9ncunnze7mmm3wtukr35 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=yfIvKpH2; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=nB2qlCs6; spf=none (imf26.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1646999637-13047 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 71941773e143369a73c9c4a3b62fbb60736a1182 commit: 9e3d83c52844f955aa2975f78cee48bf9f72f5e1 [8752/11953] ASoC: codecs: Add power domains support in digital macro codecs config: arm-randconfig-m031-20220310 (https://download.01.org/0day-ci/archive/20220311/202203111754.32TAMFKD-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: sound/soc/codecs/lpass-macro-common.c:53 lpass_macro_pds_init() warn: passing zero to 'ERR_PTR' vim +/ERR_PTR +53 sound/soc/codecs/lpass-macro-common.c 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 14 struct lpass_macro *lpass_macro_pds_init(struct device *dev) 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 15 { 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 16 struct lpass_macro *l_pds; 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 17 int ret; 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 18 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 19 if (!of_find_property(dev->of_node, "power-domains", NULL)) 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 20 return NULL; Returning NULL here will lead to a crash in tx_macro_runtime_resume() When a function returns a mix of NULL and error pointers, then NULL means the feature is deliberately disabled. It's not an error, it's a deliberate choice by the distro or sys admin. The caller has to be written to allow the feature to be disabled. An example of this might be LEDs. Maybe people don't want LEDs so code has to asume that the led->ops pointer might be NULL and check for that before dereferencing it. 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 21 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 22 l_pds = devm_kzalloc(dev, sizeof(*l_pds), GFP_KERNEL); 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 23 if (!l_pds) 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 24 return ERR_PTR(-ENOMEM); Good. 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 25 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 26 l_pds->macro_pd = dev_pm_domain_attach_by_name(dev, "macro"); 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 27 if (IS_ERR_OR_NULL(l_pds->macro_pd)) 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 28 return NULL; If this feature is optional then it should be: if (IS_ERR_OR_NULL(l_pds->macro_pd)) return ERR_CAST(l_pds->macro_pd); The admin deliberately chose to enable the feature so we can't just ignore errors and convert them to NULL. 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 29 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 30 ret = pm_runtime_get_sync(l_pds->macro_pd); This is correct, but the documentation for pm_runtime_get_sync() says to consider pm_runtime_resume_and_get() instead. The error handling is slightly different and easier. I forget the details. 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 31 if (ret < 0) { 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 32 pm_runtime_put_noidle(l_pds->macro_pd); 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 33 goto macro_err; 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 34 } 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 35 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 36 l_pds->dcodec_pd = dev_pm_domain_attach_by_name(dev, "dcodec"); 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 37 if (IS_ERR_OR_NULL(l_pds->dcodec_pd)) 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 38 goto dcodec_err; Again this IS_ERR_OR_NULL() check needs to preserve the error codes: if (IS_ERR_OR_NULL(l_pds->dcodec_pd)) { ret = PTR_ERR(l_pds->dcodec_pd); goto dcodec_err; } 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 39 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 40 ret = pm_runtime_get_sync(l_pds->dcodec_pd); 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 41 if (ret < 0) { 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 42 pm_runtime_put_noidle(l_pds->dcodec_pd); 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 43 goto dcodec_sync_err; 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 44 } 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 45 return l_pds; 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 46 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 47 dcodec_sync_err: 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 48 dev_pm_domain_detach(l_pds->dcodec_pd, false); 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 49 dcodec_err: 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 50 pm_runtime_put(l_pds->macro_pd); 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 51 macro_err: 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 52 dev_pm_domain_detach(l_pds->macro_pd, false); 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 @53 return ERR_PTR(ret); 9e3d83c52844f95 Srinivasa Rao Mandadapu 2022-02-26 54 } --- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org