From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3EE7C433F5 for ; Fri, 11 Mar 2022 02:02:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58F278D0002; Thu, 10 Mar 2022 21:02:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 516D88D0001; Thu, 10 Mar 2022 21:02:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DEB88D0002; Thu, 10 Mar 2022 21:02:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id 27D788D0001 for ; Thu, 10 Mar 2022 21:02:11 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D5BB39CD67 for ; Fri, 11 Mar 2022 02:02:10 +0000 (UTC) X-FDA: 79230455220.24.1EEF784 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf27.hostedemail.com (Postfix) with ESMTP id 6D5BE40022 for ; Fri, 11 Mar 2022 02:02:10 +0000 (UTC) Received: by mail-yb1-f201.google.com with SMTP id p69-20020a257448000000b006295d07115bso6113541ybc.14 for ; Thu, 10 Mar 2022 18:02:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=2hsaR8WAxcqWtbQLCYo/TxbTYR2phuKd4uO3CbSGXis=; b=Q4jqn7qEyVL5UGQm48tyWxHXBIKnYgeh4VJEcNABuXL8XnVgyd64deKgPWFzS66j7R g19GwgGrR2Qn0tEHazNj8b5zGGY9w6dYR/QXR3bG0gkvWfu9DJlLW79z0K/C/zsxfTge GcJ5vm2PigirvczYxMY0bKFOqMgstn4HhF3LhKS5zTfBa4NqlI/XoXoEUjMe2v7dxm83 78tk4oqkEHsC95dm3g4GEnbysiblZLmhiaBQwu415BH228ci8sg+b9UrKjafX1FBmrjF +3UHolf80KtUStuJ7TfPlOzTfUAoZ1d5e7HGQhKJXtFMuZ4vYMUHLKLRBrrn/Zia00/l V3NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=2hsaR8WAxcqWtbQLCYo/TxbTYR2phuKd4uO3CbSGXis=; b=sLGhhe3ZlCqD2JnbV/gImiM8J1rj6JDvg/ESA+bKUZnfmHnoqGltGIfxr6QRrnrlF5 XmNGevsH2QphwMLARcUXWl2fmBLp6e1y2eREdM8+pItzM4cKbkDsnEc+JDNFTpkCCl8z kpvFg6dgTqWIB0ik38V8WeGd6y9lLm5V07mTRuQjS24bN0lB0v99mvIJ4303dcbAvW0z WK7pCKC++PQTsxiBq7CCIS/SyNeOrVbZ8w6CsdWmkyfi+8yyROGjrqN5aBgtCT/zEOLs 4z9L1kLz7vtwzwiXmEYMi2GW1BOTcAtXU+qBpPY+CfmzYBe6R8vxIJJ/NKIheEfBWwIW j5OA== X-Gm-Message-State: AOAM532KJkO5AQP35diblanO5NFtc0ilaWSRJ6PttEkuhsxJvVH9xUlP 2OHhv7mmQoXnLznN6yB5uOTuQKFcC13A7Q== X-Google-Smtp-Source: ABdhPJzOTCYYIPtqY5f4TpqaFYLmmfYjNi7qJZgtvYTI9QaocypqR0Q/Ra+o/HDjGm3UwlCg1pPVe9yP2r+USg== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:28b]) (user=shakeelb job=sendgmr) by 2002:a81:7556:0:b0:2dc:6ea9:8d53 with SMTP id q83-20020a817556000000b002dc6ea98d53mr6501468ywc.413.1646964129540; Thu, 10 Mar 2022 18:02:09 -0800 (PST) Date: Fri, 11 Mar 2022 02:02:06 +0000 In-Reply-To: <20220310092456.GJ15701@techsingularity.net> Message-Id: <20220311020206.qncvybld6zrgmm3m@google.com> Mime-Version: 1.0 References: <20220310092456.GJ15701@techsingularity.net> Subject: Re: [PATCH] mm/page_alloc: check high-order pages for corruption during PCP operations From: Shakeel Butt To: Mel Gorman Cc: Andrew Morton , Eric Dumazet , Eric Dumazet , linux-kernel , linux-mm , Vlastimil Babka , Michal Hocko , Wei Xu , Greg Thelen , Hugh Dickins , David Rientjes Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Q4jqn7qE; spf=pass (imf27.hostedemail.com: domain of 3oa0qYggKCL4wleoiipfksskpi.gsqpmry1-qqozego.svk@flex--shakeelb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3oa0qYggKCL4wleoiipfksskpi.gsqpmry1-qqozego.svk@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6D5BE40022 X-Stat-Signature: nb75mgnj79yj9k1tg7bncx41wwnpdb57 X-HE-Tag: 1646964130-11580 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 10, 2022 at 09:24:56AM +0000, Mel Gorman wrote: > Eric Dumazet pointed out that commit 44042b449872 ("mm/page_alloc: allow > high-order pages to be stored on the per-cpu lists") only checks the head > page during PCP refill and allocation operations. This was an oversight > and all pages should be checked. This will incur a small performance > penalty but it's necessary for correctness. > Fixes: 44042b449872 ("mm/page_alloc: allow high-order pages to be stored > on the per-cpu lists") > Reported-by: Eric Dumazet > Signed-off-by: Mel Gorman > Acked-by: Eric Dumazet Reviewed-by: Shakeel Butt