From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EC2C433F5 for ; Thu, 10 Mar 2022 23:57:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 868A48D0002; Thu, 10 Mar 2022 18:57:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 817F78D0001; Thu, 10 Mar 2022 18:57:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B8088D0002; Thu, 10 Mar 2022 18:57:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 5C7C38D0001 for ; Thu, 10 Mar 2022 18:57:32 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 31B62248E6 for ; Thu, 10 Mar 2022 23:57:32 +0000 (UTC) X-FDA: 79230141144.11.3DE58A9 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf19.hostedemail.com (Postfix) with ESMTP id C6CF71A0018 for ; Thu, 10 Mar 2022 23:57:31 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id m12so8956111edc.12 for ; Thu, 10 Mar 2022 15:57:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OkAryEzutT6iAK7gGQZ0EX71N3D+2tmBltCJ6yrSjxw=; b=IZ7jNCsyI1YiomKE/iwIDgeEEkJXqEWgThkJSlbsnONKYJQVuGgW0mVeMkdfA+jZRH dNX+J5WhKU9aDgLZozigkohOsN23JbVUrVCEbKkIyM/HmVWPmsCDo+ve/OmcMY/R4L46 wc+Lpbkm0irrf4LPBje32HvD7opm/vcqBJyRTGLFpMx/D1zcb1xYMpYJhf0+HgrDPAp5 6tladH5AFii+KrgzJAR0ueHVwgFZUs3pXkyggWSMBbFFukQv65AhTfvyA0Ze4E0qEcDo PqrBduRvnl0lXJSkKKKVsmhC9wNqLAIbF2JT18xVIRI6ZIN+LUKgZZB2N2vgkv7hhx2T v1YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=OkAryEzutT6iAK7gGQZ0EX71N3D+2tmBltCJ6yrSjxw=; b=XMwYSMnRmbXNkVDWtz4tvIFIJtqk4liXoDr3ZVspWQmI9EM0mMiyHdIhuDkIDoOKQw 2iEPKVzoSHUH+kOvJRtLUb6OjPlitaooKVDVtoda+7HIEIEGeLmsJx1qZSgTIwG2WGnF 9SBVqc3JC3BlQOtgTFObN4oBuRRW7CHjFTUAztKtaYmpqiiKb7+EHgsLunYl6s0KY0AU 7Or6m4YDTCzTpqfJHVx5flenrnhTkVX3NJr51X8kbQEVGDP1RMFAadxx1VBoBlOj5qUY pYWycZvXYBlMJ6eiHHhPbkAkX/sY0+bz1+GJsNgefOeJVtRAVw+2aoJf0EgAXqcDUaDp CtJA== X-Gm-Message-State: AOAM532qjFm/tRN1LoaIAeO4aLmziqPKjmKW1ZdlqP6aLj8j/TAs5Z2H lZt0/jNkCArWXZPLMx4mlyda53HwvZ4= X-Google-Smtp-Source: ABdhPJyQw+NoCzOJn9Js/MkKoWiVxSPTj6IHgbeVn2xwr6FxI3Y4MzlRCxRlKdnGUcNfr19UqKPDlg== X-Received: by 2002:a05:6402:5304:b0:413:8a0c:c54a with SMTP id eo4-20020a056402530400b004138a0cc54amr6616765edb.172.1646956650673; Thu, 10 Mar 2022 15:57:30 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id v5-20020a50c405000000b004161123bf7asm2548472edf.67.2022.03.10.15.57.30 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Mar 2022 15:57:30 -0800 (PST) Date: Thu, 10 Mar 2022 23:57:29 +0000 From: Wei Yang To: Michal Hocko Cc: Wei Yang , hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Tim Chen Subject: Re: [PATCH 3/3] mm/memcg: add next_mz back if not reclaimed yet Message-ID: <20220310235729.txnjuhcptsp2sc2a@master> Reply-To: Wei Yang References: <20220308012047.26638-1-richard.weiyang@gmail.com> <20220308012047.26638-3-richard.weiyang@gmail.com> <20220309004620.fgotfh4wsquscbfn@master> <20220310011350.2b6fxa66it5nugcy@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C6CF71A0018 X-Stat-Signature: cqtq63b7jka5ndik4sk9kmcbiz6ambut Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IZ7jNCsy; spf=pass (imf19.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1646956651-296209 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 10, 2022 at 09:53:59AM +0100, Michal Hocko wrote: >On Thu 10-03-22 01:13:50, Wei Yang wrote: >> On Wed, Mar 09, 2022 at 02:48:45PM +0100, Michal Hocko wrote: >> >[Cc Tim - the patch is http://lkml.kernel.org/r/20220308012047.26638-3-richard.weiyang@gmail.com] >> > >> >On Wed 09-03-22 00:46:20, Wei Yang wrote: >> >> On Tue, Mar 08, 2022 at 09:17:58AM +0100, Michal Hocko wrote: >> >> >On Tue 08-03-22 01:20:47, Wei Yang wrote: >> >> >> next_mz is removed from rb_tree, let's add it back if no reclaim has >> >> >> been tried. >> >> > >> >> >Could you elaborate more why we need/want this? >> >> > >> >> >> >> Per my understanding, we add back the right most node even reclaim makes no >> >> progress, so it is reasonable to add back a node if we didn't get a chance to >> >> do reclaim on it. >> > >> >Your patch sounded familiar and I can remember now. The same fix has >> >been posted by Tim last year >> >https://lore.kernel.org/linux-mm/8d35206601ccf0e1fe021d24405b2a0c2f4e052f.1613584277.git.tim.c.chen@linux.intel.com/ >> >It was posted with other changes to the soft limit code which I didn't >> >like but I have acked this particular one. Not sure what has happened >> >with it afterwards. >> >> Because of this ? >> 4f09feb8bf: vm-scalability.throughput -4.3% regression >> https://lore.kernel.org/linux-mm/20210302062521.GB23892@xsang-OptiPlex-9020/ > >That was a regression for a different patch in the series AFAICS: >: FYI, we noticed a -4.3% regression of vm-scalability.throughput due to commit: >: >: commit: 4f09feb8bf083be3834080ddf3782aee12a7c3f7 ("mm: Force update of mem cgroup soft limit tree on usage excess") > >That patch has played with how often memcg_check_events is called and >that can lead to a visible performance difference. Yes, I mean maybe because of this regression, the whole patch set is removed. >-- >Michal Hocko >SUSE Labs -- Wei Yang Help you, Help me